[jira] [Commented] (COLLECTIONS-759) An issue about the failed with CI about the checkstyle of NewlineAtEndOfFile.

["Bruno P. Kinoshita (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COLLECTIONS-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086289#comment-17086289 ] 

Bruno P. Kinoshita commented on COLLECTIONS-759:
------------------------------------------------

Hi [~Guoping]

>Can the checkstyle NewlineAtEndOfFile be warning not error ?
>I don't think the checkstyle would affect the used with the software.

I think if this is changed to a warning, it might be ignored. The reason for having these checks enabled in the CI is exactly to alert us to fix. Preferably before merging pull requests. But eventually broken builds get merged and master may be broken for a while (which is not a huge problem IMO).

So if disabled, eventually we would get other PR's to fix the missing newline at end of file. I think it's better to ask the PR creator to fix that, instead of needing an extra PR from another contributor or developer.

I've fixed it locally by adding the newline, and then running each file through `dos2unix $FILE_NAME`. Creating PR now.

Thanks!

Bruno

> An issue about the failed with CI about the checkstyle of NewlineAtEndOfFile.
> -----------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-759
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-759
>             Project: Commons Collections
>          Issue Type: Bug
>    Affects Versions: 4.5
>            Reporter: Chen Guoping
>            Priority: Minor
>
> commons-collections\src\conf\checkstyle.xml
>   <module name="NewlineAtEndOfFile">
>     <property name="lineSeparator" value="{color:red}lf{color}" />
>   </module>
> [The link of CI|https://travis-ci.org/github/apache/commons-collections/jobs/672844382]
> {code:java}
> [ERROR] src/main/java/org/apache/commons/collections4/ArrayUtils.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
> [ERROR] src/test/java/org/apache/commons/collections4/queue/SynchronizedQueueTest.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
> [ERROR] src/test/java/org/apache/commons/collections4/junit/AbstractAvailableLocalesTest.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
> [ERROR] src/test/java/org/apache/commons/collections4/junit/SetDefaultLocaleTestRule.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
> [ERROR] src/test/java/org/apache/commons/collections4/junit/ObjectToStringComparator.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  01:41 min
> [INFO] Finished at: 2020-04-09T07:11:16Z
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on project commons-collections4: You have 5 Checkstyle violations. -> [Help 1]
> {code}
> But I test the checkstyel locally with cmd :
> mvn clean ; mvn checkstyle:checkstyle
> The result is 
> Summary
> Files	 Info	 Warnings	 Errors
> 590	0	0	{color:red}590{color}
> Details
> org/apache/commons/collections4/AbstractArrayListTest.java
> Severity	Category	Rule	Message	Line
>  Error	misc	{color:red}NewlineAtEndOfFile	{color}Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.	1
> Can the checkstyle NewlineAtEndOfFile	 be warning not error ?
> I don't think the checkstyle would affect the used with the software.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)