[GitHub] [lucene] gsmiller commented on pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader

["gsmiller (via GitHub)" <gi...@apache.org>]

gsmiller commented on PR #12171:
URL: https://github.com/apache/lucene/pull/12171#issuecomment-1448296961

   Thanks for opening a PR and for the idea! I'm a bit concerned adding this as a public API though. I see the cache as a bit of an implementation detail that could change in the future, but putting a public API on it makes changing it a bit trickier. In fact, there's actually an open issue where some benchmarking indicated the cache might not be providing any benefits (looks like we need to follow up there to see if that's still true): #11106
   
   So for now, I'm not convinced we should actually add these public APIs. As a next step, let's get to the bottom of how much benefit we're actually seeing from the caches and challenge if we still need all the complexity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org