You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Arvind Prabhakar (JIRA)" <ji...@apache.org> on 2012/05/26 23:49:24 UTC
[jira] [Created] (FLUME-1230) Sink gets initialized even when not
active
Arvind Prabhakar created FLUME-1230:
---------------------------------------
Summary: Sink gets initialized even when not active
Key: FLUME-1230
URL: https://issues.apache.org/jira/browse/FLUME-1230
Project: Flume
Issue Type: Bug
Reporter: Arvind Prabhakar
Assignee: Arvind Prabhakar
Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
Following configuration can reproduce this scenario:
{noformat}
agent.sources = s
agent.channels = c
#agent.sinks = k1 k2
agent.sources.s.type = netcat
agent.sources.s.port = 12121
agent.sources.s.bind = localhost
agent.sources.s.channels = c
agent.channels.c.type = memory
agent.sinks.k1.type = logger
agent.sinks.k1.channel = c
agent.sinks.k2.type = null
agent.sinks.k2.channel = c
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285492#comment-13285492 ]
Hudson commented on FLUME-1230:
-------------------------------
Integrated in flume-trunk #216 (See [https://builds.apache.org/job/flume-trunk/216/])
FLUME-1230. Components can get initialized even when not active.
(Hari Shreedharan via Mike Percy) (Revision 1344126)
Result = SUCCESS
mpercy : http://svn.apache.org/viewvc/?view=rev&rev=1344126
Files :
* /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
* /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1230-refactor.diff, FLUME-1230.patch
>
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-1230:
------------------------------------
Attachment: FLUME-1230-refactor.diff
@Hari - here is a minor refactoring of the configuration code that removes some duplication of logic. Also, simplifies it to a certain extent. I have added some tests, existing tests pass and done basic manual verification. All seems to be ok. But I am sure that there are bugs in it, so take it cautiously if you would like to.
Patch generated on revision 1342958
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
> Attachments: FLUME-1230-refactor.diff
>
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1230:
------------------------------
Resolution: Fixed
Fix Version/s: v1.2.0
Status: Resolved (was: Patch Available)
+1. Patch committed. Thanks Hari!
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1230-refactor.diff, FLUME-1230.patch
>
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285458#comment-13285458 ]
Mike Percy commented on FLUME-1230:
-----------------------------------
Hey guys, let's push this fix in and continue the needed refactoring in another JIRA.
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
> Attachments: FLUME-1230-refactor.diff, FLUME-1230.patch
>
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285123#comment-13285123 ]
Hari Shreedharan commented on FLUME-1230:
-----------------------------------------
Arvind - if you don't mind, I can look into this issue.
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar reassigned FLUME-1230:
---------------------------------------
Assignee: Hari Shreedharan (was: Arvind Prabhakar)
Hari - thanks, go for it.
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285467#comment-13285467 ]
Hari Shreedharan commented on FLUME-1230:
-----------------------------------------
Thanks Mike. I have filed FLUME-1237 to track the refactoring Arvind suggested above.
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1230-refactor.diff, FLUME-1230.patch
>
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated FLUME-1230:
------------------------------------
Attachment: FLUME-1230.patch
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
> Attachments: FLUME-1230-refactor.diff, FLUME-1230.patch
>
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1230) Sink gets initialized even when not
active
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1230:
------------------------------
Status: Patch Available (was: Open)
> Sink gets initialized even when not active
> ------------------------------------------
>
> Key: FLUME-1230
> URL: https://issues.apache.org/jira/browse/FLUME-1230
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Hari Shreedharan
> Attachments: FLUME-1230-refactor.diff, FLUME-1230.patch
>
>
> Flume configuration requires that components that are not declared in the active lists (agent.sources, agent.sinks, agent.channels, and agent.sinkgroups) be disabled by default. However, in some cases, sinks that are not in the active list will get initialized and started.
> Following configuration can reproduce this scenario:
> {noformat}
> agent.sources = s
> agent.channels = c
> #agent.sinks = k1 k2
> agent.sources.s.type = netcat
> agent.sources.s.port = 12121
> agent.sources.s.bind = localhost
> agent.sources.s.channels = c
> agent.channels.c.type = memory
> agent.sinks.k1.type = logger
> agent.sinks.k1.channel = c
> agent.sinks.k2.type = null
> agent.sinks.k2.channel = c
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira