You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/12/05 14:37:22 UTC
[GitHub] [fineract] ruchiD opened a new pull request, #2790: FINERACT-1818-Loan-Retrieve-Api-data-addition
ruchiD opened a new pull request, #2790:
URL: https://github.com/apache/fineract/pull/2790
## Description
1.Added computation of amount summation for various Loan Transactions based on transaction type and reverse status, for summary in Loan get by loanId api.
2.Added Loan Transaction amounts summary fields in Loan summary.
3.Swagger Api changes for Loan Summary.
4.Integration test.
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2790: FINERACT-1818-Loan-Retrieve-Api-data-addition
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2790:
URL: https://github.com/apache/fineract/pull/2790#discussion_r1040833610
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanSummaryData.java:
##########
@@ -120,4 +139,70 @@ public LoanSummaryData(final CurrencyData currency, final BigDecimal principalDi
this.writeoffReason = writeoffReason;
this.totalRecovered = totalRecovered;
}
+
+ public static LoanSummaryData withTransactionAmountsSummary(final LoanSummaryData defaultSummaryData,
+ final Collection<LoanTransactionData> loanTransactions) {
+
+ BigDecimal totalMerchantRefund = computeTotalAmountForNonReversedTransactions(LoanTransactionType.MERCHANT_ISSUED_REFUND,
Review Comment:
Wouldnt it be better to iterate through the transactions just once and calculate the different balances at the same time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2790: FINERACT-1818-Loan-Retrieve-Api-data-addition
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2790:
URL: https://github.com/apache/fineract/pull/2790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org