You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/07 13:00:32 UTC
[GitHub] [camel] rnetuka opened a new pull request, #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
rnetuka opened a new pull request, #8494:
URL: https://github.com/apache/camel/pull/8494
Issue: https://issues.apache.org/jira/browse/CXF-8762
Actually, there are the SOAPAction headers.
1. SOAPAction Camel header (stored top-level in the context)
2. SOAPAction Protocol header (stored in the context inside PROTOCOL_HEADERS)
The value inside PROTOCOL_HEADERS is used in CXF when creating a HTTP request. It should be quoted as stated in this specification. http://www.ws-i.org/Profiles/BasicProfile-1.1.html#SOAPAction_HTTP_Header
I believe we should leave the value stored top-level in the context unquoted, since it has nothing to do with the HTTP protocol. Because of that, I'm removing the quotes inside _propagateHeadersFromCxfToCamel_.
Any comment are welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8494:
URL: https://github.com/apache/camel/pull/8494#issuecomment-1273467772
There are too many components to be tested in this PR, components were removed or the code needs a rebase: (307 likely to be tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ffang commented on pull request #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
Posted by GitBox <gi...@apache.org>.
ffang commented on PR #8494:
URL: https://github.com/apache/camel/pull/8494#issuecomment-1271700826
Hi @rnetuka ,
Looks good to me!
And please use the util method in StringHelper.java to remove the quote as @davsclaus mentioned about.
Thanks!
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8494:
URL: https://github.com/apache/camel/pull/8494#issuecomment-1271658326
There is an util method to remove quotes at
https://github.com/apache/camel/blob/main/core/camel-util/src/main/java/org/apache/camel/util/StringHelper.java#L144
Can you use this method, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8494:
URL: https://github.com/apache/camel/pull/8494#issuecomment-1271561461
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8494:
URL: https://github.com/apache/camel/pull/8494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rnetuka commented on pull request #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
Posted by GitBox <gi...@apache.org>.
rnetuka commented on PR #8494:
URL: https://github.com/apache/camel/pull/8494#issuecomment-1273292440
Thanks for the review guys! I've added the StringHelper's removeLeadingAndEndingQuotes method call as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8494: [CXF-8762] CXF client sends the SOAPAction header without quotes
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8494:
URL: https://github.com/apache/camel/pull/8494#issuecomment-1273700651
I backported to 3.18.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org