[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40150: [SPARK-41834][CONNECT] Implement SparkSession.conf

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #40150:
URL: https://github.com/apache/spark/pull/40150#discussion_r1116654223


##########
python/pyspark/sql/conf.py:
##########
@@ -35,12 +35,14 @@ def __init__(self, jconf: JavaObject) -> None:
         self._jconf = jconf
 
     @since(2.0)
-    def set(self, key: str, value: str) -> None:
+    def set(self, key: str, value: Union[str, int, bool]) -> None:
         """Sets the given Spark runtime configuration property."""

Review Comment:
   If this gets merged soon, I think we can just mark it as 3.4.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org