You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/10/06 19:53:04 UTC
[PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
paleolimbot opened a new pull request, #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180
Closes #1113.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180#issuecomment-1757552585
Sorry, I was out let me look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180#issuecomment-1756596519
Just bumping this (it's holding up a submission of 0.7.0 for adbcsqlite, which is currently failing a CRAN check that will be fixed by this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180#issuecomment-1751701824
Is this mostly a problem with the sqlite.c module? From spot checking a few of those printf's it looks like that format is mostly used to print sized integral values. If problematic, replacing with PRId64 and PRIu64 might be another way to fix it and would be more correct (assuming at least C99)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180#issuecomment-1751706648
Does r require C89 support? I think long long and the format specifier are technically C99. Without that requirement I think Windows had a `%I64d` format specifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180#issuecomment-1751702099
Ah sorry ignore what I wrote - should have read the OP first...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r): Build with __USE_MINGW_ANSI_STDIO to enable use of lld in format strings [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1180:
URL: https://github.com/apache/arrow-adbc/pull/1180#issuecomment-1751774996
> Does r require C89 support? I think long long and the format specifier are technically C99. Without that requirement I think Windows had a %I64d format specifier
It seems that `PRId64` resolves to `lld`...redefining that is also an option (but this way seems less intrusive). The mingw headers have gotten much better with recent gcc (plus recent versions of R, which use UCRT instead of MSVCRT and much newer gcc)...there is at least one other place where we had to patch in a missing errno code that they'd forgotten to add in early versions. I think this is just an oversight (it seems to have come up quite a bit given the google results).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org