[GitHub] [daffodil] stevedlawrence commented on a change in pull request #536: WIP: Added -Y warning check options

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #536:
URL: https://github.com/apache/daffodil/pull/536#discussion_r617485375



##########
File path: daffodil-lib/src/main/scala/org/apache/daffodil/oolag/OOLAG.scala
##########
@@ -308,7 +308,7 @@ object OOLAG extends Logging {
      * Unconditionally, evaluate the LV arg in order to insure all checks for this
      * object are performed.
      */
-    private def requiredEvaluationsAlways(lv: OOLAGValueBase) : Unit = {
+    private def requiredEvaluationsAlways(lv: OOLAGValueBase) (): Unit = {

Review comment:
       A few of the changes in this file look incorrect--looks like theres an extra set of parens. Is this a accidental find/replace due to the space before the colon?

##########
File path: daffodil-propgen/src/test/scala/org/apache/daffodil/propGen/TestPropertyGenerator.scala
##########
@@ -65,7 +65,7 @@ class TestPropertyGenerator {
     val mx = pg.genAttributeGroup(sch)
     assertTrue(mx.contains(""" = convertToBoolean(findProperty("prefixIncludesPrefixLength").value)"""))
     assertTrue(mx.contains("""LengthKindMixin"""))
-    assertTrue(mx.contains("""def lengthPropertiesAGInit() : Unit = {"""))
+    assertTrue(mx.contains("""def lengthPropertiesAGInit() (): Unit = {"""))

Review comment:
       Same issue here

##########
File path: daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/PropertyGenerator.scala
##########
@@ -595,7 +595,7 @@ object Currency {
   def generateNonEnumStringInit(pgName: String, propInits: Seq[String]) = {
     val initFuncName = initialLowerCase(pgName)
     """
-  def """ + initFuncName + """Init() : Unit = {""" +
+  def """ + initFuncName + """Init() (): Unit = {""" +

Review comment:
       This looks off too, I think this ends up generated an extra set of parens.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org