You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by amitdev <gi...@git.apache.org> on 2016/02/12 08:45:47 UTC
[GitHub] spark pull request: Added pygments.rb dependancy
GitHub user amitdev opened a pull request:
https://github.com/apache/spark/pull/11180
Added pygments.rb dependancy
Looks like pygments.rb gem is also required for jekyll build to work. At least on Ubuntu/RHEL I could not do build without this dependency. So added this to steps.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amitdev/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11180
----
commit f705e9bbe7f1e6a6393062c07e239b23ebf53ac8
Author: Amit Dev <am...@gmail.com>
Date: 2016-02-12T07:43:13Z
Added pygments.rb dependancy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183873081
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183875114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51265/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183876868
Merged to master/1.6. @amitdev if you'll tell me your JIRA handle I'll assign you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Documentation] Added pygments.rb dependancy
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183351400
@amitdev can you connect this to https://issues.apache.org/jira/browse/SPARK-13300 in the title? it might be the same thing?
It looks like lots of the examples aren't rendered in the current live site?
http://spark.apache.org/examples.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by amitdev <gi...@git.apache.org>.
Github user amitdev commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-184066189
@srowen, my JIRA handle is amitdev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183616693
@amitdev just build the documentation. Do you see the code snippets correctly in the page http://spark.apache.org/examples.html in your local build? instead of the pygments error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183875113
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183874411
**[Test build #51265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51265/consoleFull)** for PR 11180 at commit [`044b0d8`](https://github.com/apache/spark/commit/044b0d83f12b48fcf535141fb129dcf46d02b026).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Documentation] Added pygments.rb dependancy
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183219234
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183645806
Aha, one significant update. Yes, the change here is a good one, as I also had to install this gem to build the docs. In fact we can simplify:
```
sudo gem install jekyll jekyll-redirect-from pygments.rb
sudo pip install Pygments sphinx
```
Maybe it's also worth noting that you'd have to have Ruby and pip installed (and I assume gcc, Python already), which may not be obvious. For Ubuntu that's:
```
sudo apt-get install ruby ruby-dev pip-python
```
I don't feel strongly about adding that, but hey.
Actually I was incorrect in connecting this to SPARK-13300 though, as the page in question is not generated from source in `docs/`. It's part of the ASF site. This also uses pygments though. So maybe it turns out to be the same problem.
While we can just add this change (with a possible simplification) I'm also looking at whether I can fix up the ASF site with something similar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by amitdev <gi...@git.apache.org>.
Github user amitdev commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183843493
Thanks @srowen. I've mentioned dependencies on Ruby, Python and cleaned up the doc a little.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by amitdev <gi...@git.apache.org>.
Github user amitdev commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-184139878
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=amitdev
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Documentation] Added pygments.rb dependancy
Posted by amitdev <gi...@git.apache.org>.
Github user amitdev commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183616247
@srowen, it looks related - is there a waay to verify it? I couldn't locate where the spark example code is. Things on the main documentation site is working fine. Anyway I'll change the title so that someone with access can take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Documentation] Added pygments.rb dependancy
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183255397
@amitdev The PR also contains ml-guide changes. Could you remove that commit from your branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-184122133
@amitdev I don't see anyone by your name or "Amit Dev.." in ASF JIRA. Are you sure? maybe link me to your profile page
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Documentation] Added pygments.rb dependancy
Posted by amitdev <gi...@git.apache.org>.
Github user amitdev commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183259512
@mengxr, Sorry I committed that by mistake - removed now. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183875086
**[Test build #51265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51265/consoleFull)** for PR 11180 at commit [`044b0d8`](https://github.com/apache/spark/commit/044b0d83f12b48fcf535141fb129dcf46d02b026).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11180#issuecomment-183648166
I fixed the ASF site at http://spark.apache.org/examples.html and indeed it required the same gem to be installed to work. So this is related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org