You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/12/21 03:44:44 UTC

[GitHub] carbondata pull request #1699: [CARBONDATA-1924][PARTITION] Restrict streami...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1699#discussion_r158191780
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala ---
    @@ -233,6 +233,9 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
           case _ =>
             // ignore this case
         }
    +    if (partitionFields.nonEmpty && options.isStreaming) {
    --- End diff --
    
    maybe it is better to do it in `validateStreamingProperty`, it is invoked in line 213


---