You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2018/02/07 20:26:16 UTC
[1/2] storm git commit: STORM-2934 fix startup ClassNotFoundException
when missing RocksDB jar
Repository: storm
Updated Branches:
refs/heads/master 12cc49fcb -> c02f4a0db
STORM-2934 fix startup ClassNotFoundException when missing RocksDB jar
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/30d81a5d
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/30d81a5d
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/30d81a5d
Branch: refs/heads/master
Commit: 30d81a5d508a521ce6f850163d57d13228689f7c
Parents: 12cc49f
Author: Aaron Gresch <ag...@yahoo-inc.com>
Authored: Mon Feb 5 11:38:33 2018 -0600
Committer: Aaron Gresch <ag...@yahoo-inc.com>
Committed: Wed Feb 7 08:15:23 2018 -0600
----------------------------------------------------------------------
storm-server/src/main/java/org/apache/storm/DaemonConfig.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/30d81a5d/storm-server/src/main/java/org/apache/storm/DaemonConfig.java
----------------------------------------------------------------------
diff --git a/storm-server/src/main/java/org/apache/storm/DaemonConfig.java b/storm-server/src/main/java/org/apache/storm/DaemonConfig.java
index a6881b7..3230f70 100644
--- a/storm-server/src/main/java/org/apache/storm/DaemonConfig.java
+++ b/storm-server/src/main/java/org/apache/storm/DaemonConfig.java
@@ -1035,7 +1035,9 @@ public class DaemonConfig implements Validated {
* Class implementing MetricStore.
*/
@NotNull
- @isImplementationOfClass(implementsClass = MetricStore.class)
+ @isString
+ // Validating class implementation could fail on non-Nimbus Daemons. Nimbus will catch the class not found on startup
+ // and log an error message, so just validating this as a String for now.
public static final String STORM_METRIC_STORE_CLASS = "storm.metricstore.class";
/**
[2/2] storm git commit: Merge branch 'agresch_classnotfound' of
https://github.com/agresch/storm into STORM-2934
Posted by bo...@apache.org.
Merge branch 'agresch_classnotfound' of https://github.com/agresch/storm into STORM-2934
STORM-2934: fix startup ClassNotFoundException when missing RocksDB jar
This closes #2546
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/c02f4a0d
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/c02f4a0d
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/c02f4a0d
Branch: refs/heads/master
Commit: c02f4a0db35aaec47b0f049e3b5195857a915f1e
Parents: 12cc49f 30d81a5
Author: Robert Evans <ev...@yahoo-inc.com>
Authored: Wed Feb 7 14:08:21 2018 -0600
Committer: Robert Evans <ev...@yahoo-inc.com>
Committed: Wed Feb 7 14:08:21 2018 -0600
----------------------------------------------------------------------
storm-server/src/main/java/org/apache/storm/DaemonConfig.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------