You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/02/10 17:23:53 UTC
[GitHub] [incubator-doris] stdpain opened a new issue #5383: [optimization] Optimize ExprContext::get_value with inline
stdpain opened a new issue #5383:
URL: https://github.com/apache/incubator-doris/issues/5383
This function is simple enough, but it is not an inline function. When the root expression is a simple expression, calling get_value can see a certain overhead (very small) in the cpu profile, but in fact it is completely unnecessary here, and the compiler can take further optimization.
**Describe the solution you'd like**
make this function to inline
**Additional context**
Here is my test:
```
select LO_ORDERKEY from LINE_ORDER_V2 order by LO_ORDERKEY desc limit 10;
```
| inline | no-inline | limt x |
| ------ | --------- | ------ |
| 1 | 1.05 | 10 |
| 2.88 | 2.94 | 1000 |
From these test results, the performance improvement is very small, but there is indeed a small part of the improvement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #5383: [optimization] Optimize ExprContext::get_value with inline
Posted by GitBox <gi...@apache.org>.
morningman closed issue #5383:
URL: https://github.com/apache/incubator-doris/issues/5383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org