[GitHub] [ozone] swamirishi commented on a diff in pull request #3683: HDDS-7126. Clean deletedBlock records of deleted containers

["swamirishi (via GitHub)" <gi...@apache.org>]

swamirishi commented on code in PR #3683:
URL: https://github.com/apache/ozone/pull/3683#discussion_r1089305343


##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/block/TestDeletedBlockLog.java:
##########
@@ -527,6 +533,22 @@ public void testDeletedBlockTransactions()
     Assertions.assertEquals(2, blocks.size());
   }
 
+  @Test
+  public void testDeletedBlockTransactionsOfDeletedContainer()
+      throws IOException, TimeoutException {
+    int txNum = 10;
+    List<DeletedBlocksTransaction> blocks;
+
+    // Creates {TXNum} TX in the log.
+    Map<Long, List<Long>> deletedBlocks = generateData(txNum,

Review Comment:
   Sorry for holding this PR for pretty long. The comment here could be anywhere I suggested in the commitTransaction function as there is already a comment around the same but not covering under replication part. The comment in this class should also be fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org