You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Roger Hoover <ro...@gmail.com> on 2015/07/25 18:48:00 UTC

Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36815/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

SAMZA-741 Add support for versioning to Elasticsearch System Producer


Diffs
-----

  samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java afe0eee 

Diff: https://reviews.apache.org/r/36815/diff/


Testing
-------

Refactored DefaultIndexRequestFactory to make it easier to subclass and customize to handle version and version_type parameters.


Thanks,

Roger Hoover


Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

Posted by Roger Hoover <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36815/
-----------------------------------------------------------

(Updated July 28, 2015, 6:13 a.m.)


Review request for samza.


Changes
-------

Ignoring version conflicts


Repository: samza


Description
-------

SAMZA-741 Add support for versioning to Elasticsearch System Producer


Diffs (updated)
-----

  samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java f61bd36 
  samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java e3b635b 
  samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java afe0eee 
  samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetricsTest.java 980964f 
  samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerTest.java 684d7f6 

Diff: https://reviews.apache.org/r/36815/diff/


Testing
-------

Refactored DefaultIndexRequestFactory to make it easier to subclass and customize to handle version and version_type parameters.


Thanks,

Roger Hoover


Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

Posted by Roger Hoover <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36815/
-----------------------------------------------------------

(Updated July 25, 2015, 4:48 p.m.)


Review request for samza.


Repository: samza


Description
-------

SAMZA-741 Add support for versioning to Elasticsearch System Producer


Diffs (updated)
-----

  samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java afe0eee 

Diff: https://reviews.apache.org/r/36815/diff/


Testing
-------

Refactored DefaultIndexRequestFactory to make it easier to subclass and customize to handle version and version_type parameters.


Thanks,

Roger Hoover