You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Konstantin Boudnik <co...@apache.org> on 2015/04/01 03:54:51 UTC
Re: automatic patch validation on TC
Thanks - that's great: not I'd be able to finish up the commenting part of the
patch validation!
Cos
On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> Hello Konstantin.
> I've installed lira-cli on all agents (7) - path of cli is
> /opt/jira-cli-3.9.0
> On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
> wrote:
>
> I believe this is a different jira cli tools. The one I am using is 100%
> java
> - no Python nonsense (god forbids). I am talking about this particular
> version
>
> A
> https://bobswift.atlassian.net/wiki/download/attachments/16285777/jira-cli-3.9.0-distribution.zip?version=1&modificationDate=1401618313091&api=v2
>
> It seems to be the last official atlassian version of the tools that
> still
> works with out-of-stock JIRA server. Can we get it installed?
>
> Thanks,
> A Cos
> On Wed, Mar 25, 2015 at 11:15AM, Sergey Bachinskiy wrote:
> >A A Hello Konstantin!
> >A A As I've seen jira cli tools need python 2.7 to run?
> >A A Should we have jira-cli on all build nodes?
> >A A On Wed, Mar 25, 2015 at 1:07 AM, Dmitriy Setrakyan
> <ds...@apache.org>
> >A A wrote:
> >
> >A A A Sergey B (CC'ed) is admitting these boxes. Sergey, can you
> please
> >A A A respond here?
> >A A A D.
> >A A A On Tue, Mar 24, 2015 at 3:03 PM, Konstantin Boudnik
> <co...@apache.org>
> >A A A wrote:
> >
> >A A A A Guys,
> >
> >A A A A is there any chance we can add jira-cli tools to the TC
> agent nodes?
> >A A A A It seems
> >A A A A that OAuth setup doesn't move anywhere yet and I want to
> finish this
> >A A A A patch
> >A A A A validation work ASAP. jira-cli tools allow an external
> process to
> >A A A A comm. with
> >A A A A JIRA without any fancy SOAP/REST stuff.
> >
> >A A A A Can anyone who's admin'ing these boxes ping me off-line so
> we can
> >A A A A complete it?
> >
> >A A A A Thanks,
> >A A A A AA Cos
> >
> >A A A A On Sat, Feb 28, 2015 at 05:22AM, Konstantin Boudnik wrote:
> >A A A A > Y'all
> >A A A A >
> >A A A A > I have put together an initial version of the TC job that
> pulls in
> >A A A A JIRAs in PA
> >A A A A > state and find the latest attachment by date. It also
> creates and
> >A A A A artifact
> >A A A A > where all earlier processed attachments are listed to
> avoid
> >A A A A duplicated
> >A A A A > test runs. The job is here
> >A A A A >A
> >A A A A A
> http://204.14.53.152/viewType.html?buildTypeId=Ignite_PatchValidation_Main
> >A A A A >
> >A A A A > Now, I need some advice from TC experts, as I have no
> experience
> >A A A A with it,
> >A A A A > really. The issue I have as this (perhaps, coming from my
> ignorance
> >A A A A about TC):
> >A A A A >AA 1. it seems that TC builds can be triggered by
> creating a special
> >A A A A remote
> >A A A A >AA AA A branch in git. That would require a job to do
> pushed to the
> >A A A A git, which I
> >A A A A >AA AA A am no fan of...
> >A A A A >AA 2. there might be a way to use some sort of
> meta-runner that can
> >A A A A fetch the
> >A A A A >AA AA A repo, create a branch using provided patch, and
> then trigger
> >A A A A the test-run.
> >A A A A >AA AA A I have no idea how to do it.
> >A A A A >AA 3. Some other unknown-unknown functionality, that I am
> evidently
> >A A A A missing?
> >A A A A >
> >A A A A > I would really like someone on this list with TC
> expertise to tell
> >A A A A me what's
> >A A A A > the preferred way of performing such workflow? E.g. in
> Jenkins I can
> >A A A A trigger a
> >A A A A > remote job with a parameter (JIRA #), which then will
> download the
> >A A A A latest
> >A A A A > attachment from it (7 lines of Groovy), apply it to the
> fresh repo
> >A A A A clone and
> >A A A A > run the tests. How we can do something like that in TC?
> Looking for
> >A A A A the
> >A A A A > guidance and help from this list.
> >A A A A >
> >A A A A > --
> >A A A A > Thanks in advance. Regards,
> >A A A A >AA A Cos
> >A A A A >
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
On Thu, May 21, 2015 at 10:32AM, Dmitriy Setrakyan wrote:
> On Thu, May 21, 2015 at 10:27 AM, Konstantin Boudnik <co...@apache.org> wrote:
>
> > Can anyone with project admin rights check the permissions chema and see
> > if there's a tweak for 'Patch available' for different roles in the
> > project? i think there is, but i'm on vacation, really.
> >
>
> Cos, vacation is hardly an excuse :) Get back to work!
I don't think so.
Re: Fwd: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@apache.org>.
On Thu, May 21, 2015 at 10:27 AM, Konstantin Boudnik <co...@apache.org> wrote:
> Can anyone with project admin rights check the permissions chema and see
> if there's a tweak for 'Patch available' for different roles in the
> project? i think there is, but i'm on vacation, really.
>
Cos, vacation is hardly an excuse :) Get back to work!
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Can anyone with project admin rights check the permissions chema and see
if there's a tweak for 'Patch available' for different roles in the
project? i think there is, but i'm on vacation, really.
Thanks,
Cos
On Thu, May 21, 2015 at 04:30PM, Artiom Shutak wrote:
> I think I found good way to resolve any security issues here. We will use
> attachments only from approved users list (contributors).
>
> Objections?
>
> -- Artem --
>
> On Thu, May 21, 2015 at 1:13 PM, Branko Čibej <br...@apache.org> wrote:
>
> > On 21.05.2015 12:00, Dmitriy Setrakyan wrote:
> > > On Thu, May 21, 2015 at 2:48 AM, Branko Čibej <br...@apache.org> wrote:
> > >
> > >> On 21.05.2015 11:35, Dmitriy Setrakyan wrote:
> > >>> Are we saying that non-contributors can attach patches?
> > >>
> > >> Slow down. Anyone who sends a patch is, by definition, a contributor.
> > >> Whether or not you decide to use the patch is a different matter. You
> > >> don't want to invent any extremely paranoid access control; that's
> > >> contrary to the whole point of open source.
> > >>
> > > Brane, as far as I know, in order for someone to start working on a
> > ticket
> > > we need to add him/her to the list of "contributors" in Jira. Otherwise
> > the
> > > ticket cannot even be assigned to that person. I thought that only the
> > > people on the Jira "contributor" list can attach patches. Is this not so?
> > > If not, can we configure Jira to work in that way?
> >
> > I don't know how ASF Jira is set up, but surely people can create new
> > tickets and attach patches to them?
> >
> > -- Brane
> >
> >
Re: Fwd: automatic patch validation on TC
Posted by Artiom Shutak <as...@gridgain.com>.
I think I found good way to resolve any security issues here. We will use
attachments only from approved users list (contributors).
Objections?
-- Artem --
On Thu, May 21, 2015 at 1:13 PM, Branko Čibej <br...@apache.org> wrote:
> On 21.05.2015 12:00, Dmitriy Setrakyan wrote:
> > On Thu, May 21, 2015 at 2:48 AM, Branko Čibej <br...@apache.org> wrote:
> >
> >> On 21.05.2015 11:35, Dmitriy Setrakyan wrote:
> >>> Are we saying that non-contributors can attach patches?
> >>
> >> Slow down. Anyone who sends a patch is, by definition, a contributor.
> >> Whether or not you decide to use the patch is a different matter. You
> >> don't want to invent any extremely paranoid access control; that's
> >> contrary to the whole point of open source.
> >>
> > Brane, as far as I know, in order for someone to start working on a
> ticket
> > we need to add him/her to the list of "contributors" in Jira. Otherwise
> the
> > ticket cannot even be assigned to that person. I thought that only the
> > people on the Jira "contributor" list can attach patches. Is this not so?
> > If not, can we configure Jira to work in that way?
>
> I don't know how ASF Jira is set up, but surely people can create new
> tickets and attach patches to them?
>
> -- Brane
>
>
Re: Fwd: automatic patch validation on TC
Posted by Branko Čibej <br...@apache.org>.
On 21.05.2015 12:00, Dmitriy Setrakyan wrote:
> On Thu, May 21, 2015 at 2:48 AM, Branko Čibej <br...@apache.org> wrote:
>
>> On 21.05.2015 11:35, Dmitriy Setrakyan wrote:
>>> Are we saying that non-contributors can attach patches?
>>
>> Slow down. Anyone who sends a patch is, by definition, a contributor.
>> Whether or not you decide to use the patch is a different matter. You
>> don't want to invent any extremely paranoid access control; that's
>> contrary to the whole point of open source.
>>
> Brane, as far as I know, in order for someone to start working on a ticket
> we need to add him/her to the list of "contributors" in Jira. Otherwise the
> ticket cannot even be assigned to that person. I thought that only the
> people on the Jira "contributor" list can attach patches. Is this not so?
> If not, can we configure Jira to work in that way?
I don't know how ASF Jira is set up, but surely people can create new
tickets and attach patches to them?
-- Brane
Re: Fwd: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@apache.org>.
On Thu, May 21, 2015 at 2:48 AM, Branko Čibej <br...@apache.org> wrote:
> On 21.05.2015 11:35, Dmitriy Setrakyan wrote:
> > Are we saying that non-contributors can attach patches?
>
>
> Slow down. Anyone who sends a patch is, by definition, a contributor.
> Whether or not you decide to use the patch is a different matter. You
> don't want to invent any extremely paranoid access control; that's
> contrary to the whole point of open source.
>
Brane, as far as I know, in order for someone to start working on a ticket
we need to add him/her to the list of "contributors" in Jira. Otherwise the
ticket cannot even be assigned to that person. I thought that only the
people on the Jira "contributor" list can attach patches. Is this not so?
If not, can we configure Jira to work in that way?
>
> If you don't want to automatically test patches in your test
> environment, then by all means don't do that. You can invent a 'patch
> reviewed' state in Jira that needs explicit permission to be set, and
> only send the patch to CI once a committer has reviewed the patch.
>
> -- Brane
>
>
Re: Fwd: automatic patch validation on TC
Posted by Branko Čibej <br...@apache.org>.
On 21.05.2015 11:35, Dmitriy Setrakyan wrote:
> Are we saying that non-contributors can attach patches?
Slow down. Anyone who sends a patch is, by definition, a contributor.
Whether or not you decide to use the patch is a different matter. You
don't want to invent any extremely paranoid access control; that's
contrary to the whole point of open source.
If you don't want to automatically test patches in your test
environment, then by all means don't do that. You can invent a 'patch
reviewed' state in Jira that needs explicit permission to be set, and
only send the patch to CI once a committer has reviewed the patch.
-- Brane
Re: Fwd: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@apache.org>.
Are we saying that non-contributors can attach patches?
On Thu, May 21, 2015 at 2:24 AM, Artiom Shutak <as...@gridgain.com> wrote:
> Hi, Cos,
>
> I cannot agree with you.
>
> I rechecked it again. What I did:
> 1. Sign up with new user to Apache Jira (
> https://issues.apache.org/jira/secure/Signup!default.jspa). // I didn't
> add
> any privileges.
> 2. Open https://issues.apache.org/jira/browse/IGNITE-456
> 3. Add txt and patch - files to the issue. You can see at history of the
> issue (see attachments by tc_commenter).
>
> Please, recheck it for ignite-ci and let me know if you cannot attach files
> by this user.
>
> -- Artem --
>
> On Thu, May 21, 2015 at 12:57 AM, Konstantin Boudnik <co...@apache.org>
> wrote:
>
> > There's user ignite-ci, that I created a while ago, but it isn't
> mandatory
> > to
> > use it of course ;)
> >
> > On Thu, May 21, 2015 at 12:23AM, Artiom Shutak wrote:
> > > I've created new Jira user without granting him some additional
> > privileges.
> > >
> > > The user cannot move jira status, but he can add any attachment under
> > this
> > > user.
> > >
> > > I see at least one bad scenario: hacker can just monitor for new "Patch
> > > available" tickets and attach a bad patch. As a result, the test builds
> > > will run with bad patch.
> >
> > A hacker can not attach anything unless he has contributor's permissions.
> >
> > > I think, for example, we should approve to attach files with "patch"
> > > extensions for contributors only (Somebody knows can we do that?), or
> > just
> > > manually run all test builds for attached to TC file or link on file.
> >
> > I am not sure what does it solve? Isn't that enough to impose limits on
> who
> > can attach/change JIRA state?
> >
> > Cos
> >
> > > Thoughts?
> > >
> > > -- Artem --
> > >
> > > On Wed, May 20, 2015 at 4:26 PM, Yakov Zhdanov <yz...@gridgain.com>
> > > wrote:
> > >
> > > > I still insist that this should be implemented with great care.
> > > >
> > > > Cos, can you please provide information on which projects used same
> > > > approach?
> > > >
> > > > > Don't we trust our contributors?
> > > >
> > > > Well, you never know how they store the password and how strong it
> is.
> > > >
> > > > > if TC agents aren't running as privileged user - and they shouldn't
> > be -
> > > > malicious code won't do any harm to the system.
> > > >
> > > > Ignite tests should be able to do a lot of operations - establish
> > network
> > > > connections, accept incoming connections, start processes and access
> > file
> > > > system.
> > > >
> > > > In order to address possible issues we need to:
> > > > 1. limit the tests scenarios launched on patch attach.
> > > > 2. backup TC workers state once a day and store several days history
> to
> > > > quickly restore the state.
> > > >
> > > > --
> > > > Yakov Zhdanov, Director R&D
> > > > *GridGain Systems*
> > > > www.gridgain.com
> > > >
> > > > 2015-05-19 20:53 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > Here's two reasons why current approach is secure enough (and in
> > fact has
> > > > > been used for some time on Apache build infrastructure):
> > > > >
> > > > > - only project contributors can manipulate JIRA: attaching,
> changing
> > > > > state, etc. Don't we trust our contributors?
> > > > > - if TC agents aren't running as privileged user - and they
> > shouldn't be
> > > > -
> > > > > malicious code won't do any harm to the system.
> > > > >
> > > > > Thoughts?
> > > > > Cos
> > > > >
> > > > > On Tue, May 19, 2015 at 04:47PM, Yakov Zhdanov wrote:
> > > > > > Guys,
> > > > > >
> > > > > > It seems we need to stop any activity in this direction.
> > > > > >
> > > > > > I have just realized that automatic patch validation (at least in
> > its
> > > > > form
> > > > > > we agreed on) opens a huge security hole - anyone who attaches a
> > patch
> > > > to
> > > > > > JIRA can execute literally any code (!) on our public TC -
> > > > > > java/bash/binary/built-in OS/etc. Should I continue on what this
> > can
> > > > lead
> > > > > > to? I think no.
> > > > > >
> > > > > > So, the only acceptable way is to assign committer to review a
> > patch
> > > > > > manually and then submit it to TC.
> > > > > >
> > > > > > Process in my view should be the following:
> > > > > >
> > > > > > 1. Contributor finishes with the task and attaches a patch to
> JIRA
> > > > issue.
> > > > > > 2. Committer picks up the issue and reviews the changes.
> > > > > > 3. If changes are OK, committer submits them to TC in a separate
> > > > branch.
> > > > > > 4. After TC passes committer merges the changes to the target
> > sprint
> > > > > branch.
> > > > > > 5. JIRA issue gets closed.
> > > > > >
> > > > > > Thoughts?
> > > > > >
> > > > > > --Yakov
> > > > > >
> > > > > > 2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > >
> > > > > > > Sergey and I had a good Skype call and everything seems to be
> > > > > resolved. The
> > > > > > > installed jira-cli tools work just fine http://bit.ly/1c2qmeH
> > > > > > >
> > > > > > > Attachments and comments do not need to be fetched using
> > jira-cli.
> > > > The
> > > > > > > proposed workflow for the automatic patching is explained at
> the
> > > > > bottom of
> > > > > > > dev-tools/src/main/groovy/jiraslurp.groovy
> > > > > > > please let me know if there are any questions about it.
> > > > > > >
> > > > > > > Sergey will see to make sure that we have parameterized builds,
> > which
> > > > > will
> > > > > > > be
> > > > > > > triggered from the groovy script above. In fact, that is the
> last
> > > > thing
> > > > > > > that
> > > > > > > is blocking the completion of this task. Looks like our
> off-line
> > > > > > > conversation
> > > > > > > with him helped to get the ball rolling!
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > > > > > Cos,
> > > > > > > >
> > > > > > > > Does cli works on your local machine?
> > > > > > > >
> > > > > > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > > > > > Administration
> > > > > > > > -> General Configuration and ensure Accept remote API calls
> in
> > ON"?
> > > > > > > >
> > > > > > > > Sergey tried it locally and it just hangs.
> > > > > > > >
> > > > > > > >
> > > > > > > > --Yakov
> > > > > > > >
> > > > > > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <
> cos@apache.org
> > >:
> > > > > > > >
> > > > > > > > > Hi Yakov.
> > > > > > > > >
> > > > > > > > > With jira-cli 3.9 one doesn't need to install anything on
> the
> > > > > server
> > > > > > > side.
> > > > > > > > > The
> > > > > > > > > older version of the tools work with JIRA backend. The
> newer
> > > > > version
> > > > > > > (not
> > > > > > > > > produced by Atlassian anymore) requires some additional
> > stuff to
> > > > be
> > > > > > > set.
> > > > > > > > >
> > > > > > > > > I will take a look at the agents' configuration later in
> the
> > day
> > > > > and
> > > > > > > will
> > > > > > > > > get
> > > > > > > > > back to you here.
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Cos
> > > > > > > > >
> > > > > > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > > > > > Cos,
> > > > > > > > > >
> > > > > > > > > > We still have problem while applying patch on TC.
> > Attachments
> > > > and
> > > > > > > > > comments
> > > > > > > > > > cannot be fetched from Jira when using jira-cli on
> current
> > > > > agents.
> > > > > > > > > >
> > > > > > > > > > Can you please make sure that server side of jira-cli is
> > > > properly
> > > > > > > > > > installed? Do you know any other way to fetch that?
> > > > > > > > > >
> > > > > > > > > > --Yakov
> > > > > > > > > >
> > > > > > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <
> > cos@apache.org>:
> > > > > > > > > >
> > > > > > > > > > > oops
> > > > > > > > > > >
> > > > > > > > > > > s/not/now/g
> > > > > > > > > > >
> > > > > > > > > > > Cos
> > > > > > > > > > >
> > > > > > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan
> wrote:
> > > > > > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin
> Boudnik
> > <
> > > > > > > > > cos@apache.org>
> > > > > > > > > > > > wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > Thanks - that's great: not I'd be able to finish
> > up
> > > > the
> > > > > > > > > commenting
> > > > > > > > > > > part of the patch validation!
> > > > > > > > > > > >
> > > > > > > > > > > > Cos, I think some meaning was lost due to typos.
> Do
> > you
> > > > > mean
> > > > > > > that
> > > > > > > > > you
> > > > > > > > > > > will
> > > > > > > > > > > > be able to finish it or will not?
> > > > > > > > > > > >
> > > > > > > > > > > > Cos
> > > > > > > > > > > >
> > > > > > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey
> Bachinskiy
> > > > > wrote:
> > > > > > > > > > > > >A A Hello Konstantin.
> > > > > > > > > > > > >A A I've installed lira-cli on all agents
> (7) -
> > > > path
> > > > > of
> > > > > > > cli
> > > > > > > > > is
> > > > > > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM,
> > Konstantin
> > > > > Boudnik
> > > > > > > > > > > > <co...@apache.org>
> > > > > > > > > > > > >A A wrote:
> > > > > > > > >
> > > > > > >
> > > > > > >
> > > > >
> > > >
> >
>
Re: Fwd: automatic patch validation on TC
Posted by Artiom Shutak <as...@gridgain.com>.
Hi, Cos,
I cannot agree with you.
I rechecked it again. What I did:
1. Sign up with new user to Apache Jira (
https://issues.apache.org/jira/secure/Signup!default.jspa). // I didn't add
any privileges.
2. Open https://issues.apache.org/jira/browse/IGNITE-456
3. Add txt and patch - files to the issue. You can see at history of the
issue (see attachments by tc_commenter).
Please, recheck it for ignite-ci and let me know if you cannot attach files
by this user.
-- Artem --
On Thu, May 21, 2015 at 12:57 AM, Konstantin Boudnik <co...@apache.org> wrote:
> There's user ignite-ci, that I created a while ago, but it isn't mandatory
> to
> use it of course ;)
>
> On Thu, May 21, 2015 at 12:23AM, Artiom Shutak wrote:
> > I've created new Jira user without granting him some additional
> privileges.
> >
> > The user cannot move jira status, but he can add any attachment under
> this
> > user.
> >
> > I see at least one bad scenario: hacker can just monitor for new "Patch
> > available" tickets and attach a bad patch. As a result, the test builds
> > will run with bad patch.
>
> A hacker can not attach anything unless he has contributor's permissions.
>
> > I think, for example, we should approve to attach files with "patch"
> > extensions for contributors only (Somebody knows can we do that?), or
> just
> > manually run all test builds for attached to TC file or link on file.
>
> I am not sure what does it solve? Isn't that enough to impose limits on who
> can attach/change JIRA state?
>
> Cos
>
> > Thoughts?
> >
> > -- Artem --
> >
> > On Wed, May 20, 2015 at 4:26 PM, Yakov Zhdanov <yz...@gridgain.com>
> > wrote:
> >
> > > I still insist that this should be implemented with great care.
> > >
> > > Cos, can you please provide information on which projects used same
> > > approach?
> > >
> > > > Don't we trust our contributors?
> > >
> > > Well, you never know how they store the password and how strong it is.
> > >
> > > > if TC agents aren't running as privileged user - and they shouldn't
> be -
> > > malicious code won't do any harm to the system.
> > >
> > > Ignite tests should be able to do a lot of operations - establish
> network
> > > connections, accept incoming connections, start processes and access
> file
> > > system.
> > >
> > > In order to address possible issues we need to:
> > > 1. limit the tests scenarios launched on patch attach.
> > > 2. backup TC workers state once a day and store several days history to
> > > quickly restore the state.
> > >
> > > --
> > > Yakov Zhdanov, Director R&D
> > > *GridGain Systems*
> > > www.gridgain.com
> > >
> > > 2015-05-19 20:53 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > >
> > > > Here's two reasons why current approach is secure enough (and in
> fact has
> > > > been used for some time on Apache build infrastructure):
> > > >
> > > > - only project contributors can manipulate JIRA: attaching, changing
> > > > state, etc. Don't we trust our contributors?
> > > > - if TC agents aren't running as privileged user - and they
> shouldn't be
> > > -
> > > > malicious code won't do any harm to the system.
> > > >
> > > > Thoughts?
> > > > Cos
> > > >
> > > > On Tue, May 19, 2015 at 04:47PM, Yakov Zhdanov wrote:
> > > > > Guys,
> > > > >
> > > > > It seems we need to stop any activity in this direction.
> > > > >
> > > > > I have just realized that automatic patch validation (at least in
> its
> > > > form
> > > > > we agreed on) opens a huge security hole - anyone who attaches a
> patch
> > > to
> > > > > JIRA can execute literally any code (!) on our public TC -
> > > > > java/bash/binary/built-in OS/etc. Should I continue on what this
> can
> > > lead
> > > > > to? I think no.
> > > > >
> > > > > So, the only acceptable way is to assign committer to review a
> patch
> > > > > manually and then submit it to TC.
> > > > >
> > > > > Process in my view should be the following:
> > > > >
> > > > > 1. Contributor finishes with the task and attaches a patch to JIRA
> > > issue.
> > > > > 2. Committer picks up the issue and reviews the changes.
> > > > > 3. If changes are OK, committer submits them to TC in a separate
> > > branch.
> > > > > 4. After TC passes committer merges the changes to the target
> sprint
> > > > branch.
> > > > > 5. JIRA issue gets closed.
> > > > >
> > > > > Thoughts?
> > > > >
> > > > > --Yakov
> > > > >
> > > > > 2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > >
> > > > > > Sergey and I had a good Skype call and everything seems to be
> > > > resolved. The
> > > > > > installed jira-cli tools work just fine http://bit.ly/1c2qmeH
> > > > > >
> > > > > > Attachments and comments do not need to be fetched using
> jira-cli.
> > > The
> > > > > > proposed workflow for the automatic patching is explained at the
> > > > bottom of
> > > > > > dev-tools/src/main/groovy/jiraslurp.groovy
> > > > > > please let me know if there are any questions about it.
> > > > > >
> > > > > > Sergey will see to make sure that we have parameterized builds,
> which
> > > > will
> > > > > > be
> > > > > > triggered from the groovy script above. In fact, that is the last
> > > thing
> > > > > > that
> > > > > > is blocking the completion of this task. Looks like our off-line
> > > > > > conversation
> > > > > > with him helped to get the ball rolling!
> > > > > >
> > > > > > Cos
> > > > > >
> > > > > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > > > > Cos,
> > > > > > >
> > > > > > > Does cli works on your local machine?
> > > > > > >
> > > > > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > > > > Administration
> > > > > > > -> General Configuration and ensure Accept remote API calls in
> ON"?
> > > > > > >
> > > > > > > Sergey tried it locally and it just hangs.
> > > > > > >
> > > > > > >
> > > > > > > --Yakov
> > > > > > >
> > > > > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <cos@apache.org
> >:
> > > > > > >
> > > > > > > > Hi Yakov.
> > > > > > > >
> > > > > > > > With jira-cli 3.9 one doesn't need to install anything on the
> > > > server
> > > > > > side.
> > > > > > > > The
> > > > > > > > older version of the tools work with JIRA backend. The newer
> > > > version
> > > > > > (not
> > > > > > > > produced by Atlassian anymore) requires some additional
> stuff to
> > > be
> > > > > > set.
> > > > > > > >
> > > > > > > > I will take a look at the agents' configuration later in the
> day
> > > > and
> > > > > > will
> > > > > > > > get
> > > > > > > > back to you here.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > > > > Cos,
> > > > > > > > >
> > > > > > > > > We still have problem while applying patch on TC.
> Attachments
> > > and
> > > > > > > > comments
> > > > > > > > > cannot be fetched from Jira when using jira-cli on current
> > > > agents.
> > > > > > > > >
> > > > > > > > > Can you please make sure that server side of jira-cli is
> > > properly
> > > > > > > > > installed? Do you know any other way to fetch that?
> > > > > > > > >
> > > > > > > > > --Yakov
> > > > > > > > >
> > > > > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <
> cos@apache.org>:
> > > > > > > > >
> > > > > > > > > > oops
> > > > > > > > > >
> > > > > > > > > > s/not/now/g
> > > > > > > > > >
> > > > > > > > > > Cos
> > > > > > > > > >
> > > > > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik
> <
> > > > > > > > cos@apache.org>
> > > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > Thanks - that's great: not I'd be able to finish
> up
> > > the
> > > > > > > > commenting
> > > > > > > > > > part of the patch validation!
> > > > > > > > > > >
> > > > > > > > > > > Cos, I think some meaning was lost due to typos. Do
> you
> > > > mean
> > > > > > that
> > > > > > > > you
> > > > > > > > > > will
> > > > > > > > > > > be able to finish it or will not?
> > > > > > > > > > >
> > > > > > > > > > > Cos
> > > > > > > > > > >
> > > > > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> > > > wrote:
> > > > > > > > > > > >A A Hello Konstantin.
> > > > > > > > > > > >A A I've installed lira-cli on all agents (7) -
> > > path
> > > > of
> > > > > > cli
> > > > > > > > is
> > > > > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM,
> Konstantin
> > > > Boudnik
> > > > > > > > > > > <co...@apache.org>
> > > > > > > > > > > >A A wrote:
> > > > > > > >
> > > > > >
> > > > > >
> > > >
> > >
>
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
There's user ignite-ci, that I created a while ago, but it isn't mandatory to
use it of course ;)
On Thu, May 21, 2015 at 12:23AM, Artiom Shutak wrote:
> I've created new Jira user without granting him some additional privileges.
>
> The user cannot move jira status, but he can add any attachment under this
> user.
>
> I see at least one bad scenario: hacker can just monitor for new "Patch
> available" tickets and attach a bad patch. As a result, the test builds
> will run with bad patch.
A hacker can not attach anything unless he has contributor's permissions.
> I think, for example, we should approve to attach files with "patch"
> extensions for contributors only (Somebody knows can we do that?), or just
> manually run all test builds for attached to TC file or link on file.
I am not sure what does it solve? Isn't that enough to impose limits on who
can attach/change JIRA state?
Cos
> Thoughts?
>
> -- Artem --
>
> On Wed, May 20, 2015 at 4:26 PM, Yakov Zhdanov <yz...@gridgain.com>
> wrote:
>
> > I still insist that this should be implemented with great care.
> >
> > Cos, can you please provide information on which projects used same
> > approach?
> >
> > > Don't we trust our contributors?
> >
> > Well, you never know how they store the password and how strong it is.
> >
> > > if TC agents aren't running as privileged user - and they shouldn't be -
> > malicious code won't do any harm to the system.
> >
> > Ignite tests should be able to do a lot of operations - establish network
> > connections, accept incoming connections, start processes and access file
> > system.
> >
> > In order to address possible issues we need to:
> > 1. limit the tests scenarios launched on patch attach.
> > 2. backup TC workers state once a day and store several days history to
> > quickly restore the state.
> >
> > --
> > Yakov Zhdanov, Director R&D
> > *GridGain Systems*
> > www.gridgain.com
> >
> > 2015-05-19 20:53 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> >
> > > Here's two reasons why current approach is secure enough (and in fact has
> > > been used for some time on Apache build infrastructure):
> > >
> > > - only project contributors can manipulate JIRA: attaching, changing
> > > state, etc. Don't we trust our contributors?
> > > - if TC agents aren't running as privileged user - and they shouldn't be
> > -
> > > malicious code won't do any harm to the system.
> > >
> > > Thoughts?
> > > Cos
> > >
> > > On Tue, May 19, 2015 at 04:47PM, Yakov Zhdanov wrote:
> > > > Guys,
> > > >
> > > > It seems we need to stop any activity in this direction.
> > > >
> > > > I have just realized that automatic patch validation (at least in its
> > > form
> > > > we agreed on) opens a huge security hole - anyone who attaches a patch
> > to
> > > > JIRA can execute literally any code (!) on our public TC -
> > > > java/bash/binary/built-in OS/etc. Should I continue on what this can
> > lead
> > > > to? I think no.
> > > >
> > > > So, the only acceptable way is to assign committer to review a patch
> > > > manually and then submit it to TC.
> > > >
> > > > Process in my view should be the following:
> > > >
> > > > 1. Contributor finishes with the task and attaches a patch to JIRA
> > issue.
> > > > 2. Committer picks up the issue and reviews the changes.
> > > > 3. If changes are OK, committer submits them to TC in a separate
> > branch.
> > > > 4. After TC passes committer merges the changes to the target sprint
> > > branch.
> > > > 5. JIRA issue gets closed.
> > > >
> > > > Thoughts?
> > > >
> > > > --Yakov
> > > >
> > > > 2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > Sergey and I had a good Skype call and everything seems to be
> > > resolved. The
> > > > > installed jira-cli tools work just fine http://bit.ly/1c2qmeH
> > > > >
> > > > > Attachments and comments do not need to be fetched using jira-cli.
> > The
> > > > > proposed workflow for the automatic patching is explained at the
> > > bottom of
> > > > > dev-tools/src/main/groovy/jiraslurp.groovy
> > > > > please let me know if there are any questions about it.
> > > > >
> > > > > Sergey will see to make sure that we have parameterized builds, which
> > > will
> > > > > be
> > > > > triggered from the groovy script above. In fact, that is the last
> > thing
> > > > > that
> > > > > is blocking the completion of this task. Looks like our off-line
> > > > > conversation
> > > > > with him helped to get the ball rolling!
> > > > >
> > > > > Cos
> > > > >
> > > > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > > > Cos,
> > > > > >
> > > > > > Does cli works on your local machine?
> > > > > >
> > > > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > > > Administration
> > > > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > > > >
> > > > > > Sergey tried it locally and it just hangs.
> > > > > >
> > > > > >
> > > > > > --Yakov
> > > > > >
> > > > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > >
> > > > > > > Hi Yakov.
> > > > > > >
> > > > > > > With jira-cli 3.9 one doesn't need to install anything on the
> > > server
> > > > > side.
> > > > > > > The
> > > > > > > older version of the tools work with JIRA backend. The newer
> > > version
> > > > > (not
> > > > > > > produced by Atlassian anymore) requires some additional stuff to
> > be
> > > > > set.
> > > > > > >
> > > > > > > I will take a look at the agents' configuration later in the day
> > > and
> > > > > will
> > > > > > > get
> > > > > > > back to you here.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Cos
> > > > > > >
> > > > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > > > Cos,
> > > > > > > >
> > > > > > > > We still have problem while applying patch on TC. Attachments
> > and
> > > > > > > comments
> > > > > > > > cannot be fetched from Jira when using jira-cli on current
> > > agents.
> > > > > > > >
> > > > > > > > Can you please make sure that server side of jira-cli is
> > properly
> > > > > > > > installed? Do you know any other way to fetch that?
> > > > > > > >
> > > > > > > > --Yakov
> > > > > > > >
> > > > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > > > >
> > > > > > > > > oops
> > > > > > > > >
> > > > > > > > > s/not/now/g
> > > > > > > > >
> > > > > > > > > Cos
> > > > > > > > >
> > > > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > > > cos@apache.org>
> > > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > Thanks - that's great: not I'd be able to finish up
> > the
> > > > > > > commenting
> > > > > > > > > part of the patch validation!
> > > > > > > > > >
> > > > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> > > mean
> > > > > that
> > > > > > > you
> > > > > > > > > will
> > > > > > > > > > be able to finish it or will not?
> > > > > > > > > >
> > > > > > > > > > Cos
> > > > > > > > > >
> > > > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> > > wrote:
> > > > > > > > > > >A A Hello Konstantin.
> > > > > > > > > > >A A I've installed lira-cli on all agents (7) -
> > path
> > > of
> > > > > cli
> > > > > > > is
> > > > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> > > Boudnik
> > > > > > > > > > <co...@apache.org>
> > > > > > > > > > >A A wrote:
> > > > > > >
> > > > >
> > > > >
> > >
> >
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
On Wed, Apr 29, 2015 at 04:38PM, Dmitriy Setrakyan wrote:
> On Wed, Apr 29, 2015 at 4:02 PM, Konstantin Boudnik <co...@apache.org> wrote:
>
> > If you look at the branch ignite-620 (as referred in the ticket) you'll see
> > the example at the very end. I am waiting to get this stuff committed, so I
> > can finish all the tiny bits that left, like commenting.
> >
> > Literally, all I need right now, is a review so I can commit the code
> > (which
> > is completely independent from the rest of the system) to unblock my
> > further
> > progress.
> >
>
> Cos, I think you should go ahead and commit this change. I think it was not
> on the critical release path and got delayed. We should definitely do a
> better job at reviewing all patches much sooner, rather than just letting
> them sit there.
Thanks, I will commit this tonight. And +1 on the fixing the review process.
Say, I was lucky that my patch wasn't touching anything in the existing code.
Just imaging for a second how painful the conflict resolution would be for a
core patch after a month of lagging?
Best,
Cos
> >
> > On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
> > > Cos, could you pls give example how you get attachment or comment from
> > jira
> > > issue?
> > >
> > > On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
> > wrote:
> > >
> > > > Yakov
> > > >
> > > > Yes, cli works on my local machine. In fact I am using this version of
> > cli
> > > > to
> > > > work with ASF JIRA for years. This
> > > > https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
> > > > only -
> > > > no manual edits.
> > > >
> > > > Unfortunately, I wasn't able to verify the slaves last night - we'll
> > try
> > > > today. Thanks!
> > > > Cos
> > > >
> > > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > > Cos,
> > > > >
> > > > > Does cli works on your local machine?
> > > > >
> > > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > > Administration
> > > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > > >
> > > > > Sergey tried it locally and it just hangs.
> > > > >
> > > > >
> > > > > --Yakov
> > > > >
> > > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > >
> > > > > > Hi Yakov.
> > > > > >
> > > > > > With jira-cli 3.9 one doesn't need to install anything on the
> > server
> > > > side.
> > > > > > The
> > > > > > older version of the tools work with JIRA backend. The newer
> > version
> > > > (not
> > > > > > produced by Atlassian anymore) requires some additional stuff to be
> > > > set.
> > > > > >
> > > > > > I will take a look at the agents' configuration later in the day
> > and
> > > > will
> > > > > > get
> > > > > > back to you here.
> > > > > >
> > > > > > Thanks,
> > > > > > Cos
> > > > > >
> > > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > > Cos,
> > > > > > >
> > > > > > > We still have problem while applying patch on TC. Attachments and
> > > > > > comments
> > > > > > > cannot be fetched from Jira when using jira-cli on current
> > agents.
> > > > > > >
> > > > > > > Can you please make sure that server side of jira-cli is properly
> > > > > > > installed? Do you know any other way to fetch that?
> > > > > > >
> > > > > > > --Yakov
> > > > > > >
> > > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > > >
> > > > > > > > oops
> > > > > > > >
> > > > > > > > s/not/now/g
> > > > > > > >
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > > cos@apache.org>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > > > commenting
> > > > > > > > part of the patch validation!
> > > > > > > > >
> > > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> > mean
> > > > that
> > > > > > you
> > > > > > > > will
> > > > > > > > > be able to finish it or will not?
> > > > > > > > >
> > > > > > > > > Cos
> > > > > > > > >
> > > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> > wrote:
> > > > > > > > > >A A Hello Konstantin.
> > > > > > > > > >A A I've installed lira-cli on all agents (7) - path
> > of
> > > > cli
> > > > > > is
> > > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> > Boudnik
> > > > > > > > > <co...@apache.org>
> > > > > > > > > >A A wrote:
> > > > > >
> > > >
> > > >
> >
Re: Fwd: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@apache.org>.
On Wed, Apr 29, 2015 at 4:02 PM, Konstantin Boudnik <co...@apache.org> wrote:
> If you look at the branch ignite-620 (as referred in the ticket) you'll see
> the example at the very end. I am waiting to get this stuff committed, so I
> can finish all the tiny bits that left, like commenting.
>
> Literally, all I need right now, is a review so I can commit the code
> (which
> is completely independent from the rest of the system) to unblock my
> further
> progress.
>
Cos, I think you should go ahead and commit this change. I think it was not
on the critical release path and got delayed. We should definitely do a
better job at reviewing all patches much sooner, rather than just letting
them sit there.
> Cos
>
> On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
> > Cos, could you pls give example how you get attachment or comment from
> jira
> > issue?
> >
> > On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
> wrote:
> >
> > > Yakov
> > >
> > > Yes, cli works on my local machine. In fact I am using this version of
> cli
> > > to
> > > work with ASF JIRA for years. This
> > > https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
> > > only -
> > > no manual edits.
> > >
> > > Unfortunately, I wasn't able to verify the slaves last night - we'll
> try
> > > today. Thanks!
> > > Cos
> > >
> > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > Cos,
> > > >
> > > > Does cli works on your local machine?
> > > >
> > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > Administration
> > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > >
> > > > Sergey tried it locally and it just hangs.
> > > >
> > > >
> > > > --Yakov
> > > >
> > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > Hi Yakov.
> > > > >
> > > > > With jira-cli 3.9 one doesn't need to install anything on the
> server
> > > side.
> > > > > The
> > > > > older version of the tools work with JIRA backend. The newer
> version
> > > (not
> > > > > produced by Atlassian anymore) requires some additional stuff to be
> > > set.
> > > > >
> > > > > I will take a look at the agents' configuration later in the day
> and
> > > will
> > > > > get
> > > > > back to you here.
> > > > >
> > > > > Thanks,
> > > > > Cos
> > > > >
> > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > Cos,
> > > > > >
> > > > > > We still have problem while applying patch on TC. Attachments and
> > > > > comments
> > > > > > cannot be fetched from Jira when using jira-cli on current
> agents.
> > > > > >
> > > > > > Can you please make sure that server side of jira-cli is properly
> > > > > > installed? Do you know any other way to fetch that?
> > > > > >
> > > > > > --Yakov
> > > > > >
> > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > >
> > > > > > > oops
> > > > > > >
> > > > > > > s/not/now/g
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > cos@apache.org>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > > commenting
> > > > > > > part of the patch validation!
> > > > > > > >
> > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> mean
> > > that
> > > > > you
> > > > > > > will
> > > > > > > > be able to finish it or will not?
> > > > > > > >
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> wrote:
> > > > > > > > >A A Hello Konstantin.
> > > > > > > > >A A I've installed lira-cli on all agents (7) - path
> of
> > > cli
> > > > > is
> > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> Boudnik
> > > > > > > > <co...@apache.org>
> > > > > > > > >A A wrote:
> > > > >
> > >
> > >
>
Re: Fwd: automatic patch validation on TC
Posted by Artiom Shutak <as...@gridgain.com>.
Ok, I've reopened the root issue
https://issues.apache.org/jira/browse/IGNITE-456 and will continue progress.
If there is any objections, let me know.
-- Artem --
On Tue, May 19, 2015 at 8:53 PM, Konstantin Boudnik <co...@apache.org> wrote:
> Here's two reasons why current approach is secure enough (and in fact has
> been used for some time on Apache build infrastructure):
>
> - only project contributors can manipulate JIRA: attaching, changing
> state, etc. Don't we trust our contributors?
> - if TC agents aren't running as privileged user - and they shouldn't be -
> malicious code won't do any harm to the system.
>
> Thoughts?
> Cos
>
> On Tue, May 19, 2015 at 04:47PM, Yakov Zhdanov wrote:
> > Guys,
> >
> > It seems we need to stop any activity in this direction.
> >
> > I have just realized that automatic patch validation (at least in its
> form
> > we agreed on) opens a huge security hole - anyone who attaches a patch to
> > JIRA can execute literally any code (!) on our public TC -
> > java/bash/binary/built-in OS/etc. Should I continue on what this can lead
> > to? I think no.
> >
> > So, the only acceptable way is to assign committer to review a patch
> > manually and then submit it to TC.
> >
> > Process in my view should be the following:
> >
> > 1. Contributor finishes with the task and attaches a patch to JIRA issue.
> > 2. Committer picks up the issue and reviews the changes.
> > 3. If changes are OK, committer submits them to TC in a separate branch.
> > 4. After TC passes committer merges the changes to the target sprint
> branch.
> > 5. JIRA issue gets closed.
> >
> > Thoughts?
> >
> > --Yakov
> >
> > 2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> >
> > > Sergey and I had a good Skype call and everything seems to be
> resolved. The
> > > installed jira-cli tools work just fine http://bit.ly/1c2qmeH
> > >
> > > Attachments and comments do not need to be fetched using jira-cli. The
> > > proposed workflow for the automatic patching is explained at the
> bottom of
> > > dev-tools/src/main/groovy/jiraslurp.groovy
> > > please let me know if there are any questions about it.
> > >
> > > Sergey will see to make sure that we have parameterized builds, which
> will
> > > be
> > > triggered from the groovy script above. In fact, that is the last thing
> > > that
> > > is blocking the completion of this task. Looks like our off-line
> > > conversation
> > > with him helped to get the ball rolling!
> > >
> > > Cos
> > >
> > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > Cos,
> > > >
> > > > Does cli works on your local machine?
> > > >
> > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > Administration
> > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > >
> > > > Sergey tried it locally and it just hangs.
> > > >
> > > >
> > > > --Yakov
> > > >
> > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > Hi Yakov.
> > > > >
> > > > > With jira-cli 3.9 one doesn't need to install anything on the
> server
> > > side.
> > > > > The
> > > > > older version of the tools work with JIRA backend. The newer
> version
> > > (not
> > > > > produced by Atlassian anymore) requires some additional stuff to be
> > > set.
> > > > >
> > > > > I will take a look at the agents' configuration later in the day
> and
> > > will
> > > > > get
> > > > > back to you here.
> > > > >
> > > > > Thanks,
> > > > > Cos
> > > > >
> > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > Cos,
> > > > > >
> > > > > > We still have problem while applying patch on TC. Attachments and
> > > > > comments
> > > > > > cannot be fetched from Jira when using jira-cli on current
> agents.
> > > > > >
> > > > > > Can you please make sure that server side of jira-cli is properly
> > > > > > installed? Do you know any other way to fetch that?
> > > > > >
> > > > > > --Yakov
> > > > > >
> > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > >
> > > > > > > oops
> > > > > > >
> > > > > > > s/not/now/g
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > cos@apache.org>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > > commenting
> > > > > > > part of the patch validation!
> > > > > > > >
> > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> mean
> > > that
> > > > > you
> > > > > > > will
> > > > > > > > be able to finish it or will not?
> > > > > > > >
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> wrote:
> > > > > > > > >A A Hello Konstantin.
> > > > > > > > >A A I've installed lira-cli on all agents (7) - path
> of
> > > cli
> > > > > is
> > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> Boudnik
> > > > > > > > <co...@apache.org>
> > > > > > > > >A A wrote:
> > > > >
> > >
> > >
>
Re: Fwd: automatic patch validation on TC
Posted by Artiom Shutak <as...@gridgain.com>.
I've created new Jira user without granting him some additional privileges.
The user cannot move jira status, but he can add any attachment under this
user.
I see at least one bad scenario: hacker can just monitor for new "Patch
available" tickets and attach a bad patch. As a result, the test builds
will run with bad patch.
I think, for example, we should approve to attach files with "patch"
extensions for contributors only (Somebody knows can we do that?), or just
manually run all test builds for attached to TC file or link on file.
Thoughts?
-- Artem --
On Wed, May 20, 2015 at 4:26 PM, Yakov Zhdanov <yz...@gridgain.com>
wrote:
> I still insist that this should be implemented with great care.
>
> Cos, can you please provide information on which projects used same
> approach?
>
> > Don't we trust our contributors?
>
> Well, you never know how they store the password and how strong it is.
>
> > if TC agents aren't running as privileged user - and they shouldn't be -
> malicious code won't do any harm to the system.
>
> Ignite tests should be able to do a lot of operations - establish network
> connections, accept incoming connections, start processes and access file
> system.
>
> In order to address possible issues we need to:
> 1. limit the tests scenarios launched on patch attach.
> 2. backup TC workers state once a day and store several days history to
> quickly restore the state.
>
> --
> Yakov Zhdanov, Director R&D
> *GridGain Systems*
> www.gridgain.com
>
> 2015-05-19 20:53 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>
> > Here's two reasons why current approach is secure enough (and in fact has
> > been used for some time on Apache build infrastructure):
> >
> > - only project contributors can manipulate JIRA: attaching, changing
> > state, etc. Don't we trust our contributors?
> > - if TC agents aren't running as privileged user - and they shouldn't be
> -
> > malicious code won't do any harm to the system.
> >
> > Thoughts?
> > Cos
> >
> > On Tue, May 19, 2015 at 04:47PM, Yakov Zhdanov wrote:
> > > Guys,
> > >
> > > It seems we need to stop any activity in this direction.
> > >
> > > I have just realized that automatic patch validation (at least in its
> > form
> > > we agreed on) opens a huge security hole - anyone who attaches a patch
> to
> > > JIRA can execute literally any code (!) on our public TC -
> > > java/bash/binary/built-in OS/etc. Should I continue on what this can
> lead
> > > to? I think no.
> > >
> > > So, the only acceptable way is to assign committer to review a patch
> > > manually and then submit it to TC.
> > >
> > > Process in my view should be the following:
> > >
> > > 1. Contributor finishes with the task and attaches a patch to JIRA
> issue.
> > > 2. Committer picks up the issue and reviews the changes.
> > > 3. If changes are OK, committer submits them to TC in a separate
> branch.
> > > 4. After TC passes committer merges the changes to the target sprint
> > branch.
> > > 5. JIRA issue gets closed.
> > >
> > > Thoughts?
> > >
> > > --Yakov
> > >
> > > 2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > >
> > > > Sergey and I had a good Skype call and everything seems to be
> > resolved. The
> > > > installed jira-cli tools work just fine http://bit.ly/1c2qmeH
> > > >
> > > > Attachments and comments do not need to be fetched using jira-cli.
> The
> > > > proposed workflow for the automatic patching is explained at the
> > bottom of
> > > > dev-tools/src/main/groovy/jiraslurp.groovy
> > > > please let me know if there are any questions about it.
> > > >
> > > > Sergey will see to make sure that we have parameterized builds, which
> > will
> > > > be
> > > > triggered from the groovy script above. In fact, that is the last
> thing
> > > > that
> > > > is blocking the completion of this task. Looks like our off-line
> > > > conversation
> > > > with him helped to get the ball rolling!
> > > >
> > > > Cos
> > > >
> > > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > > Cos,
> > > > >
> > > > > Does cli works on your local machine?
> > > > >
> > > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > > Administration
> > > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > > >
> > > > > Sergey tried it locally and it just hangs.
> > > > >
> > > > >
> > > > > --Yakov
> > > > >
> > > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > >
> > > > > > Hi Yakov.
> > > > > >
> > > > > > With jira-cli 3.9 one doesn't need to install anything on the
> > server
> > > > side.
> > > > > > The
> > > > > > older version of the tools work with JIRA backend. The newer
> > version
> > > > (not
> > > > > > produced by Atlassian anymore) requires some additional stuff to
> be
> > > > set.
> > > > > >
> > > > > > I will take a look at the agents' configuration later in the day
> > and
> > > > will
> > > > > > get
> > > > > > back to you here.
> > > > > >
> > > > > > Thanks,
> > > > > > Cos
> > > > > >
> > > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > > Cos,
> > > > > > >
> > > > > > > We still have problem while applying patch on TC. Attachments
> and
> > > > > > comments
> > > > > > > cannot be fetched from Jira when using jira-cli on current
> > agents.
> > > > > > >
> > > > > > > Can you please make sure that server side of jira-cli is
> properly
> > > > > > > installed? Do you know any other way to fetch that?
> > > > > > >
> > > > > > > --Yakov
> > > > > > >
> > > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > > >
> > > > > > > > oops
> > > > > > > >
> > > > > > > > s/not/now/g
> > > > > > > >
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > > cos@apache.org>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Thanks - that's great: not I'd be able to finish up
> the
> > > > > > commenting
> > > > > > > > part of the patch validation!
> > > > > > > > >
> > > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> > mean
> > > > that
> > > > > > you
> > > > > > > > will
> > > > > > > > > be able to finish it or will not?
> > > > > > > > >
> > > > > > > > > Cos
> > > > > > > > >
> > > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> > wrote:
> > > > > > > > > >A A Hello Konstantin.
> > > > > > > > > >A A I've installed lira-cli on all agents (7) -
> path
> > of
> > > > cli
> > > > > > is
> > > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> > Boudnik
> > > > > > > > > <co...@apache.org>
> > > > > > > > > >A A wrote:
> > > > > >
> > > >
> > > >
> >
>
Re: Fwd: automatic patch validation on TC
Posted by Branko Čibej <br...@apache.org>.
On 20.05.2015 21:36, Dmitriy Setrakyan wrote:
> On Wed, May 20, 2015 at 6:26 AM, Yakov Zhdanov <yz...@gridgain.com>
> wrote:
>
>> I still insist that this should be implemented with great care.
>>
> I tend to agree with Cos here. Let's implement this feature. If we get some
> malicious contributor attaching bad patches, we will catch it very quickly
> and remove him/her from Jira. All it takes to catch something like this is
> a normal patch review by a committer, which is part of Ignite standard
> development process.
Exactly. This is one of the reasons why we make our repository, Jira,
commit notifications etc. public. Any number of projects have automatic
patch validation, and I've yet to hear about a single attack or exploit
that got in through that channel.
-- Brane
Re: Fwd: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@apache.org>.
On Wed, May 20, 2015 at 6:26 AM, Yakov Zhdanov <yz...@gridgain.com>
wrote:
> I still insist that this should be implemented with great care.
>
I tend to agree with Cos here. Let's implement this feature. If we get some
malicious contributor attaching bad patches, we will catch it very quickly
and remove him/her from Jira. All it takes to catch something like this is
a normal patch review by a committer, which is part of Ignite standard
development process.
>
> Cos, can you please provide information on which projects used same
> approach?
>
> > Don't we trust our contributors?
>
> Well, you never know how they store the password and how strong it is.
>
Again, don't think it is an issue.
>
> > if TC agents aren't running as privileged user - and they shouldn't be -
> malicious code won't do any harm to the system.
>
> Ignite tests should be able to do a lot of operations - establish network
> connections, accept incoming connections, start processes and access file
> system.
>
> In order to address possible issues we need to:
> 1. limit the tests scenarios launched on patch attach.
> 2. backup TC workers state once a day and store several days history to
> quickly restore the state.
>
And again, if something bad happens, we can deal with it in a normal
fashion.
I personally think that we are worrying about something that will never
happen. My preference is to get this feature out as soon as possible so our
contributors have a normal path to execute builds on TeamCity.
D.
Re: Fwd: automatic patch validation on TC
Posted by Yakov Zhdanov <yz...@gridgain.com>.
I still insist that this should be implemented with great care.
Cos, can you please provide information on which projects used same
approach?
> Don't we trust our contributors?
Well, you never know how they store the password and how strong it is.
> if TC agents aren't running as privileged user - and they shouldn't be -
malicious code won't do any harm to the system.
Ignite tests should be able to do a lot of operations - establish network
connections, accept incoming connections, start processes and access file
system.
In order to address possible issues we need to:
1. limit the tests scenarios launched on patch attach.
2. backup TC workers state once a day and store several days history to
quickly restore the state.
--
Yakov Zhdanov, Director R&D
*GridGain Systems*
www.gridgain.com
2015-05-19 20:53 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> Here's two reasons why current approach is secure enough (and in fact has
> been used for some time on Apache build infrastructure):
>
> - only project contributors can manipulate JIRA: attaching, changing
> state, etc. Don't we trust our contributors?
> - if TC agents aren't running as privileged user - and they shouldn't be -
> malicious code won't do any harm to the system.
>
> Thoughts?
> Cos
>
> On Tue, May 19, 2015 at 04:47PM, Yakov Zhdanov wrote:
> > Guys,
> >
> > It seems we need to stop any activity in this direction.
> >
> > I have just realized that automatic patch validation (at least in its
> form
> > we agreed on) opens a huge security hole - anyone who attaches a patch to
> > JIRA can execute literally any code (!) on our public TC -
> > java/bash/binary/built-in OS/etc. Should I continue on what this can lead
> > to? I think no.
> >
> > So, the only acceptable way is to assign committer to review a patch
> > manually and then submit it to TC.
> >
> > Process in my view should be the following:
> >
> > 1. Contributor finishes with the task and attaches a patch to JIRA issue.
> > 2. Committer picks up the issue and reviews the changes.
> > 3. If changes are OK, committer submits them to TC in a separate branch.
> > 4. After TC passes committer merges the changes to the target sprint
> branch.
> > 5. JIRA issue gets closed.
> >
> > Thoughts?
> >
> > --Yakov
> >
> > 2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> >
> > > Sergey and I had a good Skype call and everything seems to be
> resolved. The
> > > installed jira-cli tools work just fine http://bit.ly/1c2qmeH
> > >
> > > Attachments and comments do not need to be fetched using jira-cli. The
> > > proposed workflow for the automatic patching is explained at the
> bottom of
> > > dev-tools/src/main/groovy/jiraslurp.groovy
> > > please let me know if there are any questions about it.
> > >
> > > Sergey will see to make sure that we have parameterized builds, which
> will
> > > be
> > > triggered from the groovy script above. In fact, that is the last thing
> > > that
> > > is blocking the completion of this task. Looks like our off-line
> > > conversation
> > > with him helped to get the ball rolling!
> > >
> > > Cos
> > >
> > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > Cos,
> > > >
> > > > Does cli works on your local machine?
> > > >
> > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > Administration
> > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > >
> > > > Sergey tried it locally and it just hangs.
> > > >
> > > >
> > > > --Yakov
> > > >
> > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > Hi Yakov.
> > > > >
> > > > > With jira-cli 3.9 one doesn't need to install anything on the
> server
> > > side.
> > > > > The
> > > > > older version of the tools work with JIRA backend. The newer
> version
> > > (not
> > > > > produced by Atlassian anymore) requires some additional stuff to be
> > > set.
> > > > >
> > > > > I will take a look at the agents' configuration later in the day
> and
> > > will
> > > > > get
> > > > > back to you here.
> > > > >
> > > > > Thanks,
> > > > > Cos
> > > > >
> > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > Cos,
> > > > > >
> > > > > > We still have problem while applying patch on TC. Attachments and
> > > > > comments
> > > > > > cannot be fetched from Jira when using jira-cli on current
> agents.
> > > > > >
> > > > > > Can you please make sure that server side of jira-cli is properly
> > > > > > installed? Do you know any other way to fetch that?
> > > > > >
> > > > > > --Yakov
> > > > > >
> > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > >
> > > > > > > oops
> > > > > > >
> > > > > > > s/not/now/g
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > cos@apache.org>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > > commenting
> > > > > > > part of the patch validation!
> > > > > > > >
> > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> mean
> > > that
> > > > > you
> > > > > > > will
> > > > > > > > be able to finish it or will not?
> > > > > > > >
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> wrote:
> > > > > > > > >A A Hello Konstantin.
> > > > > > > > >A A I've installed lira-cli on all agents (7) - path
> of
> > > cli
> > > > > is
> > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> Boudnik
> > > > > > > > <co...@apache.org>
> > > > > > > > >A A wrote:
> > > > >
> > >
> > >
>
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Here's two reasons why current approach is secure enough (and in fact has
been used for some time on Apache build infrastructure):
- only project contributors can manipulate JIRA: attaching, changing
state, etc. Don't we trust our contributors?
- if TC agents aren't running as privileged user - and they shouldn't be -
malicious code won't do any harm to the system.
Thoughts?
Cos
On Tue, May 19, 2015 at 04:47PM, Yakov Zhdanov wrote:
> Guys,
>
> It seems we need to stop any activity in this direction.
>
> I have just realized that automatic patch validation (at least in its form
> we agreed on) opens a huge security hole - anyone who attaches a patch to
> JIRA can execute literally any code (!) on our public TC -
> java/bash/binary/built-in OS/etc. Should I continue on what this can lead
> to? I think no.
>
> So, the only acceptable way is to assign committer to review a patch
> manually and then submit it to TC.
>
> Process in my view should be the following:
>
> 1. Contributor finishes with the task and attaches a patch to JIRA issue.
> 2. Committer picks up the issue and reviews the changes.
> 3. If changes are OK, committer submits them to TC in a separate branch.
> 4. After TC passes committer merges the changes to the target sprint branch.
> 5. JIRA issue gets closed.
>
> Thoughts?
>
> --Yakov
>
> 2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>
> > Sergey and I had a good Skype call and everything seems to be resolved. The
> > installed jira-cli tools work just fine http://bit.ly/1c2qmeH
> >
> > Attachments and comments do not need to be fetched using jira-cli. The
> > proposed workflow for the automatic patching is explained at the bottom of
> > dev-tools/src/main/groovy/jiraslurp.groovy
> > please let me know if there are any questions about it.
> >
> > Sergey will see to make sure that we have parameterized builds, which will
> > be
> > triggered from the groovy script above. In fact, that is the last thing
> > that
> > is blocking the completion of this task. Looks like our off-line
> > conversation
> > with him helped to get the ball rolling!
> >
> > Cos
> >
> > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > Cos,
> > >
> > > Does cli works on your local machine?
> > >
> > > Can you check if our JIRA allows remote API calls -> "Go to
> > Administration
> > > -> General Configuration and ensure Accept remote API calls in ON"?
> > >
> > > Sergey tried it locally and it just hangs.
> > >
> > >
> > > --Yakov
> > >
> > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > >
> > > > Hi Yakov.
> > > >
> > > > With jira-cli 3.9 one doesn't need to install anything on the server
> > side.
> > > > The
> > > > older version of the tools work with JIRA backend. The newer version
> > (not
> > > > produced by Atlassian anymore) requires some additional stuff to be
> > set.
> > > >
> > > > I will take a look at the agents' configuration later in the day and
> > will
> > > > get
> > > > back to you here.
> > > >
> > > > Thanks,
> > > > Cos
> > > >
> > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > Cos,
> > > > >
> > > > > We still have problem while applying patch on TC. Attachments and
> > > > comments
> > > > > cannot be fetched from Jira when using jira-cli on current agents.
> > > > >
> > > > > Can you please make sure that server side of jira-cli is properly
> > > > > installed? Do you know any other way to fetch that?
> > > > >
> > > > > --Yakov
> > > > >
> > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > >
> > > > > > oops
> > > > > >
> > > > > > s/not/now/g
> > > > > >
> > > > > > Cos
> > > > > >
> > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > cos@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > commenting
> > > > > > part of the patch validation!
> > > > > > >
> > > > > > > Cos, I think some meaning was lost due to typos. Do you mean
> > that
> > > > you
> > > > > > will
> > > > > > > be able to finish it or will not?
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > > > > >A A Hello Konstantin.
> > > > > > > >A A I've installed lira-cli on all agents (7) - path of
> > cli
> > > > is
> > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > > > > <co...@apache.org>
> > > > > > > >A A wrote:
> > > >
> >
> >
Re: Fwd: automatic patch validation on TC
Posted by Yakov Zhdanov <yz...@apache.org>.
Guys,
It seems we need to stop any activity in this direction.
I have just realized that automatic patch validation (at least in its form
we agreed on) opens a huge security hole - anyone who attaches a patch to
JIRA can execute literally any code (!) on our public TC -
java/bash/binary/built-in OS/etc. Should I continue on what this can lead
to? I think no.
So, the only acceptable way is to assign committer to review a patch
manually and then submit it to TC.
Process in my view should be the following:
1. Contributor finishes with the task and attaches a patch to JIRA issue.
2. Committer picks up the issue and reviews the changes.
3. If changes are OK, committer submits them to TC in a separate branch.
4. After TC passes committer merges the changes to the target sprint branch.
5. JIRA issue gets closed.
Thoughts?
--Yakov
2015-05-05 23:31 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> Sergey and I had a good Skype call and everything seems to be resolved. The
> installed jira-cli tools work just fine http://bit.ly/1c2qmeH
>
> Attachments and comments do not need to be fetched using jira-cli. The
> proposed workflow for the automatic patching is explained at the bottom of
> dev-tools/src/main/groovy/jiraslurp.groovy
> please let me know if there are any questions about it.
>
> Sergey will see to make sure that we have parameterized builds, which will
> be
> triggered from the groovy script above. In fact, that is the last thing
> that
> is blocking the completion of this task. Looks like our off-line
> conversation
> with him helped to get the ball rolling!
>
> Cos
>
> On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > Cos,
> >
> > Does cli works on your local machine?
> >
> > Can you check if our JIRA allows remote API calls -> "Go to
> Administration
> > -> General Configuration and ensure Accept remote API calls in ON"?
> >
> > Sergey tried it locally and it just hangs.
> >
> >
> > --Yakov
> >
> > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> >
> > > Hi Yakov.
> > >
> > > With jira-cli 3.9 one doesn't need to install anything on the server
> side.
> > > The
> > > older version of the tools work with JIRA backend. The newer version
> (not
> > > produced by Atlassian anymore) requires some additional stuff to be
> set.
> > >
> > > I will take a look at the agents' configuration later in the day and
> will
> > > get
> > > back to you here.
> > >
> > > Thanks,
> > > Cos
> > >
> > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > Cos,
> > > >
> > > > We still have problem while applying patch on TC. Attachments and
> > > comments
> > > > cannot be fetched from Jira when using jira-cli on current agents.
> > > >
> > > > Can you please make sure that server side of jira-cli is properly
> > > > installed? Do you know any other way to fetch that?
> > > >
> > > > --Yakov
> > > >
> > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > oops
> > > > >
> > > > > s/not/now/g
> > > > >
> > > > > Cos
> > > > >
> > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > cos@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > Thanks - that's great: not I'd be able to finish up the
> > > commenting
> > > > > part of the patch validation!
> > > > > >
> > > > > > Cos, I think some meaning was lost due to typos. Do you mean
> that
> > > you
> > > > > will
> > > > > > be able to finish it or will not?
> > > > > >
> > > > > > Cos
> > > > > >
> > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > > > >A A Hello Konstantin.
> > > > > > >A A I've installed lira-cli on all agents (7) - path of
> cli
> > > is
> > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > > > <co...@apache.org>
> > > > > > >A A wrote:
> > >
>
>
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Sergey and I had a good Skype call and everything seems to be resolved. The
installed jira-cli tools work just fine http://bit.ly/1c2qmeH
Attachments and comments do not need to be fetched using jira-cli. The
proposed workflow for the automatic patching is explained at the bottom of
dev-tools/src/main/groovy/jiraslurp.groovy
please let me know if there are any questions about it.
Sergey will see to make sure that we have parameterized builds, which will be
triggered from the groovy script above. In fact, that is the last thing that
is blocking the completion of this task. Looks like our off-line conversation
with him helped to get the ball rolling!
Cos
On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> Cos,
>
> Does cli works on your local machine?
>
> Can you check if our JIRA allows remote API calls -> "Go to Administration
> -> General Configuration and ensure Accept remote API calls in ON"?
>
> Sergey tried it locally and it just hangs.
>
>
> --Yakov
>
> 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>
> > Hi Yakov.
> >
> > With jira-cli 3.9 one doesn't need to install anything on the server side.
> > The
> > older version of the tools work with JIRA backend. The newer version (not
> > produced by Atlassian anymore) requires some additional stuff to be set.
> >
> > I will take a look at the agents' configuration later in the day and will
> > get
> > back to you here.
> >
> > Thanks,
> > Cos
> >
> > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > Cos,
> > >
> > > We still have problem while applying patch on TC. Attachments and
> > comments
> > > cannot be fetched from Jira when using jira-cli on current agents.
> > >
> > > Can you please make sure that server side of jira-cli is properly
> > > installed? Do you know any other way to fetch that?
> > >
> > > --Yakov
> > >
> > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > >
> > > > oops
> > > >
> > > > s/not/now/g
> > > >
> > > > Cos
> > > >
> > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > cos@apache.org>
> > > > > wrote:
> > > > >
> > > > > Thanks - that's great: not I'd be able to finish up the
> > commenting
> > > > part of the patch validation!
> > > > >
> > > > > Cos, I think some meaning was lost due to typos. Do you mean that
> > you
> > > > will
> > > > > be able to finish it or will not?
> > > > >
> > > > > Cos
> > > > >
> > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > > >A A Hello Konstantin.
> > > > > >A A I've installed lira-cli on all agents (7) - path of cli
> > is
> > > > > >A A /opt/jira-cli-3.9.0
> > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > > <co...@apache.org>
> > > > > >A A wrote:
> >
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
If you look at the branch ignite-620 (as referred in the ticket) you'll see
the example at the very end. I am waiting to get this stuff committed, so I
can finish all the tiny bits that left, like commenting.
Literally, all I need right now, is a review so I can commit the code (which
is completely independent from the rest of the system) to unblock my further
progress.
Cos
On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
> Cos, could you pls give example how you get attachment or comment from jira
> issue?
>
> On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org> wrote:
>
> > Yakov
> >
> > Yes, cli works on my local machine. In fact I am using this version of cli
> > to
> > work with ASF JIRA for years. This
> > https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
> > only -
> > no manual edits.
> >
> > Unfortunately, I wasn't able to verify the slaves last night - we'll try
> > today. Thanks!
> > Cos
> >
> > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > Cos,
> > >
> > > Does cli works on your local machine?
> > >
> > > Can you check if our JIRA allows remote API calls -> "Go to
> > Administration
> > > -> General Configuration and ensure Accept remote API calls in ON"?
> > >
> > > Sergey tried it locally and it just hangs.
> > >
> > >
> > > --Yakov
> > >
> > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > >
> > > > Hi Yakov.
> > > >
> > > > With jira-cli 3.9 one doesn't need to install anything on the server
> > side.
> > > > The
> > > > older version of the tools work with JIRA backend. The newer version
> > (not
> > > > produced by Atlassian anymore) requires some additional stuff to be
> > set.
> > > >
> > > > I will take a look at the agents' configuration later in the day and
> > will
> > > > get
> > > > back to you here.
> > > >
> > > > Thanks,
> > > > Cos
> > > >
> > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > Cos,
> > > > >
> > > > > We still have problem while applying patch on TC. Attachments and
> > > > comments
> > > > > cannot be fetched from Jira when using jira-cli on current agents.
> > > > >
> > > > > Can you please make sure that server side of jira-cli is properly
> > > > > installed? Do you know any other way to fetch that?
> > > > >
> > > > > --Yakov
> > > > >
> > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > >
> > > > > > oops
> > > > > >
> > > > > > s/not/now/g
> > > > > >
> > > > > > Cos
> > > > > >
> > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > cos@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > commenting
> > > > > > part of the patch validation!
> > > > > > >
> > > > > > > Cos, I think some meaning was lost due to typos. Do you mean
> > that
> > > > you
> > > > > > will
> > > > > > > be able to finish it or will not?
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > > > > >A A Hello Konstantin.
> > > > > > > >A A I've installed lira-cli on all agents (7) - path of
> > cli
> > > > is
> > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > > > > <co...@apache.org>
> > > > > > > >A A wrote:
> > > >
> >
> >
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Hi Sergey.
I can not re-attach an instance with the command you provided; also using
attach doesn't provide me with an interactive shell.
Clearly these instances are running sshd, but I have no credentials to log in.
Perhaps it'd be easier if we can jump on a skype call and quickly figure it
out?
Thanks for all your help!
Cos
On Fri, May 01, 2015 at 01:24PM, Sergey Bachinskiy wrote:
> Cos, agents in docker container 2 of them in master - you can login to
> root shell of agent by shell command - docker -i -t container_id bash, id
> of container you can get by command - docker ps (all enabled and running
> containers)
> to another machine with agents you can login by ip 204.14.53.153 and user
> gg with password Gr1dGa1N
>
> On Fri, May 1, 2015 at 2:51 AM, Konstantin Boudnik <co...@apache.org> wrote:
>
> > Guys,
> >
> > I managed to get into the master, but I can not get into master server,
> > but I
> > can not get into slaves machines as the ip addresses listen in the TC
> > server
> > are from private network and master doesn't have a routing there.
> >
> > How I can get into slaves to change on the jira-cli tools? Or shall I just
> > make a tiny build and try to execute it from there?
> >
> > Thanks
> > Cos
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Ah, darn - now I remember that the TC is in containers ;( Silly me - thanks
man: we'll check it shortly and report about my findings.
Cos
On Fri, May 01, 2015 at 01:24PM, Sergey Bachinskiy wrote:
> Cos, agents in docker container 2 of them in master - you can login to
> root shell of agent by shell command - docker -i -t container_id bash, id
> of container you can get by command - docker ps (all enabled and running
> containers)
> to another machine with agents you can login by ip 204.14.53.153 and user
> gg with password Gr1dGa1N
>
> On Fri, May 1, 2015 at 2:51 AM, Konstantin Boudnik <co...@apache.org> wrote:
>
> > Guys,
> >
> > I managed to get into the master, but I can not get into master server,
> > but I
> > can not get into slaves machines as the ip addresses listen in the TC
> > server
> > are from private network and master doesn't have a routing there.
> >
> > How I can get into slaves to change on the jira-cli tools? Or shall I just
> > make a tiny build and try to execute it from there?
> >
> > Thanks
> > Cos
> >
> > On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
> > > Cos, could you pls give example how you get attachment or comment from
> > jira
> > > issue?
> > >
> > > On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
> > wrote:
> > >
> > > > Yakov
> > > >
> > > > Yes, cli works on my local machine. In fact I am using this version of
> > cli
> > > > to
> > > > work with ASF JIRA for years. This
> > > > https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
> > > > only -
> > > > no manual edits.
> > > >
> > > > Unfortunately, I wasn't able to verify the slaves last night - we'll
> > try
> > > > today. Thanks!
> > > > Cos
> > > >
> > > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > > Cos,
> > > > >
> > > > > Does cli works on your local machine?
> > > > >
> > > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > > Administration
> > > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > > >
> > > > > Sergey tried it locally and it just hangs.
> > > > >
> > > > >
> > > > > --Yakov
> > > > >
> > > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > >
> > > > > > Hi Yakov.
> > > > > >
> > > > > > With jira-cli 3.9 one doesn't need to install anything on the
> > server
> > > > side.
> > > > > > The
> > > > > > older version of the tools work with JIRA backend. The newer
> > version
> > > > (not
> > > > > > produced by Atlassian anymore) requires some additional stuff to be
> > > > set.
> > > > > >
> > > > > > I will take a look at the agents' configuration later in the day
> > and
> > > > will
> > > > > > get
> > > > > > back to you here.
> > > > > >
> > > > > > Thanks,
> > > > > > Cos
> > > > > >
> > > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > > Cos,
> > > > > > >
> > > > > > > We still have problem while applying patch on TC. Attachments and
> > > > > > comments
> > > > > > > cannot be fetched from Jira when using jira-cli on current
> > agents.
> > > > > > >
> > > > > > > Can you please make sure that server side of jira-cli is properly
> > > > > > > installed? Do you know any other way to fetch that?
> > > > > > >
> > > > > > > --Yakov
> > > > > > >
> > > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > > >
> > > > > > > > oops
> > > > > > > >
> > > > > > > > s/not/now/g
> > > > > > > >
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > > cos@apache.org>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > > > commenting
> > > > > > > > part of the patch validation!
> > > > > > > > >
> > > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> > mean
> > > > that
> > > > > > you
> > > > > > > > will
> > > > > > > > > be able to finish it or will not?
> > > > > > > > >
> > > > > > > > > Cos
> > > > > > > > >
> > > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> > wrote:
> > > > > > > > > >A A Hello Konstantin.
> > > > > > > > > >A A I've installed lira-cli on all agents (7) - path
> > of
> > > > cli
> > > > > > is
> > > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> > Boudnik
> > > > > > > > > <co...@apache.org>
> > > > > > > > > >A A wrote:
> > > > > >
> > > >
> > > >
> >
Re: Fwd: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@apache.org>.
Just got confirmation that the password was changed. We must be very
careful going forward.
On Fri, May 1, 2015 at 5:38 AM, Dmitriy Setrakyan <ds...@gridgain.com>
wrote:
> I have instructed Sergey to change the password and not send passwords to
> a public dev list.
>
> D.
>
> On Fri, May 1, 2015 at 5:24 AM, Sergey Bachinskiy <
> sbachinskiy@gridgain.com> wrote:
>
>> Cos, agents in docker container 2 of them in master - you can login to
>> root shell of agent by shell command - docker -i -t container_id bash, id
>> of container you can get by command - docker ps (all enabled and running
>> containers)
>> to another machine with agents you can login by ip 204.14.53.153 and user
>> gg with password Gr1dGa1N
>>
>> On Fri, May 1, 2015 at 2:51 AM, Konstantin Boudnik <co...@apache.org>
>> wrote:
>>
>>> Guys,
>>>
>>> I managed to get into the master, but I can not get into master server,
>>> but I
>>> can not get into slaves machines as the ip addresses listen in the TC
>>> server
>>> are from private network and master doesn't have a routing there.
>>>
>>> How I can get into slaves to change on the jira-cli tools? Or shall I
>>> just
>>> make a tiny build and try to execute it from there?
>>>
>>> Thanks
>>> Cos
>>>
>>> On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
>>> > Cos, could you pls give example how you get attachment or comment from
>>> jira
>>> > issue?
>>> >
>>> > On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
>>> wrote:
>>> >
>>> > > Yakov
>>> > >
>>> > > Yes, cli works on my local machine. In fact I am using this version
>>> of cli
>>> > > to
>>> > > work with ASF JIRA for years. This
>>> > > https://issues.apache.org/jira/browse/IGNITE-495 is populated via
>>> cli
>>> > > only -
>>> > > no manual edits.
>>> > >
>>> > > Unfortunately, I wasn't able to verify the slaves last night - we'll
>>> try
>>> > > today. Thanks!
>>> > > Cos
>>> > >
>>> > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
>>> > > > Cos,
>>> > > >
>>> > > > Does cli works on your local machine?
>>> > > >
>>> > > > Can you check if our JIRA allows remote API calls -> "Go to
>>> > > Administration
>>> > > > -> General Configuration and ensure Accept remote API calls in ON"?
>>> > > >
>>> > > > Sergey tried it locally and it just hangs.
>>> > > >
>>> > > >
>>> > > > --Yakov
>>> > > >
>>> > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>>> > > >
>>> > > > > Hi Yakov.
>>> > > > >
>>> > > > > With jira-cli 3.9 one doesn't need to install anything on the
>>> server
>>> > > side.
>>> > > > > The
>>> > > > > older version of the tools work with JIRA backend. The newer
>>> version
>>> > > (not
>>> > > > > produced by Atlassian anymore) requires some additional stuff to
>>> be
>>> > > set.
>>> > > > >
>>> > > > > I will take a look at the agents' configuration later in the day
>>> and
>>> > > will
>>> > > > > get
>>> > > > > back to you here.
>>> > > > >
>>> > > > > Thanks,
>>> > > > > Cos
>>> > > > >
>>> > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
>>> > > > > > Cos,
>>> > > > > >
>>> > > > > > We still have problem while applying patch on TC. Attachments
>>> and
>>> > > > > comments
>>> > > > > > cannot be fetched from Jira when using jira-cli on current
>>> agents.
>>> > > > > >
>>> > > > > > Can you please make sure that server side of jira-cli is
>>> properly
>>> > > > > > installed? Do you know any other way to fetch that?
>>> > > > > >
>>> > > > > > --Yakov
>>> > > > > >
>>> > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>>> > > > > >
>>> > > > > > > oops
>>> > > > > > >
>>> > > > > > > s/not/now/g
>>> > > > > > >
>>> > > > > > > Cos
>>> > > > > > >
>>> > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
>>> > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
>>> > > > > cos@apache.org>
>>> > > > > > > > wrote:
>>> > > > > > > >
>>> > > > > > > > Thanks - that's great: not I'd be able to finish up
>>> the
>>> > > > > commenting
>>> > > > > > > part of the patch validation!
>>> > > > > > > >
>>> > > > > > > > Cos, I think some meaning was lost due to typos. Do you
>>> mean
>>> > > that
>>> > > > > you
>>> > > > > > > will
>>> > > > > > > > be able to finish it or will not?
>>> > > > > > > >
>>> > > > > > > > Cos
>>> > > > > > > >
>>> > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
>>> wrote:
>>> > > > > > > > >A A Hello Konstantin.
>>> > > > > > > > >A A I've installed lira-cli on all agents (7) -
>>> path of
>>> > > cli
>>> > > > > is
>>> > > > > > > > >A A /opt/jira-cli-3.9.0
>>> > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
>>> Boudnik
>>> > > > > > > > <co...@apache.org>
>>> > > > > > > > >A A wrote:
>>> > > > >
>>> > >
>>> > >
>>>
>>
>>
>
Re: Fwd: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@gridgain.com>.
I have instructed Sergey to change the password and not send passwords to a
public dev list.
D.
On Fri, May 1, 2015 at 5:24 AM, Sergey Bachinskiy <sb...@gridgain.com>
wrote:
> Cos, agents in docker container 2 of them in master - you can login to
> root shell of agent by shell command - docker -i -t container_id bash, id
> of container you can get by command - docker ps (all enabled and running
> containers)
> to another machine with agents you can login by ip 204.14.53.153 and user
> gg with password Gr1dGa1N
>
> On Fri, May 1, 2015 at 2:51 AM, Konstantin Boudnik <co...@apache.org> wrote:
>
>> Guys,
>>
>> I managed to get into the master, but I can not get into master server,
>> but I
>> can not get into slaves machines as the ip addresses listen in the TC
>> server
>> are from private network and master doesn't have a routing there.
>>
>> How I can get into slaves to change on the jira-cli tools? Or shall I just
>> make a tiny build and try to execute it from there?
>>
>> Thanks
>> Cos
>>
>> On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
>> > Cos, could you pls give example how you get attachment or comment from
>> jira
>> > issue?
>> >
>> > On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
>> wrote:
>> >
>> > > Yakov
>> > >
>> > > Yes, cli works on my local machine. In fact I am using this version
>> of cli
>> > > to
>> > > work with ASF JIRA for years. This
>> > > https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
>> > > only -
>> > > no manual edits.
>> > >
>> > > Unfortunately, I wasn't able to verify the slaves last night - we'll
>> try
>> > > today. Thanks!
>> > > Cos
>> > >
>> > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
>> > > > Cos,
>> > > >
>> > > > Does cli works on your local machine?
>> > > >
>> > > > Can you check if our JIRA allows remote API calls -> "Go to
>> > > Administration
>> > > > -> General Configuration and ensure Accept remote API calls in ON"?
>> > > >
>> > > > Sergey tried it locally and it just hangs.
>> > > >
>> > > >
>> > > > --Yakov
>> > > >
>> > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>> > > >
>> > > > > Hi Yakov.
>> > > > >
>> > > > > With jira-cli 3.9 one doesn't need to install anything on the
>> server
>> > > side.
>> > > > > The
>> > > > > older version of the tools work with JIRA backend. The newer
>> version
>> > > (not
>> > > > > produced by Atlassian anymore) requires some additional stuff to
>> be
>> > > set.
>> > > > >
>> > > > > I will take a look at the agents' configuration later in the day
>> and
>> > > will
>> > > > > get
>> > > > > back to you here.
>> > > > >
>> > > > > Thanks,
>> > > > > Cos
>> > > > >
>> > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
>> > > > > > Cos,
>> > > > > >
>> > > > > > We still have problem while applying patch on TC. Attachments
>> and
>> > > > > comments
>> > > > > > cannot be fetched from Jira when using jira-cli on current
>> agents.
>> > > > > >
>> > > > > > Can you please make sure that server side of jira-cli is
>> properly
>> > > > > > installed? Do you know any other way to fetch that?
>> > > > > >
>> > > > > > --Yakov
>> > > > > >
>> > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>> > > > > >
>> > > > > > > oops
>> > > > > > >
>> > > > > > > s/not/now/g
>> > > > > > >
>> > > > > > > Cos
>> > > > > > >
>> > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
>> > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
>> > > > > cos@apache.org>
>> > > > > > > > wrote:
>> > > > > > > >
>> > > > > > > > Thanks - that's great: not I'd be able to finish up the
>> > > > > commenting
>> > > > > > > part of the patch validation!
>> > > > > > > >
>> > > > > > > > Cos, I think some meaning was lost due to typos. Do you
>> mean
>> > > that
>> > > > > you
>> > > > > > > will
>> > > > > > > > be able to finish it or will not?
>> > > > > > > >
>> > > > > > > > Cos
>> > > > > > > >
>> > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
>> wrote:
>> > > > > > > > >A A Hello Konstantin.
>> > > > > > > > >A A I've installed lira-cli on all agents (7) -
>> path of
>> > > cli
>> > > > > is
>> > > > > > > > >A A /opt/jira-cli-3.9.0
>> > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
>> Boudnik
>> > > > > > > > <co...@apache.org>
>> > > > > > > > >A A wrote:
>> > > > >
>> > >
>> > >
>>
>
>
Re: Fwd: automatic patch validation on TC
Posted by Sergey Bachinskiy <sb...@gridgain.com>.
Cos, agents in docker container 2 of them in master - you can login to
root shell of agent by shell command - docker -i -t container_id bash, id
of container you can get by command - docker ps (all enabled and running
containers)
to another machine with agents you can login by ip 204.14.53.153 and user
gg with password Gr1dGa1N
On Fri, May 1, 2015 at 2:51 AM, Konstantin Boudnik <co...@apache.org> wrote:
> Guys,
>
> I managed to get into the master, but I can not get into master server,
> but I
> can not get into slaves machines as the ip addresses listen in the TC
> server
> are from private network and master doesn't have a routing there.
>
> How I can get into slaves to change on the jira-cli tools? Or shall I just
> make a tiny build and try to execute it from there?
>
> Thanks
> Cos
>
> On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
> > Cos, could you pls give example how you get attachment or comment from
> jira
> > issue?
> >
> > On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
> wrote:
> >
> > > Yakov
> > >
> > > Yes, cli works on my local machine. In fact I am using this version of
> cli
> > > to
> > > work with ASF JIRA for years. This
> > > https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
> > > only -
> > > no manual edits.
> > >
> > > Unfortunately, I wasn't able to verify the slaves last night - we'll
> try
> > > today. Thanks!
> > > Cos
> > >
> > > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > > Cos,
> > > >
> > > > Does cli works on your local machine?
> > > >
> > > > Can you check if our JIRA allows remote API calls -> "Go to
> > > Administration
> > > > -> General Configuration and ensure Accept remote API calls in ON"?
> > > >
> > > > Sergey tried it locally and it just hangs.
> > > >
> > > >
> > > > --Yakov
> > > >
> > > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > Hi Yakov.
> > > > >
> > > > > With jira-cli 3.9 one doesn't need to install anything on the
> server
> > > side.
> > > > > The
> > > > > older version of the tools work with JIRA backend. The newer
> version
> > > (not
> > > > > produced by Atlassian anymore) requires some additional stuff to be
> > > set.
> > > > >
> > > > > I will take a look at the agents' configuration later in the day
> and
> > > will
> > > > > get
> > > > > back to you here.
> > > > >
> > > > > Thanks,
> > > > > Cos
> > > > >
> > > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > > Cos,
> > > > > >
> > > > > > We still have problem while applying patch on TC. Attachments and
> > > > > comments
> > > > > > cannot be fetched from Jira when using jira-cli on current
> agents.
> > > > > >
> > > > > > Can you please make sure that server side of jira-cli is properly
> > > > > > installed? Do you know any other way to fetch that?
> > > > > >
> > > > > > --Yakov
> > > > > >
> > > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > > >
> > > > > > > oops
> > > > > > >
> > > > > > > s/not/now/g
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > > cos@apache.org>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > > commenting
> > > > > > > part of the patch validation!
> > > > > > > >
> > > > > > > > Cos, I think some meaning was lost due to typos. Do you
> mean
> > > that
> > > > > you
> > > > > > > will
> > > > > > > > be able to finish it or will not?
> > > > > > > >
> > > > > > > > Cos
> > > > > > > >
> > > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy
> wrote:
> > > > > > > > >A A Hello Konstantin.
> > > > > > > > >A A I've installed lira-cli on all agents (7) - path
> of
> > > cli
> > > > > is
> > > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin
> Boudnik
> > > > > > > > <co...@apache.org>
> > > > > > > > >A A wrote:
> > > > >
> > >
> > >
>
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Guys,
I managed to get into the master, but I can not get into master server, but I
can not get into slaves machines as the ip addresses listen in the TC server
are from private network and master doesn't have a routing there.
How I can get into slaves to change on the jira-cli tools? Or shall I just
make a tiny build and try to execute it from there?
Thanks
Cos
On Wed, Apr 29, 2015 at 11:05PM, Sergey Bachinskiy wrote:
> Cos, could you pls give example how you get attachment or comment from jira
> issue?
>
> On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org> wrote:
>
> > Yakov
> >
> > Yes, cli works on my local machine. In fact I am using this version of cli
> > to
> > work with ASF JIRA for years. This
> > https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
> > only -
> > no manual edits.
> >
> > Unfortunately, I wasn't able to verify the slaves last night - we'll try
> > today. Thanks!
> > Cos
> >
> > On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > > Cos,
> > >
> > > Does cli works on your local machine?
> > >
> > > Can you check if our JIRA allows remote API calls -> "Go to
> > Administration
> > > -> General Configuration and ensure Accept remote API calls in ON"?
> > >
> > > Sergey tried it locally and it just hangs.
> > >
> > >
> > > --Yakov
> > >
> > > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > >
> > > > Hi Yakov.
> > > >
> > > > With jira-cli 3.9 one doesn't need to install anything on the server
> > side.
> > > > The
> > > > older version of the tools work with JIRA backend. The newer version
> > (not
> > > > produced by Atlassian anymore) requires some additional stuff to be
> > set.
> > > >
> > > > I will take a look at the agents' configuration later in the day and
> > will
> > > > get
> > > > back to you here.
> > > >
> > > > Thanks,
> > > > Cos
> > > >
> > > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > > Cos,
> > > > >
> > > > > We still have problem while applying patch on TC. Attachments and
> > > > comments
> > > > > cannot be fetched from Jira when using jira-cli on current agents.
> > > > >
> > > > > Can you please make sure that server side of jira-cli is properly
> > > > > installed? Do you know any other way to fetch that?
> > > > >
> > > > > --Yakov
> > > > >
> > > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > > >
> > > > > > oops
> > > > > >
> > > > > > s/not/now/g
> > > > > >
> > > > > > Cos
> > > > > >
> > > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > > cos@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > Thanks - that's great: not I'd be able to finish up the
> > > > commenting
> > > > > > part of the patch validation!
> > > > > > >
> > > > > > > Cos, I think some meaning was lost due to typos. Do you mean
> > that
> > > > you
> > > > > > will
> > > > > > > be able to finish it or will not?
> > > > > > >
> > > > > > > Cos
> > > > > > >
> > > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > > > > >A A Hello Konstantin.
> > > > > > > >A A I've installed lira-cli on all agents (7) - path of
> > cli
> > > > is
> > > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > > > > <co...@apache.org>
> > > > > > > >A A wrote:
> > > >
> >
> >
Re: Fwd: automatic patch validation on TC
Posted by Sergey Bachinskiy <sb...@gridgain.com>.
Cos, could you pls give example how you get attachment or comment from jira
issue?
On Wed, Apr 29, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org> wrote:
> Yakov
>
> Yes, cli works on my local machine. In fact I am using this version of cli
> to
> work with ASF JIRA for years. This
> https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli
> only -
> no manual edits.
>
> Unfortunately, I wasn't able to verify the slaves last night - we'll try
> today. Thanks!
> Cos
>
> On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> > Cos,
> >
> > Does cli works on your local machine?
> >
> > Can you check if our JIRA allows remote API calls -> "Go to
> Administration
> > -> General Configuration and ensure Accept remote API calls in ON"?
> >
> > Sergey tried it locally and it just hangs.
> >
> >
> > --Yakov
> >
> > 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> >
> > > Hi Yakov.
> > >
> > > With jira-cli 3.9 one doesn't need to install anything on the server
> side.
> > > The
> > > older version of the tools work with JIRA backend. The newer version
> (not
> > > produced by Atlassian anymore) requires some additional stuff to be
> set.
> > >
> > > I will take a look at the agents' configuration later in the day and
> will
> > > get
> > > back to you here.
> > >
> > > Thanks,
> > > Cos
> > >
> > > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > > Cos,
> > > >
> > > > We still have problem while applying patch on TC. Attachments and
> > > comments
> > > > cannot be fetched from Jira when using jira-cli on current agents.
> > > >
> > > > Can you please make sure that server side of jira-cli is properly
> > > > installed? Do you know any other way to fetch that?
> > > >
> > > > --Yakov
> > > >
> > > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > > >
> > > > > oops
> > > > >
> > > > > s/not/now/g
> > > > >
> > > > > Cos
> > > > >
> > > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > > cos@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > Thanks - that's great: not I'd be able to finish up the
> > > commenting
> > > > > part of the patch validation!
> > > > > >
> > > > > > Cos, I think some meaning was lost due to typos. Do you mean
> that
> > > you
> > > > > will
> > > > > > be able to finish it or will not?
> > > > > >
> > > > > > Cos
> > > > > >
> > > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > > > >A A Hello Konstantin.
> > > > > > >A A I've installed lira-cli on all agents (7) - path of
> cli
> > > is
> > > > > > >A A /opt/jira-cli-3.9.0
> > > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > > > <co...@apache.org>
> > > > > > >A A wrote:
> > >
>
>
Re: Fwd: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Yakov
Yes, cli works on my local machine. In fact I am using this version of cli to
work with ASF JIRA for years. This
https://issues.apache.org/jira/browse/IGNITE-495 is populated via cli only -
no manual edits.
Unfortunately, I wasn't able to verify the slaves last night - we'll try
today. Thanks!
Cos
On Wed, Apr 29, 2015 at 12:45PM, Yakov Zhdanov wrote:
> Cos,
>
> Does cli works on your local machine?
>
> Can you check if our JIRA allows remote API calls -> "Go to Administration
> -> General Configuration and ensure Accept remote API calls in ON"?
>
> Sergey tried it locally and it just hangs.
>
>
> --Yakov
>
> 2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>
> > Hi Yakov.
> >
> > With jira-cli 3.9 one doesn't need to install anything on the server side.
> > The
> > older version of the tools work with JIRA backend. The newer version (not
> > produced by Atlassian anymore) requires some additional stuff to be set.
> >
> > I will take a look at the agents' configuration later in the day and will
> > get
> > back to you here.
> >
> > Thanks,
> > Cos
> >
> > On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > > Cos,
> > >
> > > We still have problem while applying patch on TC. Attachments and
> > comments
> > > cannot be fetched from Jira when using jira-cli on current agents.
> > >
> > > Can you please make sure that server side of jira-cli is properly
> > > installed? Do you know any other way to fetch that?
> > >
> > > --Yakov
> > >
> > > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> > >
> > > > oops
> > > >
> > > > s/not/now/g
> > > >
> > > > Cos
> > > >
> > > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> > cos@apache.org>
> > > > > wrote:
> > > > >
> > > > > Thanks - that's great: not I'd be able to finish up the
> > commenting
> > > > part of the patch validation!
> > > > >
> > > > > Cos, I think some meaning was lost due to typos. Do you mean that
> > you
> > > > will
> > > > > be able to finish it or will not?
> > > > >
> > > > > Cos
> > > > >
> > > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > > >A A Hello Konstantin.
> > > > > >A A I've installed lira-cli on all agents (7) - path of cli
> > is
> > > > > >A A /opt/jira-cli-3.9.0
> > > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > > <co...@apache.org>
> > > > > >A A wrote:
> >
Fwd: automatic patch validation on TC
Posted by Yakov Zhdanov <yz...@gridgain.com>.
Cos,
Does cli works on your local machine?
Can you check if our JIRA allows remote API calls -> "Go to Administration
-> General Configuration and ensure Accept remote API calls in ON"?
Sergey tried it locally and it just hangs.
--Yakov
2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> Hi Yakov.
>
> With jira-cli 3.9 one doesn't need to install anything on the server side.
> The
> older version of the tools work with JIRA backend. The newer version (not
> produced by Atlassian anymore) requires some additional stuff to be set.
>
> I will take a look at the agents' configuration later in the day and will
> get
> back to you here.
>
> Thanks,
> Cos
>
> On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > Cos,
> >
> > We still have problem while applying patch on TC. Attachments and
> comments
> > cannot be fetched from Jira when using jira-cli on current agents.
> >
> > Can you please make sure that server side of jira-cli is properly
> > installed? Do you know any other way to fetch that?
> >
> > --Yakov
> >
> > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> >
> > > oops
> > >
> > > s/not/now/g
> > >
> > > Cos
> > >
> > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> cos@apache.org>
> > > > wrote:
> > > >
> > > > Thanks - that's great: not I'd be able to finish up the
> commenting
> > > part of the patch validation!
> > > >
> > > > Cos, I think some meaning was lost due to typos. Do you mean that
> you
> > > will
> > > > be able to finish it or will not?
> > > >
> > > > Cos
> > > >
> > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > >A A Hello Konstantin.
> > > > >A A I've installed lira-cli on all agents (7) - path of cli
> is
> > > > >A A /opt/jira-cli-3.9.0
> > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > <co...@apache.org>
> > > > >A A wrote:
>
Re: automatic patch validation on TC
Posted by Yakov Zhdanov <yz...@apache.org>.
Cos,
Does cli works on your local machine?
Can you check if our JIRA allows remote API calls -> "Go to Administration
-> General Configuration and ensure Accept remote API calls in ON"?
Sergey tried it locally and it just hangs.
--Yakov
2015-04-28 20:30 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> Hi Yakov.
>
> With jira-cli 3.9 one doesn't need to install anything on the server side.
> The
> older version of the tools work with JIRA backend. The newer version (not
> produced by Atlassian anymore) requires some additional stuff to be set.
>
> I will take a look at the agents' configuration later in the day and will
> get
> back to you here.
>
> Thanks,
> Cos
>
> On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> > Cos,
> >
> > We still have problem while applying patch on TC. Attachments and
> comments
> > cannot be fetched from Jira when using jira-cli on current agents.
> >
> > Can you please make sure that server side of jira-cli is properly
> > installed? Do you know any other way to fetch that?
> >
> > --Yakov
> >
> > 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> >
> > > oops
> > >
> > > s/not/now/g
> > >
> > > Cos
> > >
> > > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <
> cos@apache.org>
> > > > wrote:
> > > >
> > > > Thanks - that's great: not I'd be able to finish up the
> commenting
> > > part of the patch validation!
> > > >
> > > > Cos, I think some meaning was lost due to typos. Do you mean that
> you
> > > will
> > > > be able to finish it or will not?
> > > >
> > > > Cos
> > > >
> > > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > > >A A Hello Konstantin.
> > > > >A A I've installed lira-cli on all agents (7) - path of cli
> is
> > > > >A A /opt/jira-cli-3.9.0
> > > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > > <co...@apache.org>
> > > > >A A wrote:
>
Re: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
Hi Yakov.
With jira-cli 3.9 one doesn't need to install anything on the server side. The
older version of the tools work with JIRA backend. The newer version (not
produced by Atlassian anymore) requires some additional stuff to be set.
I will take a look at the agents' configuration later in the day and will get
back to you here.
Thanks,
Cos
On Tue, Apr 28, 2015 at 01:40PM, Yakov Zhdanov wrote:
> Cos,
>
> We still have problem while applying patch on TC. Attachments and comments
> cannot be fetched from Jira when using jira-cli on current agents.
>
> Can you please make sure that server side of jira-cli is properly
> installed? Do you know any other way to fetch that?
>
> --Yakov
>
> 2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
>
> > oops
> >
> > s/not/now/g
> >
> > Cos
> >
> > On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <co...@apache.org>
> > > wrote:
> > >
> > > Thanks - that's great: not I'd be able to finish up the commenting
> > part of the patch validation!
> > >
> > > Cos, I think some meaning was lost due to typos. Do you mean that you
> > will
> > > be able to finish it or will not?
> > >
> > > Cos
> > >
> > > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > > >A A Hello Konstantin.
> > > >A A I've installed lira-cli on all agents (7) - path of cli is
> > > >A A /opt/jira-cli-3.9.0
> > > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > > <co...@apache.org>
> > > >A A wrote:
Re: automatic patch validation on TC
Posted by Yakov Zhdanov <yz...@apache.org>.
Cos,
We still have problem while applying patch on TC. Attachments and comments
cannot be fetched from Jira when using jira-cli on current agents.
Can you please make sure that server side of jira-cli is properly
installed? Do you know any other way to fetch that?
--Yakov
2015-04-01 6:23 GMT+03:00 Konstantin Boudnik <co...@apache.org>:
> oops
>
> s/not/now/g
>
> Cos
>
> On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> > On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <co...@apache.org>
> > wrote:
> >
> > Thanks - that's great: not I'd be able to finish up the commenting
> part
> > of the
> > patch validation!
> >
> > Cos, I think some meaning was lost due to typos. Do you mean that you
> will
> > be able to finish it or will not?
> > A
> >
> > Cos
> >
> > On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > >A A Hello Konstantin.
> > >A A I've installed lira-cli on all agents (7) - path of cli is
> > >A A /opt/jira-cli-3.9.0
> > >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> > <co...@apache.org>
> > >A A wrote:
> > >
> > >A A A I believe this is a different jira cli tools. The one I am
> > using is 100%
> > >A A A java
> > >A A A - no Python nonsense (god forbids). I am talking about
> this
> > particular
> > >A A A version
> > >
> > >A A A A
> > >A A A
> >
> https://bobswift.atlassian.net/wiki/download/attachments/16285777/jira-cli-3.9.0-distribution.zip?version=1&modificationDate=1401618313091&api=v2
> > >
> > >A A A It seems to be the last official atlassian version of the
> > tools that
> > >A A A still
> > >A A A works with out-of-stock JIRA server. Can we get it
> installed?
> > >
> > >A A A Thanks,
> > >A A A AA Cos
> > >A A A On Wed, Mar 25, 2015 at 11:15AM, Sergey Bachinskiy wrote:
> > >A A A >AA AA Hello Konstantin!
> > >A A A >AA AA As I've seen jira cli tools need python 2.7 to
> run?
> > >A A A >AA AA Should we have jira-cli on all build nodes?
> > >A A A >AA AA On Wed, Mar 25, 2015 at 1:07 AM, Dmitriy
> Setrakyan
> > >A A A <ds...@apache.org>
> > >A A A >AA AA wrote:
> > >A A A >
> > >A A A >AA AA AA Sergey B (CC'ed) is admitting these boxes.
> > Sergey, can you
> > >A A A please
> > >A A A >AA AA AA respond here?
> > >A A A >AA AA AA D.
> > >A A A >AA AA AA On Tue, Mar 24, 2015 at 3:03 PM, Konstantin
> > Boudnik
> > >A A A <co...@apache.org>
> > >A A A >AA AA AA wrote:
> > >A A A >
> > >A A A >AA AA AA AA Guys,
> > >A A A >
> > >A A A >AA AA AA AA is there any chance we can add jira-cli
> tools
> > to the TC
> > >A A A agent nodes?
> > >A A A >AA AA AA AA It seems
> > >A A A >AA AA AA AA that OAuth setup doesn't move anywhere
> yet
> > and I want to
> > >A A A finish this
> > >A A A >AA AA AA AA patch
> > >A A A >AA AA AA AA validation work ASAP. jira-cli tools
> allow an
> > external
> > >A A A process to
> > >A A A >AA AA AA AA comm. with
> > >A A A >AA AA AA AA JIRA without any fancy SOAP/REST stuff.
> > >A A A >
> > >A A A >AA AA AA AA Can anyone who's admin'ing these boxes
> ping
> > me off-line so
> > >A A A we can
> > >A A A >AA AA AA AA complete it?
> > >A A A >
> > >A A A >AA AA AA AA Thanks,
> > >A A A >AA AA AA AA AAA Cos
> > >A A A >
> > >A A A >AA AA AA AA On Sat, Feb 28, 2015 at 05:22AM,
> Konstantin
> > Boudnik wrote:
> > >A A A >AA AA AA AA > Y'all
> > >A A A >AA AA AA AA >
> > >A A A >AA AA AA AA > I have put together an initial version
> of
> > the TC job that
> > >A A A pulls in
> > >A A A >AA AA AA AA JIRAs in PA
> > >A A A >AA AA AA AA > state and find the latest attachment by
> > date. It also
> > >A A A creates and
> > >A A A >AA AA AA AA artifact
> > >A A A >AA AA AA AA > where all earlier processed
> attachments are
> > listed to
> > >A A A avoid
> > >A A A >AA AA AA AA duplicated
> > >A A A >AA AA AA AA > test runs. The job is here
> > >A A A >AA AA AA AA >A
> > >A A A >AA AA AA AA A
> > >A A A
> >
> http://204.14.53.152/viewType.html?buildTypeId=Ignite_PatchValidation_Main
> > >A A A >AA AA AA AA >
> > >A A A >AA AA AA AA > Now, I need some advice from TC
> experts, as
> > I have no
> > >A A A experience
> > >A A A >AA AA AA AA with it,
> > >A A A >AA AA AA AA > really. The issue I have as this
> (perhaps,
> > coming from my
> > >A A A ignorance
> > >A A A >AA AA AA AA about TC):
> > >A A A >AA AA AA AA >AAA 1. it seems that TC builds can be
> > triggered by
> > >A A A creating a special
> > >A A A >AA AA AA AA remote
> > >A A A >AA AA AA AA >AAA AAA A branch in git. That would
> > require a job to do
> > >A A A pushed to the
> > >A A A >AA AA AA AA git, which I
> > >A A A >AA AA AA AA >AAA AAA A am no fan of...
> > >A A A >AA AA AA AA >AAA 2. there might be a way to use some
> > sort of
> > >A A A meta-runner that can
> > >A A A >AA AA AA AA fetch the
> > >A A A >AA AA AA AA >AAA AAA A repo, create a branch using
> > provided patch, and
> > >A A A then trigger
> > >A A A >AA AA AA AA the test-run.
> > >A A A >AA AA AA AA >AAA AAA A I have no idea how to do it.
> > >A A A >AA AA AA AA >AAA 3. Some other unknown-unknown
> > functionality, that I am
> > >A A A evidently
> > >A A A >AA AA AA AA missing?
> > >A A A >AA AA AA AA >
> > >A A A >AA AA AA AA > I would really like someone on this
> list
> > with TC
> > >A A A expertise to tell
> > >A A A >AA AA AA AA me what's
> > >A A A >AA AA AA AA > the preferred way of performing such
> > workflow? E.g. in
> > >A A A Jenkins I can
> > >A A A >AA AA AA AA trigger a
> > >A A A >AA AA AA AA > remote job with a parameter (JIRA #),
> which
> > then will
> > >A A A download the
> > >A A A >AA AA AA AA latest
> > >A A A >AA AA AA AA > attachment from it (7 lines of Groovy),
> > apply it to the
> > >A A A fresh repo
> > >A A A >AA AA AA AA clone and
> > >A A A >AA AA AA AA > run the tests. How we can do something
> like
> > that in TC?
> > >A A A Looking for
> > >A A A >AA AA AA AA the
> > >A A A >AA AA AA AA > guidance and help from this list.
> > >A A A >AA AA AA AA >
> > >A A A >AA AA AA AA > --
> > >A A A >AA AA AA AA > Thanks in advance. Regards,
> > >A A A >AA AA AA AA >AAA A Cos
> > >A A A >AA AA AA AA >
>
Re: automatic patch validation on TC
Posted by Konstantin Boudnik <co...@apache.org>.
oops
s/not/now/g
Cos
On Tue, Mar 31, 2015 at 06:58PM, Dmitriy Setrakyan wrote:
> On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <co...@apache.org>
> wrote:
>
> Thanks - that's great: not I'd be able to finish up the commenting part
> of the
> patch validation!
>
> Cos, I think some meaning was lost due to typos. Do you mean that you will
> be able to finish it or will not?
> A
>
> Cos
>
> On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> >A A Hello Konstantin.
> >A A I've installed lira-cli on all agents (7) - path of cli is
> >A A /opt/jira-cli-3.9.0
> >A A On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik
> <co...@apache.org>
> >A A wrote:
> >
> >A A A I believe this is a different jira cli tools. The one I am
> using is 100%
> >A A A java
> >A A A - no Python nonsense (god forbids). I am talking about this
> particular
> >A A A version
> >
> >A A A A
> >A A A
> https://bobswift.atlassian.net/wiki/download/attachments/16285777/jira-cli-3.9.0-distribution.zip?version=1&modificationDate=1401618313091&api=v2
> >
> >A A A It seems to be the last official atlassian version of the
> tools that
> >A A A still
> >A A A works with out-of-stock JIRA server. Can we get it installed?
> >
> >A A A Thanks,
> >A A A AA Cos
> >A A A On Wed, Mar 25, 2015 at 11:15AM, Sergey Bachinskiy wrote:
> >A A A >AA AA Hello Konstantin!
> >A A A >AA AA As I've seen jira cli tools need python 2.7 to run?
> >A A A >AA AA Should we have jira-cli on all build nodes?
> >A A A >AA AA On Wed, Mar 25, 2015 at 1:07 AM, Dmitriy Setrakyan
> >A A A <ds...@apache.org>
> >A A A >AA AA wrote:
> >A A A >
> >A A A >AA AA AA Sergey B (CC'ed) is admitting these boxes.
> Sergey, can you
> >A A A please
> >A A A >AA AA AA respond here?
> >A A A >AA AA AA D.
> >A A A >AA AA AA On Tue, Mar 24, 2015 at 3:03 PM, Konstantin
> Boudnik
> >A A A <co...@apache.org>
> >A A A >AA AA AA wrote:
> >A A A >
> >A A A >AA AA AA AA Guys,
> >A A A >
> >A A A >AA AA AA AA is there any chance we can add jira-cli tools
> to the TC
> >A A A agent nodes?
> >A A A >AA AA AA AA It seems
> >A A A >AA AA AA AA that OAuth setup doesn't move anywhere yet
> and I want to
> >A A A finish this
> >A A A >AA AA AA AA patch
> >A A A >AA AA AA AA validation work ASAP. jira-cli tools allow an
> external
> >A A A process to
> >A A A >AA AA AA AA comm. with
> >A A A >AA AA AA AA JIRA without any fancy SOAP/REST stuff.
> >A A A >
> >A A A >AA AA AA AA Can anyone who's admin'ing these boxes ping
> me off-line so
> >A A A we can
> >A A A >AA AA AA AA complete it?
> >A A A >
> >A A A >AA AA AA AA Thanks,
> >A A A >AA AA AA AA AAA Cos
> >A A A >
> >A A A >AA AA AA AA On Sat, Feb 28, 2015 at 05:22AM, Konstantin
> Boudnik wrote:
> >A A A >AA AA AA AA > Y'all
> >A A A >AA AA AA AA >
> >A A A >AA AA AA AA > I have put together an initial version of
> the TC job that
> >A A A pulls in
> >A A A >AA AA AA AA JIRAs in PA
> >A A A >AA AA AA AA > state and find the latest attachment by
> date. It also
> >A A A creates and
> >A A A >AA AA AA AA artifact
> >A A A >AA AA AA AA > where all earlier processed attachments are
> listed to
> >A A A avoid
> >A A A >AA AA AA AA duplicated
> >A A A >AA AA AA AA > test runs. The job is here
> >A A A >AA AA AA AA >A
> >A A A >AA AA AA AA A
> >A A A
> http://204.14.53.152/viewType.html?buildTypeId=Ignite_PatchValidation_Main
> >A A A >AA AA AA AA >
> >A A A >AA AA AA AA > Now, I need some advice from TC experts, as
> I have no
> >A A A experience
> >A A A >AA AA AA AA with it,
> >A A A >AA AA AA AA > really. The issue I have as this (perhaps,
> coming from my
> >A A A ignorance
> >A A A >AA AA AA AA about TC):
> >A A A >AA AA AA AA >AAA 1. it seems that TC builds can be
> triggered by
> >A A A creating a special
> >A A A >AA AA AA AA remote
> >A A A >AA AA AA AA >AAA AAA A branch in git. That would
> require a job to do
> >A A A pushed to the
> >A A A >AA AA AA AA git, which I
> >A A A >AA AA AA AA >AAA AAA A am no fan of...
> >A A A >AA AA AA AA >AAA 2. there might be a way to use some
> sort of
> >A A A meta-runner that can
> >A A A >AA AA AA AA fetch the
> >A A A >AA AA AA AA >AAA AAA A repo, create a branch using
> provided patch, and
> >A A A then trigger
> >A A A >AA AA AA AA the test-run.
> >A A A >AA AA AA AA >AAA AAA A I have no idea how to do it.
> >A A A >AA AA AA AA >AAA 3. Some other unknown-unknown
> functionality, that I am
> >A A A evidently
> >A A A >AA AA AA AA missing?
> >A A A >AA AA AA AA >
> >A A A >AA AA AA AA > I would really like someone on this list
> with TC
> >A A A expertise to tell
> >A A A >AA AA AA AA me what's
> >A A A >AA AA AA AA > the preferred way of performing such
> workflow? E.g. in
> >A A A Jenkins I can
> >A A A >AA AA AA AA trigger a
> >A A A >AA AA AA AA > remote job with a parameter (JIRA #), which
> then will
> >A A A download the
> >A A A >AA AA AA AA latest
> >A A A >AA AA AA AA > attachment from it (7 lines of Groovy),
> apply it to the
> >A A A fresh repo
> >A A A >AA AA AA AA clone and
> >A A A >AA AA AA AA > run the tests. How we can do something like
> that in TC?
> >A A A Looking for
> >A A A >AA AA AA AA the
> >A A A >AA AA AA AA > guidance and help from this list.
> >A A A >AA AA AA AA >
> >A A A >AA AA AA AA > --
> >A A A >AA AA AA AA > Thanks in advance. Regards,
> >A A A >AA AA AA AA >AAA A Cos
> >A A A >AA AA AA AA >
Re: automatic patch validation on TC
Posted by Dmitriy Setrakyan <ds...@apache.org>.
On Tue, Mar 31, 2015 at 6:54 PM, Konstantin Boudnik <co...@apache.org> wrote:
> Thanks - that's great: not I'd be able to finish up the commenting part of
> the
> patch validation!
>
Cos, I think some meaning was lost due to typos. Do you mean that you will
be able to finish it or will not?
>
> Cos
>
> On Wed, Apr 01, 2015 at 12:00AM, Sergey Bachinskiy wrote:
> > Hello Konstantin.
> > I've installed lira-cli on all agents (7) - path of cli is
> > /opt/jira-cli-3.9.0
> > On Wed, Mar 25, 2015 at 10:16 PM, Konstantin Boudnik <co...@apache.org>
> > wrote:
> >
> > I believe this is a different jira cli tools. The one I am using is
> 100%
> > java
> > - no Python nonsense (god forbids). I am talking about this
> particular
> > version
> >
> > A
> >
> https://bobswift.atlassian.net/wiki/download/attachments/16285777/jira-cli-3.9.0-distribution.zip?version=1&modificationDate=1401618313091&api=v2
> >
> > It seems to be the last official atlassian version of the tools that
> > still
> > works with out-of-stock JIRA server. Can we get it installed?
> >
> > Thanks,
> > A Cos
> > On Wed, Mar 25, 2015 at 11:15AM, Sergey Bachinskiy wrote:
> > >A A Hello Konstantin!
> > >A A As I've seen jira cli tools need python 2.7 to run?
> > >A A Should we have jira-cli on all build nodes?
> > >A A On Wed, Mar 25, 2015 at 1:07 AM, Dmitriy Setrakyan
> > <ds...@apache.org>
> > >A A wrote:
> > >
> > >A A A Sergey B (CC'ed) is admitting these boxes. Sergey, can you
> > please
> > >A A A respond here?
> > >A A A D.
> > >A A A On Tue, Mar 24, 2015 at 3:03 PM, Konstantin Boudnik
> > <co...@apache.org>
> > >A A A wrote:
> > >
> > >A A A A Guys,
> > >
> > >A A A A is there any chance we can add jira-cli tools to the TC
> > agent nodes?
> > >A A A A It seems
> > >A A A A that OAuth setup doesn't move anywhere yet and I want
> to
> > finish this
> > >A A A A patch
> > >A A A A validation work ASAP. jira-cli tools allow an external
> > process to
> > >A A A A comm. with
> > >A A A A JIRA without any fancy SOAP/REST stuff.
> > >
> > >A A A A Can anyone who's admin'ing these boxes ping me
> off-line so
> > we can
> > >A A A A complete it?
> > >
> > >A A A A Thanks,
> > >A A A A AA Cos
> > >
> > >A A A A On Sat, Feb 28, 2015 at 05:22AM, Konstantin Boudnik
> wrote:
> > >A A A A > Y'all
> > >A A A A >
> > >A A A A > I have put together an initial version of the TC job
> that
> > pulls in
> > >A A A A JIRAs in PA
> > >A A A A > state and find the latest attachment by date. It also
> > creates and
> > >A A A A artifact
> > >A A A A > where all earlier processed attachments are listed to
> > avoid
> > >A A A A duplicated
> > >A A A A > test runs. The job is here
> > >A A A A >A
> > >A A A A A
> >
> http://204.14.53.152/viewType.html?buildTypeId=Ignite_PatchValidation_Main
> > >A A A A >
> > >A A A A > Now, I need some advice from TC experts, as I have no
> > experience
> > >A A A A with it,
> > >A A A A > really. The issue I have as this (perhaps, coming
> from my
> > ignorance
> > >A A A A about TC):
> > >A A A A >AA 1. it seems that TC builds can be triggered by
> > creating a special
> > >A A A A remote
> > >A A A A >AA AA A branch in git. That would require a job to
> do
> > pushed to the
> > >A A A A git, which I
> > >A A A A >AA AA A am no fan of...
> > >A A A A >AA 2. there might be a way to use some sort of
> > meta-runner that can
> > >A A A A fetch the
> > >A A A A >AA AA A repo, create a branch using provided patch,
> and
> > then trigger
> > >A A A A the test-run.
> > >A A A A >AA AA A I have no idea how to do it.
> > >A A A A >AA 3. Some other unknown-unknown functionality, that
> I am
> > evidently
> > >A A A A missing?
> > >A A A A >
> > >A A A A > I would really like someone on this list with TC
> > expertise to tell
> > >A A A A me what's
> > >A A A A > the preferred way of performing such workflow? E.g.
> in
> > Jenkins I can
> > >A A A A trigger a
> > >A A A A > remote job with a parameter (JIRA #), which then will
> > download the
> > >A A A A latest
> > >A A A A > attachment from it (7 lines of Groovy), apply it to
> the
> > fresh repo
> > >A A A A clone and
> > >A A A A > run the tests. How we can do something like that in
> TC?
> > Looking for
> > >A A A A the
> > >A A A A > guidance and help from this list.
> > >A A A A >
> > >A A A A > --
> > >A A A A > Thanks in advance. Regards,
> > >A A A A >AA A Cos
> > >A A A A >
>