[GitHub] [hudi] umehrot2 commented on a change in pull request #3956: [HUDI-2641] Avoid deleting all inflight commits heartbeats while rolling back failed writes

[GitBox <gi...@apache.org>]

umehrot2 commented on a change in pull request #3956:
URL: https://github.com/apache/hudi/pull/3956#discussion_r750831473



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -856,13 +856,9 @@ protected void rollbackFailedWrites(List<String> instantsToRollback, boolean ski
       } else {
         rollback(instant, skipLocking);
       }
-    }
-    // Delete any heartbeat files for already rolled back commits
-    try {
-      HeartbeatUtils.cleanExpiredHeartbeats(this.heartbeatClient.getAllExistingHeartbeatInstants(),

Review comment:
       The function is unused and not really useful at all.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org