[GitHub] [iceberg] kbendick commented on a diff in pull request #4929: Improve binary pack/unpack performance using cached struct

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4929:
URL: https://github.com/apache/iceberg/pull/4929#discussion_r887069062


##########
python/src/iceberg/conversions.py:
##########
@@ -53,6 +53,13 @@
 from iceberg.utils.decimal import decimal_to_bytes, unscaled_to_decimal
 
 
+_bool_struct = Struct("<?")

Review Comment:
   I would personally still think of it as a constant regardless of complexity, but I agree so long as they're not used outside of this file that's the more important thing to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org