You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/17 20:28:40 UTC
[GitHub] [beam] pabloem opened a new pull request, #23678: Deflaking tests for BQ row insertions. These tests were flaky due to …
pabloem opened a new pull request, #23678:
URL: https://github.com/apache/beam/pull/23678
…race conditions against expected results
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23678: Deflaking tests for BQ row insertions. These tests were flaky due to …
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23678:
URL: https://github.com/apache/beam/pull/23678#issuecomment-1282787093
failed test is unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23678: Deflaking tests for BQ row insertions. These tests were flaky due to …
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23678:
URL: https://github.com/apache/beam/pull/23678#issuecomment-1282760840
This Fixes #22743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #23678: Deflaking tests for BQ row insertions. These tests were flaky due to …
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #23678:
URL: https://github.com/apache/beam/pull/23678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23678: Deflaking tests for BQ row insertions. These tests were flaky due to …
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23678:
URL: https://github.com/apache/beam/pull/23678#issuecomment-1282815122
I wouldn't say there's a concurrency problem. the only issue here is the way teh test works imo. we have plenty of integration and unit tests for this, so I don't feel very conflicted...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23678: Deflaking tests for BQ row insertions. These tests were flaky due to …
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23678:
URL: https://github.com/apache/beam/pull/23678#issuecomment-1281454092
r: @kennknowles - I've run this test over 100 times and observed no failures. I believe this is good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23678: Deflaking tests for BQ row insertions. These tests were flaky due to …
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23678:
URL: https://github.com/apache/beam/pull/23678#issuecomment-1281480084
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org