[GitHub] [lucene-solr] madrob opened a new pull request #2264: Require Thread Names in Solr

[GitBox <gi...@apache.org>]

madrob opened a new pull request #2264:
URL: https://github.com/apache/lucene-solr/pull/2264


   When we are creating a new thread we should give it a name. This doesn't apply to Runnable or Callable objects that we pass to an executor, since those should be getting named by the executor itself.
   
   Also, enforce forbidden APIs on the code. I didn't apply the rule to tests because there's so many of them and I think there is less value in the constraint.
   
   This is especially helpful when doing profiling, otherwise we end up with a bunch of Thread-# that are hard to tell apart and search on.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] madrob merged pull request #2264: Require Thread Names in Solr

[GitBox <gi...@apache.org>]

madrob merged pull request #2264:
URL: https://github.com/apache/lucene-solr/pull/2264


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org