[incubator-nlpcraft] branch NLPCRAFT-483 updated: EN adapters added.

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sergeykamov pushed a commit to branch NLPCRAFT-483
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git


The following commit(s) were added to refs/heads/NLPCRAFT-483 by this push:
     new 315ec01  EN adapters added.
315ec01 is described below

commit 315ec01534224b54b7ad5bf2cc9fa40b845b82b2
Author: Sergey Kamov <sk...@gmail.com>
AuthorDate: Fri Feb 25 18:54:51 2022 +0300

    EN adapters added.
---
 .../org/apache/nlpcraft/nlp/NCENDefaultPipeline.java | 20 ++++++++++----------
 .../nlpcraft/nlp/NCENSemanticEntityParser.java       |  2 +-
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENDefaultPipeline.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENDefaultPipeline.java
index d679ed9..c504e78 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENDefaultPipeline.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENDefaultPipeline.java
@@ -34,12 +34,13 @@ import java.util.Collections;
 import java.util.List;
 
 /**
- *
+ * Default EN implementation based on Open Nlp token parser, and set of built token enrichers including stopword enricher.
+ * Also at least one entity parser must be defined.
  */
 public class NCENDefaultPipeline implements NCModelPipeline {
     private static final NCResourceReader reader = new NCResourceReader();
 
-    private final NCTokenParser tp = new NCOpenNLPTokenParser(
+    private final NCTokenParser tokParser = new NCOpenNLPTokenParser(
         reader.getPath("opennlp/en-token.bin"),
         reader.getPath("opennlp/en-pos-maxent.bin"),
         reader.getPath("opennlp/en-lemmatizer.dict")
@@ -51,17 +52,16 @@ public class NCENDefaultPipeline implements NCModelPipeline {
         new NCQuotesTokenEnricher(),
         new NCDictionaryTokenEnricher(),
         new NCBracketsTokenEnricher()
-
     );
 
-    private final List<NCEntityParser> parsers;
+    private final List<NCEntityParser> entParsers;
 
     /**
      *
-     * @param parsers
+     * @param entParsers
      */
-    public NCENDefaultPipeline(List<NCEntityParser> parsers) {
-        this.parsers = parsers;
+    public NCENDefaultPipeline(List<NCEntityParser> entParsers) {
+        this.entParsers = entParsers;
     }
 
     /**
@@ -69,17 +69,17 @@ public class NCENDefaultPipeline implements NCModelPipeline {
      * @param parser
      */
     public NCENDefaultPipeline(NCEntityParser parser) {
-        this.parsers = Collections.singletonList(parser);
+        this.entParsers = Collections.singletonList(parser);
     }
 
     @Override
     public NCTokenParser getTokenParser() {
-        return tp;
+        return tokParser;
     }
 
     @Override
     public List<NCEntityParser> getEntityParsers() {
-        return parsers;
+        return entParsers;
     }
 
     @Override
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENSemanticEntityParser.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENSemanticEntityParser.java
index 9a099dd..7cf3d55 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENSemanticEntityParser.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/nlp/NCENSemanticEntityParser.java
@@ -29,7 +29,7 @@ import java.util.List;
 import java.util.Map;
 
 /**
- *
+ * Wrapper on {@link NCSemanticEntityParser} which uses Open Nlp token parser (same as {@link NCENDefaultPipeline}) and built EN stemmer.
  */
 public class NCENSemanticEntityParser extends NCSemanticEntityParser {
     private static final NCResourceReader reader = new NCResourceReader();