You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/19 20:31:10 UTC

[GitHub] [maven] rfscholte commented on a change in pull request #489: [MNG-6271] Add validationRule for expressions in repositoryUrl

rfscholte commented on a change in pull request #489:
URL: https://github.com/apache/maven/pull/489#discussion_r672609882



##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -70,7 +70,7 @@
     implements ModelValidator
 {
 
-    private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile( "\\$\\{(.+?)\\}" );
+    private static final Pattern EXPRESSION_NAME = Pattern.compile( "\\$\\{(.+?)\\}" );

Review comment:
       The first group is the expression name, which is always the thing you're interested in.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org