[GitHub] [iceberg] rdblue commented on a diff in pull request #4903: Spark: Use options as a CaseSensitiveMap

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4903:
URL: https://github.com/apache/iceberg/pull/4903#discussion_r889748605


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -119,7 +119,7 @@ public class SparkCatalog extends BaseCatalog {
   protected Catalog buildIcebergCatalog(String name, CaseInsensitiveStringMap options) {
     Configuration conf = SparkUtil.hadoopConfCatalogOverrides(SparkSession.active(), name);
     Map<String, String> optionsMap = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
-    optionsMap.putAll(options);
+    optionsMap.putAll(options.asCaseSensitiveMap());

Review Comment:
   Got it. So this passes the original case for when we extract the keys. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org