You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/17 02:57:00 UTC

[GitHub] [superset] diegomedina248 commented on a change in pull request #19138: fix: Remove gap from SQLLab results bottom

diegomedina248 commented on a change in pull request #19138:
URL: https://github.com/apache/superset/pull/19138#discussion_r828712178



##########
File path: superset-frontend/src/SqlLab/components/SouthPane/index.tsx
##########
@@ -152,7 +154,7 @@ export default function SouthPane({
             query={latestQuery}
             actions={actions}
             user={user}
-            height={innerTabContentHeight}
+            height={innerTabContentHeight + EXTRA_HEIGHT_RESULTS}

Review comment:
       @evans we should add a story to rework these components, as they should use flexbox instead of manually calculating heights




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org