[GitHub] [spark] HyukjinKwon commented on a change in pull request #29927: [SPARK-33048][BUILD] Fix SparkBuild.scala to recognize build settings for Scala 2.13

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #29927:
URL: https://github.com/apache/spark/pull/29927#discussion_r498631655



##########
File path: project/SparkBuild.scala
##########
@@ -94,21 +94,6 @@ object SparkBuild extends PomBuild {
       case Some(v) =>
         v.split("(\\s+|,)").filterNot(_.isEmpty).map(_.trim.replaceAll("-P", "")).toSeq
     }
-
-    // TODO: revisit for Scala 2.13 support
-    /*
-    Option(System.getProperty("scala.version"))
-      .filter(_.startsWith("2.11"))
-      .foreach { versionString =>
-        System.setProperty("scala-2.11", "true")
-      }
-    if (System.getProperty("scala-2.11") == "") {
-      // To activate scala-2.10 profile, replace empty property value to non-empty value
-      // in the same way as Maven which handles -Dname as -Dname=true before executes build process.

Review comment:
       @sarutak, did you check Maven build too?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org