You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 03:53:37 UTC
[GitHub] [doris] wangshuo128 commented on a diff in pull request #14863: [Feature](Nereids) Support bitmap for materialized index.
wangshuo128 commented on code in PR #14863:
URL: https://github.com/apache/doris/pull/14863#discussion_r1053958360
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/Command.java:
##########
@@ -83,6 +83,11 @@ default List<Slot> getOutput() {
throw new RuntimeException("Command do not implement getOutput");
}
+ @Override
+ default List<Slot> getNonUserVisibleOutput() {
+ throw new RuntimeException("Command do not implement getNonUserVisibleOutput");
Review Comment:
I think both choices are Ok. Just keep consistent with `Command.getOutput`.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/Command.java:
##########
@@ -83,6 +83,11 @@ default List<Slot> getOutput() {
throw new RuntimeException("Command do not implement getOutput");
}
+ @Override
+ default List<Slot> getNonUserVisibleOutput() {
+ throw new RuntimeException("Command do not implement getNonUserVisibleOutput");
Review Comment:
I think both choices are ok. Just keep consistent with `Command.getOutput`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org