[jira] [Commented] (CASSANDRA-15297) nodetool can not create snapshot with snapshot name that have special character

["Benjamin Lerer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485244#comment-17485244 ] 

Benjamin Lerer commented on CASSANDRA-15297:
--------------------------------------------

[~saranya_k] on 4.0 some of the new tests are failing [here|https://app.circleci.com/pipelines/github/blerer/cassandra/257/workflows/4f2fec7f-41ed-4863-ae0a-e2c2404a38d1/jobs/2333] and the {{File}} import used for the {{File.separator}} is making the build fail. [~samt], [~benedict] do you know what should be use to avoid this problem ?  

> nodetool can not create snapshot with snapshot name that have special character
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15297
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15297
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/nodetool
>            Reporter: maxwellguo
>            Assignee: Saranya Krishnakumar
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.x
>
>         Attachments: after-fix.jpg, image.png, listsnapshots-p-s.jpg, snapshot-listsnapshot-.jpg, snapshot-p-s.jpg
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> we make snapshot through "nodetool snapshot -t snapshotname " , when snapshotname contains special characters like "/", the make snapshot process successfully , but the result 
> can be different ,when we check the data file directory or use "nodetool listsnapshots".
> here is some case :
> 1. nodetool snapshot -t "p/s"
> the listsnapshot resturns snapshot  p for all table but actually the snapshot name is "p/s";
> also the data directory is like the format : datapath/snapshots/p/s/snapshot-datafile-link
>   !snapshot-p-s.jpg! 
>  !listsnapshots-p-s.jpg! 
> 2. nodetool snapshot -t "/"
> the listsnapshot resturns "there is not snapshot"; but the make snapshot process return successfully and the data directory is like the format : datapath/snapshots/snapshot-datafile-link
>  !snapshot-listsnapshot-.jpg! 
> the Attachements are the result under our environment.
> so for me , we suggest that the snapshot name should not contains special character. just throw exception and told the user not to use  special character.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org