You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/04/21 13:33:26 UTC
[GitHub] [superset] kgabryje opened a new pull request, #23768: feat: Display both queries result in Table mode for Mixed Chart in drill by modal
kgabryje opened a new pull request, #23768:
URL: https://github.com/apache/superset/pull/23768
### SUMMARY
This PR enables displaying result tables for both queries of Mixed Chart in Table mode in drill by modal
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1707" alt="image" src="https://user-images.githubusercontent.com/15073128/233638181-8a8414ac-8d81-439b-977d-cb731375b1a1.png">
After:
<img width="1709" alt="image" src="https://user-images.githubusercontent.com/15073128/233638255-77878c97-bf0b-40df-9db7-215a413b506c.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #23768: feat: Display both queries result in Table mode for Mixed Chart in drill by modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #23768:
URL: https://github.com/apache/superset/pull/23768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23768: feat: Display both queries result in Table mode for Mixed Chart in drill by modal
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23768:
URL: https://github.com/apache/superset/pull/23768#issuecomment-1517927091
## [Codecov](https://codecov.io/gh/apache/superset/pull/23768?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23768](https://codecov.io/gh/apache/superset/pull/23768?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04363df) into [master](https://codecov.io/gh/apache/superset/commit/764c3c95cf3be732b50a17282d510b03beddca0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (764c3c9) will **increase** coverage by `0.00%`.
> The diff coverage is `91.66%`.
> :exclamation: Current head 04363df differs from pull request most recent head 210c0b1. Consider uploading reports for the commit 210c0b1 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23768 +/- ##
=======================================
Coverage 67.87% 67.87%
=======================================
Files 1924 1925 +1
Lines 74381 74387 +6
Branches 8106 8108 +2
=======================================
+ Hits 50486 50492 +6
Misses 21818 21818
Partials 2077 2077
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.10% <91.66%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/src/components/Chart/DrillBy/DrillByModal.tsx](https://codecov.io/gh/apache/superset/pull/23768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxCeS9EcmlsbEJ5TW9kYWwudHN4) | `72.54% <50.00%> (-0.53%)` | :arrow_down: |
| [...c/components/Chart/DrillBy/useResultsTableView.tsx](https://codecov.io/gh/apache/superset/pull/23768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxCeS91c2VSZXN1bHRzVGFibGVWaWV3LnRzeA==) | `100.00% <100.00%> (ø)` | |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23768/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org