You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/01 00:00:53 UTC

[GitHub] [airflow] coufon opened a new pull request #5701: [AIRFLOW-5088] Add DAG serialization using JSON

coufon opened a new pull request #5701: [AIRFLOW-5088] Add DAG serialization using JSON
URL: https://github.com/apache/airflow/pull/5701
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira 5088](https://issues.apache.org/jira/browse/AIRFLOW-5088)
     - AIP-24: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-24+DAG+Persistence+in+DB+using+JSON+for+Airflow+Webserver+and+%28optional%29+Scheduler
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   It implements the method proposed in [AIP-24](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-24+DAG+Persistence+in+DB+using+JSON+for+Airflow+Webserver+and+%28optional%29+Scheduler) to serialize DAG. It will be used in DAG persistency in DB to solve webserver scalability issue.
   
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
    - Unit test: tests/dags/test_dag_serialization.py for DAG serialization
   - End-to-End UI test: the usage of DAG serialization in web UI has been tested in PR https://github.com/apache/airflow/pull/5594. That PR contains the same DAG serialization code, but with an asynchronous DAG loader that use serialized DAGs in UI.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services