You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Andrey Rybin (JIRA)" <ji...@apache.org> on 2010/02/06 14:30:28 UTC

[jira] Created: (CLK-623) MockContext tightly coupled with ConsoleLogService

MockContext tightly coupled with ConsoleLogService 
---------------------------------------------------

                 Key: CLK-623
                 URL: https://issues.apache.org/jira/browse/CLK-623
             Project: Click
          Issue Type: Bug
          Components: mock
    Affects Versions: 2.1.0
            Reporter: Andrey Rybin


in MockContext initContext(MockServletConfig servletConfig,
        MockRequest request, MockResponse response, ClickServlet clickServlet,
        ActionEventDispatcher controlRegistry) { 

ConsoleLogService logService = (ConsoleLogService) ClickUtils.getLogService();
            logService.setLevel(ConsoleLogService.TRACE_LEVEL); 

should be

if (ClickUtils.getLogService() instanceof ConsoleLogService) {
ConsoleLogService logService = (ConsoleLogService) ClickUtils.getLogService();
            logService.setLevel(ConsoleLogService.TRACE_LEVEL); 
}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CLK-623) MockContext tightly coupled with ConsoleLogService

Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CLK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Schellink updated CLK-623:
------------------------------

    Affects Version/s:     (was: 2.1.0)
                       2.1.0 RC1
        Fix Version/s: 2.1.0
             Assignee: Bob Schellink

> MockContext tightly coupled with ConsoleLogService 
> ---------------------------------------------------
>
>                 Key: CLK-623
>                 URL: https://issues.apache.org/jira/browse/CLK-623
>             Project: Click
>          Issue Type: Bug
>          Components: mock
>    Affects Versions: 2.1.0 RC1
>            Reporter: Andrey Rybin
>            Assignee: Bob Schellink
>             Fix For: 2.1.0
>
>
> in MockContext initContext(MockServletConfig servletConfig,
>         MockRequest request, MockResponse response, ClickServlet clickServlet,
>         ActionEventDispatcher controlRegistry) { 
> ConsoleLogService logService = (ConsoleLogService) ClickUtils.getLogService();
>             logService.setLevel(ConsoleLogService.TRACE_LEVEL); 
> should be
> if (ClickUtils.getLogService() instanceof ConsoleLogService) {
> ConsoleLogService logService = (ConsoleLogService) ClickUtils.getLogService();
>             logService.setLevel(ConsoleLogService.TRACE_LEVEL); 
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CLK-623) MockContext tightly coupled with ConsoleLogService

Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CLK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Schellink resolved CLK-623.
-------------------------------

    Resolution: Fixed

Thanks Andrey, fix checked in against 2.1.0

> MockContext tightly coupled with ConsoleLogService 
> ---------------------------------------------------
>
>                 Key: CLK-623
>                 URL: https://issues.apache.org/jira/browse/CLK-623
>             Project: Click
>          Issue Type: Bug
>          Components: mock
>    Affects Versions: 2.1.0 RC1
>            Reporter: Andrey Rybin
>            Assignee: Bob Schellink
>             Fix For: 2.1.0
>
>
> in MockContext initContext(MockServletConfig servletConfig,
>         MockRequest request, MockResponse response, ClickServlet clickServlet,
>         ActionEventDispatcher controlRegistry) { 
> ConsoleLogService logService = (ConsoleLogService) ClickUtils.getLogService();
>             logService.setLevel(ConsoleLogService.TRACE_LEVEL); 
> should be
> if (ClickUtils.getLogService() instanceof ConsoleLogService) {
> ConsoleLogService logService = (ConsoleLogService) ClickUtils.getLogService();
>             logService.setLevel(ConsoleLogService.TRACE_LEVEL); 
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.