You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2025/10/19 03:34:25 UTC

[I] Consider folding `CoalesceAsyncExecInput` physical optimizer rule into `CoalesceBatches` [datafusion]

Jefffrey opened a new issue, #18155:
URL: https://github.com/apache/datafusion/issues/18155

   ### Is your feature request related to a problem or challenge?
   
   These are quite similar, I wonder if we can embed the logic from `CoalesceAsyncExecInput` into existing rule `CoalesceBatches` to consolidate the codebase a bit 🤔 
   
   Reference links:
   
   - [`CoalesceBatches`](https://github.com/apache/datafusion/blob/b98cad616ad9c69df9a425fc7473b799ffc258ee/datafusion/physical-optimizer/src/coalesce_batches.rs)
   - [`CoalesceAsyncExecInput`](https://github.com/apache/datafusion/blob/b98cad616ad9c69df9a425fc7473b799ffc258ee/datafusion/physical-optimizer/src/coalesce_async_exec_input.rs)
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Consider folding `CoalesceAsyncExecInput` physical optimizer rule into `CoalesceBatches` [datafusion]

Posted by "Tim-53 (via GitHub)" <gi...@apache.org>.
Tim-53 commented on issue #18155:
URL: https://github.com/apache/datafusion/issues/18155#issuecomment-3505903173

   I noticed there hasn’t been any recent activity on this issue, so I went ahead and opened PR #18540  that folds CoalesceAsyncExecInput into CoalesceBatches as proposed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Consider folding `CoalesceAsyncExecInput` physical optimizer rule into `CoalesceBatches` [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #18155:
URL: https://github.com/apache/datafusion/issues/18155#issuecomment-3419566696

   > Can you assign to me, i will work on it at the weekend
   
   Cheers! Feel free to `take` this issue as described here: https://datafusion.apache.org/contributor-guide/index.html#open-contribution-and-assigning-tickets
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Consider folding `CoalesceAsyncExecInput` physical optimizer rule into `CoalesceBatches` [datafusion]

Posted by "0xEbrahim (via GitHub)" <gi...@apache.org>.
0xEbrahim commented on issue #18155:
URL: https://github.com/apache/datafusion/issues/18155#issuecomment-3419549123

   Can you assign to me, i will work on it at the weekend


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Consider folding `CoalesceAsyncExecInput` physical optimizer rule into `CoalesceBatches` [datafusion]

Posted by "0xEbrahim (via GitHub)" <gi...@apache.org>.
0xEbrahim commented on issue #18155:
URL: https://github.com/apache/datafusion/issues/18155#issuecomment-3419569829

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Consider folding `CoalesceAsyncExecInput` physical optimizer rule into `CoalesceBatches` [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #18155: Consider folding `CoalesceAsyncExecInput` physical optimizer rule into `CoalesceBatches`
URL: https://github.com/apache/datafusion/issues/18155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org