You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 15:49:44 UTC
[GitHub] [flink] wanglijie95 opened a new pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
wanglijie95 opened a new pull request #12181:
URL: https://github.com/apache/flink/pull/12181
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This Pull Request is to fix the bug that REAPER_THREAD.start() failure in SafetyNetCloseableRegistry lead to the repeated failover, as described in [FLINK-17645](https://issues.apache.org/jira/browse/FLINK-17645)
## Brief change log
[a7df40](https://github.com/wanglijie95/flink/commit/a7df4077fb5715e0a9ce097b773f49a197eb27dd
) `Fix SafetyNetCloseableRegistry constructor bug`
## Verifying this change
Add `testReaperThreadStartFailed` in `SafetyNetCloseableRegistryTest` for this case.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37dbf5a71db743b3aaef83538be71bc5bd1a7415 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831)
* 0bf2aa2f54e22e76fed071e3c614139d4d187fc4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a73076f072352ba5539bf558f90a94572fb6c36 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510)
* b954ba073cba912b98c5992b05caec91e7657871 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97f9193f189afae6147d9d1bdd68beb132bc63ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427015357
##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
##########
@@ -186,6 +212,15 @@ private CloseableReaperThread() {
this.running = true;
}
+ @VisibleForTesting
+ CloseableReaperThread(String name) {
Review comment:
OK, I will change it to protected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
}, {
"hash" : "bd9add8e480455265ca95b863601f6608918b334",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907",
"triggerID" : "bd9add8e480455265ca95b863601f6608918b334",
"triggerType" : "PUSH"
}, {
"hash" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd9add8e480455265ca95b863601f6608918b334 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907)
* 05e0b2b0379e0b05c62631147b82711c32f11fcb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629992918
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7df4077fb5715e0a9ce097b773f49a197eb27dd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a73076f072352ba5539bf558f90a94572fb6c36 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b954ba073cba912b98c5992b05caec91e7657871 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687)
* 757a2307f027acba2aca26f7f5ec6f9639ce9079 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
}, {
"hash" : "bd9add8e480455265ca95b863601f6608918b334",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907",
"triggerID" : "bd9add8e480455265ca95b863601f6608918b334",
"triggerType" : "PUSH"
}, {
"hash" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1920",
"triggerID" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"triggerType" : "PUSH"
}, {
"hash" : "fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1930",
"triggerID" : "fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1930)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7df4077fb5715e0a9ce097b773f49a197eb27dd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a73076f072352ba5539bf558f90a94572fb6c36 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510)
* b954ba073cba912b98c5992b05caec91e7657871 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b954ba073cba912b98c5992b05caec91e7657871 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r426389591
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -198,4 +211,27 @@ public void testReaperThreadSpawnAndStop() throws Exception {
}
Assert.assertFalse(SafetyNetCloseableRegistry.isReaperThreadRunning());
}
+
+ /**
+ * Test for FLINK-17645.
Review comment:
I got it. I will delete this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757a2307f027acba2aca26f7f5ec6f9639ce9079 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427010925
##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
##########
@@ -73,8 +73,34 @@
synchronized (REAPER_THREAD_LOCK) {
if (0 == GLOBAL_SAFETY_NET_REGISTRY_COUNT) {
Preconditions.checkState(null == REAPER_THREAD);
- REAPER_THREAD = new CloseableReaperThread();
- REAPER_THREAD.start();
+ try {
+ REAPER_THREAD = new CloseableReaperThread();
+ REAPER_THREAD.start();
+ } catch (Throwable throwable) {
+ // thread create or start error.
+ REAPER_THREAD = null;
+ throw throwable;
+ }
+ }
+ ++GLOBAL_SAFETY_NET_REGISTRY_COUNT;
+ }
+ }
+
+ @VisibleForTesting
+ SafetyNetCloseableRegistry(CloseableReaperThread reaperThread) {
Review comment:
We should avoid duplicating the codes.
Below is a possible way to make it.
```
SafetyNetCloseableRegistry() {
this(() -> new CloseableReaperThread());
}
@VisibleForTesting
SafetyNetCloseableRegistry(Supplier<CloseableReaperThread> reaperThreadSupplier) {
super(new IdentityHashMap<>());
synchronized (REAPER_THREAD_LOCK) {
if (0 == GLOBAL_SAFETY_NET_REGISTRY_COUNT) {
Preconditions.checkState(null == REAPER_THREAD);
try {
REAPER_THREAD = reaperThreadSupplier.get();
REAPER_THREAD.start();
} catch (Throwable throwable) {
REAPER_THREAD = null;
throw throwable;
}
}
++GLOBAL_SAFETY_NET_REGISTRY_COUNT;
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97f9193f189afae6147d9d1bdd68beb132bc63ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805)
* 37dbf5a71db743b3aaef83538be71bc5bd1a7415 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bf2aa2f54e22e76fed071e3c614139d4d187fc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757a2307f027acba2aca26f7f5ec6f9639ce9079 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721)
* caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7df4077fb5715e0a9ce097b773f49a197eb27dd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461)
* 9a73076f072352ba5539bf558f90a94572fb6c36 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r426350896
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -27,18 +27,31 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
import java.io.Closeable;
import java.io.IOException;
import java.util.concurrent.atomic.AtomicInteger;
+import static org.powermock.api.mockito.PowerMockito.doNothing;
+import static org.powermock.api.mockito.PowerMockito.doThrow;
+import static org.powermock.api.mockito.PowerMockito.whenNew;
+
/**
* Tests for the {@link SafetyNetCloseableRegistry}.
*/
+@RunWith(PowerMockRunner.class)
Review comment:
Mockito is not recommended for Flink tests.
An alternative is to introduce a new constructor `SafetyNetCloseableRegistry(CloseableReaperThread)` and a test class which overrides `CloseableReaperThread`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97f9193f189afae6147d9d1bdd68beb132bc63ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805)
* 37dbf5a71db743b3aaef83538be71bc5bd1a7415 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757a2307f027acba2aca26f7f5ec6f9639ce9079 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721)
* caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800)
* 97f9193f189afae6147d9d1bdd68beb132bc63ac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-631838808
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37dbf5a71db743b3aaef83538be71bc5bd1a7415 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831)
* 0bf2aa2f54e22e76fed071e3c614139d4d187fc4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800)
* 97f9193f189afae6147d9d1bdd68beb132bc63ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427012948
##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
##########
@@ -186,6 +212,15 @@ private CloseableReaperThread() {
this.running = true;
}
+ @VisibleForTesting
+ CloseableReaperThread(String name) {
Review comment:
Why adding a new constructor here?
If you are blocked by the existing private constructor, you can just change it to protected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-631348376
Thanks for opening the PR and addressing the comments. @wanglijie95
Will merge it once AZP gives green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-630793220
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629337037
Hi @zhuzhurk , can you review my code? If you are free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
}, {
"hash" : "bd9add8e480455265ca95b863601f6608918b334",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907",
"triggerID" : "bd9add8e480455265ca95b863601f6608918b334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bf2aa2f54e22e76fed071e3c614139d4d187fc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860)
* bd9add8e480455265ca95b863601f6608918b334 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7df4077fb5715e0a9ce097b773f49a197eb27dd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7df4077fb5715e0a9ce097b773f49a197eb27dd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461)
* 9a73076f072352ba5539bf558f90a94572fb6c36 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427010925
##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
##########
@@ -73,8 +73,34 @@
synchronized (REAPER_THREAD_LOCK) {
if (0 == GLOBAL_SAFETY_NET_REGISTRY_COUNT) {
Preconditions.checkState(null == REAPER_THREAD);
- REAPER_THREAD = new CloseableReaperThread();
- REAPER_THREAD.start();
+ try {
+ REAPER_THREAD = new CloseableReaperThread();
+ REAPER_THREAD.start();
+ } catch (Throwable throwable) {
+ // thread create or start error.
+ REAPER_THREAD = null;
+ throw throwable;
+ }
+ }
+ ++GLOBAL_SAFETY_NET_REGISTRY_COUNT;
+ }
+ }
+
+ @VisibleForTesting
+ SafetyNetCloseableRegistry(CloseableReaperThread reaperThread) {
Review comment:
We should avoid duplicating the codes.
Below is a possible way to make it.
```
SafetyNetCloseableRegistry() {
this(() -> new CloseableReaperThread());
}
@VisibleForTesting
SafetyNetCloseableRegistry(Supplier<CloseableReaperThread> reaperThreadSupplier) {
super(new IdentityHashMap<>());
synchronized (REAPER_THREAD_LOCK) {
if (0 == GLOBAL_SAFETY_NET_REGISTRY_COUNT) {
Preconditions.checkState(null == REAPER_THREAD);
try {
REAPER_THREAD = reaperThreadSupplier.get();
REAPER_THREAD.start();
} catch (Throwable throwable) {
// thread create or start error.
REAPER_THREAD = null;
throw throwable;
}
}
++GLOBAL_SAFETY_NET_REGISTRY_COUNT;
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427794339
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -198,4 +198,29 @@ public void testReaperThreadSpawnAndStop() throws Exception {
}
Assert.assertFalse(SafetyNetCloseableRegistry.isReaperThreadRunning());
}
+
+ /**
+ * Test whether failure to start thread in {@link SafetyNetCloseableRegistry}
+ * constructor can lead to failure of subsequent state check.
+ */
+ @Test
+ public void testReaperThreadStartFailed() throws Exception {
+
+ try {
+ new SafetyNetCloseableRegistry(() -> new OutOfMemoryReaperThread());
+ } catch (java.lang.OutOfMemoryError error) {
+ }
+
Review comment:
We can add `isReaperThreadRunning` checks after the failed creation and the succeeded creation.
This helps to verify that a reaper thread is really created and running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-631363318
Thanks for review, @zhuzhurk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757a2307f027acba2aca26f7f5ec6f9639ce9079 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721)
* caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800)
* 97f9193f189afae6147d9d1bdd68beb132bc63ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757a2307f027acba2aca26f7f5ec6f9639ce9079 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721)
* caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
}, {
"hash" : "bd9add8e480455265ca95b863601f6608918b334",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907",
"triggerID" : "bd9add8e480455265ca95b863601f6608918b334",
"triggerType" : "PUSH"
}, {
"hash" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1920",
"triggerID" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"triggerType" : "PUSH"
}, {
"hash" : "fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1930",
"triggerID" : "fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05e0b2b0379e0b05c62631147b82711c32f11fcb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1920)
* fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1930)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r426375851
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -27,18 +27,31 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
import java.io.Closeable;
import java.io.IOException;
import java.util.concurrent.atomic.AtomicInteger;
+import static org.powermock.api.mockito.PowerMockito.doNothing;
+import static org.powermock.api.mockito.PowerMockito.doThrow;
+import static org.powermock.api.mockito.PowerMockito.whenNew;
+
/**
* Tests for the {@link SafetyNetCloseableRegistry}.
*/
+@RunWith(PowerMockRunner.class)
Review comment:
Thanks for reivew, @zhuzhurk . I will considier your comment. But `CloseableReaperThread ` is final class and can't be inherited, I will change this for override.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b954ba073cba912b98c5992b05caec91e7657871 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687)
* 757a2307f027acba2aca26f7f5ec6f9639ce9079 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629334445
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8 (Fri Oct 16 10:52:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427831205
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -198,4 +198,29 @@ public void testReaperThreadSpawnAndStop() throws Exception {
}
Assert.assertFalse(SafetyNetCloseableRegistry.isReaperThreadRunning());
}
+
+ /**
+ * Test whether failure to start thread in {@link SafetyNetCloseableRegistry}
+ * constructor can lead to failure of subsequent state check.
+ */
+ @Test
+ public void testReaperThreadStartFailed() throws Exception {
+
+ try {
+ new SafetyNetCloseableRegistry(() -> new OutOfMemoryReaperThread());
+ } catch (java.lang.OutOfMemoryError error) {
+ }
+
Review comment:
OK, I will add the check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
}, {
"hash" : "bd9add8e480455265ca95b863601f6608918b334",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907",
"triggerID" : "bd9add8e480455265ca95b863601f6608918b334",
"triggerType" : "PUSH"
}, {
"hash" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1920",
"triggerID" : "05e0b2b0379e0b05c62631147b82711c32f11fcb",
"triggerType" : "PUSH"
}, {
"hash" : "fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd9add8e480455265ca95b863601f6608918b334 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907)
* 05e0b2b0379e0b05c62631147b82711c32f11fcb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1920)
* fbefe16eb3f7769b6daf6cfe1fa26b7a0f7130a8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427838651
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -198,4 +198,29 @@ public void testReaperThreadSpawnAndStop() throws Exception {
}
Assert.assertFalse(SafetyNetCloseableRegistry.isReaperThreadRunning());
}
+
+ /**
+ * Test whether failure to start thread in {@link SafetyNetCloseableRegistry}
+ * constructor can lead to failure of subsequent state check.
+ */
+ @Test
+ public void testReaperThreadStartFailed() throws Exception {
+
+ try {
+ new SafetyNetCloseableRegistry(() -> new OutOfMemoryReaperThread());
+ } catch (java.lang.OutOfMemoryError error) {
+ }
+
+ // the OOM error will not lead to failure of subsequent constructor call.
+ SafetyNetCloseableRegistry closeableRegistry = new SafetyNetCloseableRegistry();
+ closeableRegistry.close();
+ }
+
+ static class OutOfMemoryReaperThread extends SafetyNetCloseableRegistry.CloseableReaperThread {
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r426358510
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -198,4 +211,27 @@ public void testReaperThreadSpawnAndStop() throws Exception {
}
Assert.assertFalse(SafetyNetCloseableRegistry.isReaperThreadRunning());
}
+
+ /**
+ * Test for FLINK-17645.
Review comment:
I think this line is not needed. It can be tracked via git log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37dbf5a71db743b3aaef83538be71bc5bd1a7415 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629334445
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a7df4077fb5715e0a9ce097b773f49a197eb27dd (Fri May 15 15:52:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
}, {
"hash" : "bd9add8e480455265ca95b863601f6608918b334",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907",
"triggerID" : "bd9add8e480455265ca95b863601f6608918b334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd9add8e480455265ca95b863601f6608918b334 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1461",
"triggerID" : "a7df4077fb5715e0a9ce097b773f49a197eb27dd",
"triggerType" : "PUSH"
}, {
"hash" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1510",
"triggerID" : "9a73076f072352ba5539bf558f90a94572fb6c36",
"triggerType" : "PUSH"
}, {
"hash" : "b954ba073cba912b98c5992b05caec91e7657871",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1687",
"triggerID" : "b954ba073cba912b98c5992b05caec91e7657871",
"triggerType" : "PUSH"
}, {
"hash" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1721",
"triggerID" : "757a2307f027acba2aca26f7f5ec6f9639ce9079",
"triggerType" : "PUSH"
}, {
"hash" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1800",
"triggerID" : "caf4400401fbaffaaeb0e16fafe3de1bcee1cc8b",
"triggerType" : "PUSH"
}, {
"hash" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1805",
"triggerID" : "97f9193f189afae6147d9d1bdd68beb132bc63ac",
"triggerType" : "PUSH"
}, {
"hash" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1831",
"triggerID" : "37dbf5a71db743b3aaef83538be71bc5bd1a7415",
"triggerType" : "PUSH"
}, {
"hash" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860",
"triggerID" : "0bf2aa2f54e22e76fed071e3c614139d4d187fc4",
"triggerType" : "PUSH"
}, {
"hash" : "bd9add8e480455265ca95b863601f6608918b334",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd9add8e480455265ca95b863601f6608918b334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bf2aa2f54e22e76fed071e3c614139d4d187fc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1860)
* bd9add8e480455265ca95b863601f6608918b334 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk merged pull request #12181: [FLINK-17645][runtime] Reset SafetyNetCloseableRegistry#REAPER_THREAD if it fails to start
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #12181:
URL: https://github.com/apache/flink/pull/12181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-629603673
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12181:
URL: https://github.com/apache/flink/pull/12181#issuecomment-630079550
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #12181:
URL: https://github.com/apache/flink/pull/12181#discussion_r427792440
##########
File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java
##########
@@ -198,4 +198,29 @@ public void testReaperThreadSpawnAndStop() throws Exception {
}
Assert.assertFalse(SafetyNetCloseableRegistry.isReaperThreadRunning());
}
+
+ /**
+ * Test whether failure to start thread in {@link SafetyNetCloseableRegistry}
+ * constructor can lead to failure of subsequent state check.
+ */
+ @Test
+ public void testReaperThreadStartFailed() throws Exception {
+
+ try {
+ new SafetyNetCloseableRegistry(() -> new OutOfMemoryReaperThread());
+ } catch (java.lang.OutOfMemoryError error) {
+ }
+
+ // the OOM error will not lead to failure of subsequent constructor call.
+ SafetyNetCloseableRegistry closeableRegistry = new SafetyNetCloseableRegistry();
+ closeableRegistry.close();
+ }
+
+ static class OutOfMemoryReaperThread extends SafetyNetCloseableRegistry.CloseableReaperThread {
Review comment:
can be private
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org