[GitHub] nickva commented on issue #1017: Allow replicator documents to include params for db creation

[GitBox <gi...@apache.org>]

nickva commented on issue #1017: Allow replicator documents to include params for db creation
URL: https://github.com/apache/couchdb/pull/1017#issuecomment-347240154
 
 
   @jiangphcn Good work. Thanks for taking initiative and giving it a try.
   
   See some comments about tests and a general comment about the approach taken. I saw that q is special-cased and we don't allow other parameters. Wonder if we want to make it generic and allow users to specify other query parameters as well (n, placement, engine etc). In that case don't forget to also urlencode stuff, lookup query parameters encoding rules.
   
   As for local dbs, those are not just `shards/...` dbs could also be regular (simple) node local dbs, say 'my_target_db`. This endpoint format in general is problematic and doesn't work as most users expect it. It used to create local dbs in a CouchDB 1.x and 2.x with clustering it should really create a db via fabric, now it just creates a db on the random node where replication runs. Ideally we might want to handle some parameters there as well (the ones that make sense, like say `engine` for future PSE work). But in practice, I think we shouldn't bother and just ignore it params like you already do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services