You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/09 12:36:24 UTC

[PR] fix: exclude disabled alert rules from Prometheus export [rocketmq-dashboard]

Aias00 opened a new pull request, #1299:
URL: https://github.com/apache/rocketmq-dashboard/pull/1299

   ## What is the purpose of the change
   
   Disabled alert rules were still serialized into the Prometheus rule YAML export, so loading that YAML could activate a rule that an operator had disabled in Studio.
   
   Closes #1298
   
   ## Brief changelog
   
   - Filter persisted alert rules by `enabled` before producing Prometheus YAML.
   - Preserve the bundled default rule fallback when no enabled configured rules remain.
   - Add mixed enabled/disabled and disabled-only regression coverage.
   
   ## Verifying this change
   
   ```bash
   cd server
   JAVA_HOME=$(/usr/libexec/java_home -v 21) PATH="$JAVA_HOME/bin:$PATH" \
     mvn -q -Dtest=AlertServiceTest test
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: exclude disabled alert rules from Prometheus export [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #1299: fix: exclude disabled alert rules from Prometheus export
URL: https://github.com/apache/rocketmq-dashboard/pull/1299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: exclude disabled alert rules from Prometheus export [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1299:
URL: https://github.com/apache/rocketmq-dashboard/pull/1299#issuecomment-5234922726

   Consolidated into #1311, which now includes the enabled-rule export behavior and regression coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org