You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chukwa.apache.org by "Jerome Boulon (JIRA)" <ji...@apache.org> on 2009/03/23 21:23:50 UTC
[jira] Created: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
FileAdaptor not closing RandomAccessFile
----------------------------------------
Key: CHUKWA-44
URL: https://issues.apache.org/jira/browse/CHUKWA-44
Project: Hadoop Chukwa
Issue Type: Bug
Reporter: Jerome Boulon
Priority: Blocker
FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Boulon updated CHUKWA-44:
--------------------------------
Attachment: CHUKWA-44.patch
> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
> Key: CHUKWA-44
> URL: https://issues.apache.org/jira/browse/CHUKWA-44
> Project: Hadoop Chukwa
> Issue Type: Bug
> Reporter: Jerome Boulon
> Priority: Blocker
> Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Boulon reassigned CHUKWA-44:
-----------------------------------
Assignee: Jerome Boulon
> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
> Key: CHUKWA-44
> URL: https://issues.apache.org/jira/browse/CHUKWA-44
> Project: Hadoop Chukwa
> Issue Type: Bug
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Priority: Blocker
> Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Boulon updated CHUKWA-44:
--------------------------------
Status: Patch Available (was: Open)
This patch close the reader at the end of the start method however working on this issue I've found a bigger one: CHUKWA-57
> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
> Key: CHUKWA-44
> URL: https://issues.apache.org/jira/browse/CHUKWA-44
> Project: Hadoop Chukwa
> Issue Type: Bug
> Reporter: Jerome Boulon
> Priority: Blocker
> Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12690006#action_12690006 ]
Jerome Boulon commented on CHUKWA-44:
-------------------------------------
This patch fix what this Jira is about.
However yes this class was very badly designed in the first place, the start method should not have the reading part CHUKWA-57 will be a way to fix that.
Adding retry in the start method will just add more latency on the remote client side and would still be a bad design decision.
> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
> Key: CHUKWA-44
> URL: https://issues.apache.org/jira/browse/CHUKWA-44
> Project: Hadoop Chukwa
> Issue Type: Bug
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Priority: Blocker
> Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin resolved CHUKWA-44.
------------------------------
Resolution: Duplicate
Fixed by CHUKWA-70
> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
> Key: CHUKWA-44
> URL: https://issues.apache.org/jira/browse/CHUKWA-44
> Project: Hadoop Chukwa
> Issue Type: Bug
> Components: data collection
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Priority: Blocker
> Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin updated CHUKWA-44:
-----------------------------
Component/s: data collection
> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
> Key: CHUKWA-44
> URL: https://issues.apache.org/jira/browse/CHUKWA-44
> Project: Hadoop Chukwa
> Issue Type: Bug
> Components: data collection
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Priority: Blocker
> Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-44) FileAdaptor not closing
RandomAccessFile
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated CHUKWA-44:
----------------------------
Status: Open (was: Patch Available)
This patch does not work correctly, if the add command happens before the file is available on disk. There should be retries before giving up. This is for the job instrumentation class received job conf file name before the file land on disk.
> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
> Key: CHUKWA-44
> URL: https://issues.apache.org/jira/browse/CHUKWA-44
> Project: Hadoop Chukwa
> Issue Type: Bug
> Reporter: Jerome Boulon
> Priority: Blocker
> Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.