You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "eric schwartz (JIRA)" <ji...@apache.org> on 2007/01/23 15:21:50 UTC
[jira] Created: (OFBIZ-646) the table row the appbar tabs apear in
(appbar.ftl) has the table row background color of white hardcoded
the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
----------------------------------------------------------------------------------------------------------
Key: OFBIZ-646
URL: https://issues.apache.org/jira/browse/OFBIZ-646
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: eric schwartz
Priority: Minor
Fix For: SVN trunk
i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-646) the table row the appbar tabs apear in
(appbar.ftl) has the table row background color of white hardcoded
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Si Chen closed OFBIZ-646.
-------------------------
Resolution: Fixed
Committed in r 519070. Thanks!
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.patch, layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481682 ]
Si Chen commented on OFBIZ-646:
-------------------------------
Adrian, Eric -
Do we still need this patch, or have the recent refactorings taken care of it already?
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481690 ]
Si Chen commented on OFBIZ-646:
-------------------------------
please
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "eric schwartz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467106 ]
eric schwartz commented on OFBIZ-646:
-------------------------------------
i am always willing to help. keep me posted.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Si Chen reassigned OFBIZ-646:
-----------------------------
Assignee: Si Chen
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467211 ]
Adrian Crum commented on OFBIZ-646:
-----------------------------------
Eric,
You should take a look at OFBIZ-633.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466757 ]
Adrian Crum commented on OFBIZ-646:
-----------------------------------
Eric,
Thank you for taking the time to submit this patch. There is an initiative under way to refactor the UI to eliminate table-based layout - which, when completed, will solve this problem. If you're interested in contributing to that effort, please let me know and I'll keep you updated.
-Adrian
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-646) the table row the appbar tabs apear in
(appbar.ftl) has the table row background color of white hardcoded
Posted by "eric schwartz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
eric schwartz updated OFBIZ-646:
--------------------------------
Attachment: layoutpatches.txt
this is the patch for appbar.ftl and maincss.css.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481687 ]
Adrian Crum commented on OFBIZ-646:
-----------------------------------
Si,
We still need this patch for now. It will be unnecessary in the long run because the main navigation will be refactored eventually.
maincss.css has gone through many changes since this patch was submitted though. I can prepare an updated one if you like.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467178 ]
Si Chen commented on OFBIZ-646:
-------------------------------
I will commit this unless there are objections.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467183 ]
Adrian Crum commented on OFBIZ-646:
-----------------------------------
No objections here. It's a trivial change, so there shouldn't be any issues with it.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467191 ]
Jacques Le Roux commented on OFBIZ-646:
---------------------------------------
Sounds fine to me.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-646) the table row the appbar tabs apear
in (appbar.ftl) has the table row background color of white hardcoded
Posted by "eric schwartz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467197 ]
eric schwartz commented on OFBIZ-646:
-------------------------------------
thanks, i have a few more issues similar to post. there are some places were
the proper styles arent being used. when i get them all together i will post
them.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-646) the table row the appbar tabs apear in
(appbar.ftl) has the table row background color of white hardcoded
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-646:
------------------------------
Attachment: layoutpatches.patch
Updated patch file.
> the table row the appbar tabs apear in (appbar.ftl) has the table row background color of white hardcoded
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-646
> URL: https://issues.apache.org/jira/browse/OFBIZ-646
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: eric schwartz
> Assigned To: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: layoutpatches.patch, layoutpatches.txt
>
>
> i was wanting to change the header to black or really any other color than white for my boss and noticed that they had the table row color behind the appbar tabs hard coded to white. i went ahead and made a change to appbar.ftl to use a class of appbar on that table row and made a class called appbar in the maincss.css file so now you can specify that color or anything else you want about that table row in the style sheet. i am sure as i modify the layout i fill find many more places like this. i will fix them and submit them as i find them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.