You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/10/19 18:12:02 UTC
[I] [Enhancement] Complete ASF source headers in first-party frontend files [rocketmq-dashboard]
zmuxuny opened a new issue, #7158:
URL: https://github.com/apache/rocketmq-dashboard/issues/7158
### Before Creating the Enhancement Request
- [x] I have confirmed this is an enhancement rather than a bug or a new feature.
- [x] I have searched the [open issues](https://github.com/apache/rocketmq-dashboard/issues) and believe this is not a duplicate.
### Summary
Complete the existing ASF source header in 19 first-party frontend source files on rocketmq-studio at 127c47b06a268cc74224d5f34c56ec7c36ac0d55. This is one source-distribution metadata cleanup with no runtime behavior change: 18 files have no source header, while web/src/utils/format.test.ts already has an Apache-2.0 SPDX identifier that must be preserved.
### Motivation
CONTRIBUTING.md requires source headers and links the ASF Source Header and Copyright Notice Policy. A standalone source file should carry the existing license, NOTICE pointer and contributor-provenance information, rather than relying only on the repository-level LICENSE.
References:
- https://github.com/apache/rocketmq-dashboard/blob/127c47b06a268cc74224d5f34c56ec7c36ac0d55/CONTRIBUTING.md#L123-L126
- https://www.apache.org/legal/src-headers.html
The policy also describes an SPDX form with three required lines. The single SPDX identifier currently in format.test.ts does not include the NOTICE pointer and contributor-provenance lines. Keep that original identifier and prepend the same complete header used by adjacent source files.
### Describe the Solution You'd Like
Prepend the exact existing header from web/src/App.tsx to these reviewed project-source files:
- web/src/api/{acl,connections,message,ops}.ts
- web/src/config.ts
- web/src/pages/home/dashboard.tsx
- web/src/pages/login/index.css
- web/src/pages/login/index.test.tsx
- web/src/services/{aclService,clusterService,connectionsService,consumerService,dashboardService,instanceService,messageService,opsService,topicService}.ts
- web/src/utils/apiError.ts
- web/src/utils/format.test.ts
Preserve all original bytes, including SPDX and ordinary comments. Do not reformat code or change LICENSE, NOTICE, copyright ownership, dependencies, generated files or third-party assets. Verification should compare committed Git blobs and prove that removing the exact inserted prefix restores every original byte and file mode.
### Describe Alternatives You've Considered
Leave the files as they are, or introduce a new header format/checker. Reusing the existing project header is the smaller change; a new repository-wide checker or license policy is unnecessary for this cleanup. The existing dependency-license build gate checks different materials and is not claimed to fail or be fixed here.
### Additional Context
Each candidate was inspected and tied to merged Studio maintenance patches (#445, #462, #490, #631, #2385, #4837 and #4829). No generated/vendor/third-party copyright marker was found in these files. The third-party model SVG assets listed in web/LICENSE are outside the scope.
All-state targeted issue/PR searches did not identify the same work. #6189 concerns CRLF in dependency-license checks; historical #14 concerns the old static/vendor tree and has no web/src files. Neither is this candidate.
This is a bounded source-header correction, not a claim that the whole repository has undergone a complete license audit. No production edits have been made before filing this report.
### Are You Willing to Submit a Pull Request?
- [x] Yes, I am willing to submit a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Complete ASF source headers in first-party frontend files [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7158:
URL: https://github.com/apache/rocketmq-dashboard/issues/7158#issuecomment-6430481642
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Complete ASF source headers in first-party frontend files [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #7158: [Enhancement] Complete ASF source headers in first-party frontend files
URL: https://github.com/apache/rocketmq-dashboard/issues/7158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org