You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "DarvenDuan (via GitHub)" <gi...@apache.org> on 2023/03/17 07:23:15 UTC
[GitHub] [doris] DarvenDuan opened a new pull request, #17897: [Enhancement] (auditLog) Support recording table names in fe.audit.log directly
DarvenDuan opened a new pull request, #17897:
URL: https://github.com/apache/doris/pull/17897
# Proposed changes
Issue Number: close #17891
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [X] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] DarvenDuan commented on a diff in pull request #17897: [Enhancement](auditLog)Support recording table names in fe.audit.log directly
Posted by "DarvenDuan (via GitHub)" <gi...@apache.org>.
DarvenDuan commented on code in PR #17897:
URL: https://github.com/apache/doris/pull/17897#discussion_r1147073384
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -548,6 +549,13 @@ public void execute(TUniqueId queryId) throws Exception {
olapScanNode.getCardinality(),
context.getQualifiedUser());
}
+
+ // set table names in fe.audit.log
Review Comment:
Thanks for your reply , It's a good suggestion for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #17897: [Enhancement](auditLog)Support recording table names in fe.audit.log directly
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #17897:
URL: https://github.com/apache/doris/pull/17897#discussion_r1140905338
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -548,6 +549,13 @@ public void execute(TUniqueId queryId) throws Exception {
olapScanNode.getCardinality(),
context.getQualifiedUser());
}
+
+ // set table names in fe.audit.log
Review Comment:
Few questions:
1. How to handle duplicate table name, there may be 2 scan node will same table.
2. How to handle same table name from different database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #17897: [Enhancement](auditLog)Support recording table names in fe.audit.log directly
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17897:
URL: https://github.com/apache/doris/pull/17897#issuecomment-1482154901
related: #18060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] DarvenDuan closed pull request #17897: [Enhancement](auditLog)Support recording table names in fe.audit.log directly
Posted by "DarvenDuan (via GitHub)" <gi...@apache.org>.
DarvenDuan closed pull request #17897: [Enhancement](auditLog)Support recording table names in fe.audit.log directly
URL: https://github.com/apache/doris/pull/17897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org