You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2023/04/04 07:07:56 UTC

Re: Review Request 74368: RANGER-4149 : Create common module for HA support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74368/
-----------------------------------------------------------

(Updated April 4, 2023, 7:07 a.m.)


Review request for ranger, Ankita Sinha, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Repository: ranger


Description
-------

This patch is part of RANGER-4148.  
This common module act as common jar and will help other component to implement HA.


Diffs
-----

  pom.xml 3a039565d 
  ranger-common-ha/pom.xml PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java PRE-CREATION 
  ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/test/resources/log4j.xml PRE-CREATION 
  ranger-common-ha/src/test/resources/ranger-tagsync-site.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/74368/diff/1/


Testing
-------


Thanks,

Dineshkumar Yadav


Re: Review Request 74368: RANGER-4149 : Create common module for HA support

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74368/#review225363
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On April 10, 2023, 8:15 a.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74368/
> -----------------------------------------------------------
> 
> (Updated April 10, 2023, 8:15 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4149
>     https://issues.apache.org/jira/browse/RANGER-4149
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This patch is part of RANGER-4148.  
> This common module act as common jar and will help other component to implement HA.
> 
> 
> Diffs
> -----
> 
>   pom.xml de0617e2a 
>   ranger-common-ha/pom.xml PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java PRE-CREATION 
>   ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java PRE-CREATION 
>   ranger-common-ha/src/test/resources/log4j.xml PRE-CREATION 
>   ranger-common-ha/src/test/resources/ranger-tagsync-site.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74368/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 74368: RANGER-4149 : Create common module for HA support

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74368/
-----------------------------------------------------------

(Updated April 18, 2023, 10:49 a.m.)


Review request for ranger, Ankita Sinha, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Handle null pointer exception


Bugs: RANGER-4149
    https://issues.apache.org/jira/browse/RANGER-4149


Repository: ranger


Description
-------

This patch is part of RANGER-4148.  
This common module act as common jar and will help other component to implement HA.


Diffs (updated)
-----

  pom.xml a2cf8a639 
  ranger-common-ha/pom.xml PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java PRE-CREATION 
  ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/test/resources/log4j.xml PRE-CREATION 
  ranger-common-ha/src/test/resources/ranger-tagsync-site.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/74368/diff/5/

Changes: https://reviews.apache.org/r/74368/diff/4-5/


Testing
-------


Thanks,

Dineshkumar Yadav


Re: Review Request 74368: RANGER-4149 : Create common module for HA support

Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74368/#review225372
-----------------------------------------------------------


Ship it!




Ship It!

- Kishor Gollapalliwar


On April 12, 2023, 11:21 a.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74368/
> -----------------------------------------------------------
> 
> (Updated April 12, 2023, 11:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4149
>     https://issues.apache.org/jira/browse/RANGER-4149
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This patch is part of RANGER-4148.  
> This common module act as common jar and will help other component to implement HA.
> 
> 
> Diffs
> -----
> 
>   pom.xml d658bf985 
>   ranger-common-ha/pom.xml PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java PRE-CREATION 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java PRE-CREATION 
>   ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java PRE-CREATION 
>   ranger-common-ha/src/test/resources/log4j.xml PRE-CREATION 
>   ranger-common-ha/src/test/resources/ranger-tagsync-site.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74368/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 74368: RANGER-4149 : Create common module for HA support

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74368/
-----------------------------------------------------------

(Updated April 12, 2023, 11:21 a.m.)


Review request for ranger, Ankita Sinha, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

removed whitespace


Bugs: RANGER-4149
    https://issues.apache.org/jira/browse/RANGER-4149


Repository: ranger


Description
-------

This patch is part of RANGER-4148.  
This common module act as common jar and will help other component to implement HA.


Diffs (updated)
-----

  pom.xml d658bf985 
  ranger-common-ha/pom.xml PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java PRE-CREATION 
  ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/test/resources/log4j.xml PRE-CREATION 
  ranger-common-ha/src/test/resources/ranger-tagsync-site.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/74368/diff/4/

Changes: https://reviews.apache.org/r/74368/diff/3-4/


Testing
-------


Thanks,

Dineshkumar Yadav


Re: Review Request 74368: RANGER-4149 : Create common module for HA support

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74368/
-----------------------------------------------------------

(Updated April 10, 2023, 8:15 a.m.)


Review request for ranger, Ankita Sinha, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4149
    https://issues.apache.org/jira/browse/RANGER-4149


Repository: ranger


Description
-------

This patch is part of RANGER-4148.  
This common module act as common jar and will help other component to implement HA.


Diffs (updated)
-----

  pom.xml de0617e2a 
  ranger-common-ha/pom.xml PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java PRE-CREATION 
  ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/test/resources/log4j.xml PRE-CREATION 
  ranger-common-ha/src/test/resources/ranger-tagsync-site.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/74368/diff/3/

Changes: https://reviews.apache.org/r/74368/diff/2-3/


Testing
-------


Thanks,

Dineshkumar Yadav


Re: Review Request 74368: RANGER-4149 : Create common module for HA support

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74368/
-----------------------------------------------------------

(Updated April 5, 2023, 8:14 a.m.)


Review request for ranger, Ankita Sinha, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4149
    https://issues.apache.org/jira/browse/RANGER-4149


Repository: ranger


Description
-------

This patch is part of RANGER-4148.  
This common module act as common jar and will help other component to implement HA.


Diffs (updated)
-----

  pom.xml 3a039565d 
  ranger-common-ha/pom.xml PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java PRE-CREATION 
  ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java PRE-CREATION 
  ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java PRE-CREATION 
  ranger-common-ha/src/test/resources/log4j.xml PRE-CREATION 
  ranger-common-ha/src/test/resources/ranger-tagsync-site.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/74368/diff/2/

Changes: https://reviews.apache.org/r/74368/diff/1-2/


Testing
-------


Thanks,

Dineshkumar Yadav