You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/10/10 02:10:07 UTC
[GitHub] taegeonum commented on a change in pull request #122: [NEMO-213]
Use Beam's DoFnRunners to execute DoFn
taegeonum commented on a change in pull request #122: [NEMO-213] Use Beam's DoFnRunners to execute DoFn
URL: https://github.com/apache/incubator-nemo/pull/122#discussion_r223916024
##########
File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslator.java
##########
@@ -64,14 +73,18 @@
private final Map<Class<? extends PTransform>, Method> primitiveTransformToTranslator = new HashMap<>();
private final Map<Class<? extends PTransform>, Method> compositeTransformToTranslator = new HashMap<>();
+ private static final AtomicReference<Pipeline> PIPELINE = new AtomicReference<>();
Review comment:
This requires some refactoring because `TranslationContext` is created when calling `PipelineTranslator.apply` function. But, `PipelineTranslator` implements `BiFunction<CompositeTransformVertex, ...>` so we can only handover the `CompositeTransformVertex` in line 88. How about creating a separate issue for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services