You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/11/17 05:04:49 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/440
ZEPPELIN-426 - Allowing new paragraph under the last one
Adding a paragraph under the last one of the notebook was not allowed.
I tested a lot of different cases:
* While running the full note
* With or Without content in the last paragraph
* with or Without saved content in the last paragraph
And didn't find any issue to allow that feature on that last paragraph
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/ZEPPELIN-426
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #440
----
commit 8bf82a5563c4567a62300fdbed8d885d0ee5538f
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-17T03:58:10Z
Remove alert on insert paragraph from last one
commit 2e168c41ae898bdc46bfb134116c216396bb113b
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-17T04:00:12Z
Remove jshint global
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/440#issuecomment-157614045
This may be totally unrelated, but, both $.fn.jquery and jQuery.fn.jquery returns "2.1.4"; which means $ is pointing to jQuery. Shouldn't we allow only one of these, so that its always more readable.
Otherwise Looks good to me, gets compiled well, runs well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/440#issuecomment-157615246
Working well. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/440#issuecomment-157627009
@prabhjyotsingh good point, actually none of them should be authorized.
Usually we ask people not to use $ or jQuery if it's not in a directive, however it was done in some cases.
However since people use it, we ask that to be made with the help of ``angular.element``.
There might be a few leftover in the code that are not using it, bit this should be the work of another PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/440#issuecomment-157262507
Ready for tests/reviews
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/440#issuecomment-157420527
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---