[GitHub] [hbase] hyeongseok85 commented on a change in pull request #4215: HBASE-26630 TableSnapshotInputFormat terminates in the middle

[GitBox <gi...@apache.org>]

hyeongseok85 commented on a change in pull request #4215:
URL: https://github.com/apache/hbase/pull/4215#discussion_r826727405



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java
##########
@@ -93,9 +93,12 @@ public ClientSideRegionScanner(Configuration conf, FileSystem fs,
   @Override
   public Result next() throws IOException {
     values.clear();
-    scanner.nextRaw(values);
-    if (values.isEmpty()) {
-      //we are done
+    boolean moreValues;
+    do {
+      moreValues = scanner.nextRaw(values);
+    } while (values.isEmpty() && moreValues);
+
+    if (!moreValues) {

Review comment:
       Scan is not an RPC timeout situation. After scannerContext.returnImmediately() is called in storeScanner, it is returned as true by scannerContext.checkTimeLimit(limitScope) in RegionScannerImpl.
   
   https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java#L563




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org