You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2026/01/28 02:31:15 UTC
[PR] [fix](encrypt)encrypt key is not case sensitive [doris]
englefly opened a new pull request, #60288:
URL: https://github.com/apache/doris/pull/60288
### What problem does this PR solve?
when we create encrypt key, all keys are transformed to lower case. However, when we query key, the key name is case sensitive.
key name should be case in-sensitive.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808729374
<details>
<summary>TPC-H: <b>Total hot run time: 31539 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8e2616a271e02d898bc3d373eb4e84a5e568e35b, data reload: false
------ Round 1 ----------------------------------
q1 17638 5197 5075 5075
q2 2024 298 200 200
q3 10249 1284 741 741
q4 10198 803 318 318
q5 7557 2147 1868 1868
q6 204 186 152 152
q7 925 720 596 596
q8 9264 1339 1075 1075
q9 5200 4806 4773 4773
q10 6818 1929 1549 1549
q11 510 305 270 270
q12 335 369 220 220
q13 17786 4091 3216 3216
q14 246 247 231 231
q15 905 826 808 808
q16 675 660 636 636
q17 632 819 452 452
q18 6628 6566 6339 6339
q19 1356 995 586 586
q20 405 345 229 229
q21 2561 1991 1929 1929
q22 355 312 276 276
Total cold run time: 102471 ms
Total hot run time: 31539 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5316 5350 5303 5303
q2 257 332 270 270
q3 2166 2679 2282 2282
q4 1360 1722 1287 1287
q5 4303 4173 4182 4173
q6 222 181 139 139
q7 1908 2291 1884 1884
q8 2647 2467 2432 2432
q9 7569 7650 7766 7650
q10 2866 3056 2769 2769
q11 571 473 462 462
q12 764 795 644 644
q13 4000 4590 3909 3909
q14 301 317 300 300
q15 875 853 858 853
q16 733 776 703 703
q17 1184 1461 1443 1443
q18 7821 7928 8094 7928
q19 876 837 838 837
q20 2066 2154 2054 2054
q21 4437 4210 4089 4089
q22 572 556 508 508
Total cold run time: 52814 ms
Total hot run time: 51919 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808621445
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3809137672
# FE Regression Coverage Report
Increment line coverage ` 100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60288_8e2616a271e02d898bc3d373eb4e84a5e568e35b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60288_8e2616a271e02d898bc3d373eb4e84a5e568e35b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3809178779
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808922212
# FE UT Coverage Report
Increment line coverage ` 100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60288_8e2616a271e02d898bc3d373eb4e84a5e568e35b/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60288_8e2616a271e02d898bc3d373eb4e84a5e568e35b/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808763140
<details>
<summary>ClickBench: <b>Total hot run time: 28.59 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8e2616a271e02d898bc3d373eb4e84a5e568e35b, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.04
query3 0.25 0.09 0.09
query4 1.60 0.11 0.12
query5 0.27 0.26 0.25
query6 1.18 0.68 0.67
query7 0.03 0.02 0.03
query8 0.05 0.04 0.04
query9 0.57 0.50 0.50
query10 0.55 0.56 0.54
query11 0.13 0.09 0.10
query12 0.13 0.10 0.11
query13 0.62 0.62 0.62
query14 1.08 1.06 1.06
query15 0.88 0.87 0.87
query16 0.39 0.41 0.39
query17 1.14 1.16 1.09
query18 0.23 0.21 0.20
query19 2.11 2.02 1.97
query20 0.02 0.02 0.02
query21 15.44 0.26 0.14
query22 5.39 0.05 0.05
query23 16.10 0.29 0.10
query24 1.39 0.69 0.63
query25 0.07 0.09 0.06
query26 0.13 0.14 0.13
query27 0.07 0.06 0.06
query28 5.11 1.14 0.96
query29 12.56 3.80 3.14
query30 0.28 0.13 0.11
query31 2.81 0.64 0.40
query32 3.23 0.59 0.50
query33 3.38 3.21 3.36
query34 16.29 5.44 4.72
query35 4.77 4.80 4.85
query36 0.66 0.50 0.49
query37 0.11 0.07 0.07
query38 0.07 0.04 0.04
query39 0.04 0.03 0.02
query40 0.19 0.15 0.15
query41 0.09 0.03 0.02
query42 0.05 0.03 0.03
query43 0.05 0.04 0.04
Total cold run time: 99.66 s
Total hot run time: 28.59 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808621358
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3809605261
# FE Regression Coverage Report
Increment line coverage ` 100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60288_8e2616a271e02d898bc3d373eb4e84a5e568e35b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60288_8e2616a271e02d898bc3d373eb4e84a5e568e35b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808608896
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808612262
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60288:
URL: https://github.com/apache/doris/pull/60288#issuecomment-3808735641
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](encrypt)encrypt key is not case sensitive [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly merged PR #60288:
URL: https://github.com/apache/doris/pull/60288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org