[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9581: [Enhancement] [Memory] [Vectorized] Stress test and optimize memory allocation

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #9581:
URL: https://github.com/apache/incubator-doris/pull/9581#discussion_r873289846


##########
be/src/common/config.h:
##########
@@ -413,10 +413,14 @@ CONF_Bool(disable_mem_pools, "false");
 // to a relative large number or the performance is very very bad.
 CONF_Bool(use_mmap_allocate_chunk, "false");
 
-// Chunk Allocator's reserved bytes limit,
-// Default value is 2GB, increase this variable can improve performance, but will
-// acquire more free memory which can not be used by other modules
-CONF_Int64(chunk_reserved_bytes_limit, "2147483648");
+// process memory limit specified as number of bytes
+// defaults to bytes if no unit is given, increase this variable can improve performance,
+// but will acquire more free memory which can not be used by other modules.
+// must larger than 0. and if larger than physical memory size,
+// it will be set to physical memory size.
+CONF_mString(chunk_reserved_bytes_limit, "20%");
+// 1024, The minimum chunk allocator size (in bytes)
+CONF_Int32(min_chunk_reserved_bytes, "1024");

Review Comment:
   we need this config `BitUtil::IsPowerOf2`, we should better add more guide for how to set it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org