You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/03/24 21:00:51 UTC

Review Request 57922: Create ambari-infra module in Ambari (move solr modules out from ambari-logsearch)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57922/
-----------------------------------------------------------

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-20566
    https://issues.apache.org/jira/browse/AMBARI-20566


Repository: ambari


Description
-------

- Create new ambari-infra module
- Move ambari-infra-solr-plugin and ambari-infra-solr-client into that new module
- Add a new ambari-infra-assembly to ambari-infra module
- Move solr related rpm/deb build scripts from ambari-logsearch-assembly to ambari-infra-assembly

That patch is mostly for review, to commit this, we will need some change on rel-eng side as well


Diffs
-----

  ambari-infra/ambari-infra-assembly/pom.xml PRE-CREATION 
  ambari-infra/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-infra-solr-client/build.xml  
  ambari-logsearch/ambari-infra-solr-client/pom.xml 228d969 
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClientBuilder.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClientException.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/AbstractRetryCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/AbstractSolrRetryCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/AbstractStateFileZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/AbstractZookeeperConfigCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/AbstractZookeeperRetryCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/CheckConfigZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/CheckZnodeZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/CreateCollectionCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/CreateShardCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/CreateSolrZnodeZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/DownloadConfigZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/EnableKerberosPluginSolrZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/GetShardsCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/GetSolrHostsCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/GetStateFileZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/ListCollectionCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SecureSolrZNodeZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SecureZNodeZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SetClusterPropertyZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UpdateStateFileZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UploadConfigZkCommand.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/domain/AmbariSolrState.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/util/AclUtils.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/util/ShardUtils.java  
  ambari-logsearch/ambari-infra-solr-client/src/main/resources/log4j.properties  
  ambari-logsearch/ambari-infra-solr-client/src/main/resources/solrCloudCli.sh  
  ambari-logsearch/ambari-infra-solr-client/src/test/java/org/apache/ambari/infra/solr/AmbariSolrCloudClientTest.java  
  ambari-logsearch/ambari-infra-solr-plugin/pom.xml  
  ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java  
  ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java  
  ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java  
  ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java  
  ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java  
  ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java  
  ambari-logsearch/ambari-logsearch-assembly/pom.xml d286993 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr/control  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr/postinst  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr/postrm  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr/preinst  
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr/prerm  
  ambari-logsearch/ambari-logsearch-assembly/src/main/resources/solr  
  ambari-logsearch/ambari-logsearch-it/pom.xml c3188e7 
  ambari-logsearch/pom.xml 9397c22 
  ambari-project/pom.xml 9afebc7 
  pom.xml 2b0cb30 


Diff: https://reviews.apache.org/r/57922/diff/1/


Testing
-------

done. also rpms are generated corretly.


Thanks,

Oliver Szabo