You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/06/23 21:45:23 UTC

[kudu-CR] [thirdparty] fix building LLVM 9 with GCC 10

Hello Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17627

to look at the new patch set (#2).

Change subject: [thirdparty] fix building LLVM 9 with GCC 10
......................................................................

[thirdparty] fix building LLVM 9 with GCC 10

This patch fixes LLVM 9 build with GCC 10 in Kudu's thirdparty.  The
imported patch is already in the LLVM repo, see [1].

Prior to this patch, LLVM9 build in thirdparty would fail with the
following error:

  thirdparty/src/llvm-9.0.0.src/include/llvm/Demangle/MicrosoftDemangleNodes.h:566:3: error: unknown type name 'uint32_t'
    uint32_t NVOffset = 0;
    ^

[1] https://github.com/llvm-mirror/llvm/commit/e0402b5c9813a2458b8dd3f640883110db280395

Change-Id: I3332556229dbf2bce65d52f37c48d62624465f70
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-MicrosoftDemangleNodes-e0402b5c9813a2458b8dd3f640883110db280395.patch
2 files changed, 34 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/17627/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3332556229dbf2bce65d52f37c48d62624465f70
Gerrit-Change-Number: 17627
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)