You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/09/13 10:18:37 UTC

[Issue 125618] New: Chinese quotation mark in docx(compatible mode) disapeared in Writer

https://issues.apache.org/ooo/show_bug.cgi?id=125618

          Issue ID: 125618
        Issue Type: DEFECT
           Summary: Chinese quotation mark in docx(compatible mode)
                    disapeared in Writer
           Product: Writer
           Version: 4.1.1
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: open-import
          Assignee: issues@openoffice.apache.org
          Reporter: marklh9@gmail.com

Created attachment 83954
  --> https://issues.apache.org/ooo/attachment.cgi?id=83954&action=edit
Sample Test Case

A Chinese close quotation mark ( unicode 0x300d, 」 ) created in docx file
disapeared in Writer.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

review requested: [Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer : [Attachment 83958] Patch for 0xd eaten issue.

Posted by bu...@apache.org.
Mark Hung <ma...@gmail.com> has asked  for review:
Issue 125618: Chinese quotation mark in docx(compatible mode) disapeared in
Writer
https://issues.apache.org/ooo/show_bug.cgi?id=125618

Attachment 83958: Patch for 0xd eaten issue.
https://issues.apache.org/ooo/attachment.cgi?id=83958&action=edit


------- Additional Comments from Mark Hung <ma...@gmail.com>
Cast the pointer to sal_Unicode* solve the issue. 

I wonder why utext() didn't use sal_Unicode * directly.

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

--- Comment #5 from Oliver-Rainer Wittmann <or...@apache.org> ---
provided patch solved the *.docx import defect
--> I will commit the patch into trunk

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

Mark Hung <ma...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marklh9@gmail.com

--- Comment #1 from Mark Hung <ma...@gmail.com> ---
Created attachment 83955
  --> https://issues.apache.org/ooo/attachment.cgi?id=83955&action=edit
Illustration for the issue.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Oliver-Rainer Wittmann <or...@apache.org> ---
fixed in trunk by applying patch - kudos to Mark Hung for the patch

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #4 from Oliver-Rainer Wittmann <or...@apache.org> ---
I can confirm the defect on Windows 7 in AOO 4.1.1

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

Mark Hung <ma...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83958|                            |review?
              Flags|                            |

--- Comment #3 from Mark Hung <ma...@gmail.com> ---
Created attachment 83958
  --> https://issues.apache.org/ooo/attachment.cgi?id=83958&action=edit
Patch for 0xd eaten issue.

Cast the pointer to sal_Unicode* solve the issue. 

I wonder why utext() didn't use sal_Unicode * directly.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

--- Comment #2 from Mark Hung <ma...@gmail.com> ---
Created attachment 83957
  --> https://issues.apache.org/ooo/attachment.cgi?id=83957&action=edit
Illustration for the issue  II.

The second illustration shows, a single Chinese character run will be
mis-interpreted as new paragraph if the lower byte of the character is 0x0d.
Just mix English and Chinese you can easily create single character run.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83958|review?                     |review+
              Flags|                            |

--- Comment #6 from Oliver-Rainer Wittmann <or...@apache.org> ---
Comment on attachment 83958
  --> https://issues.apache.org/ooo/attachment.cgi?id=83958
Patch for 0xd eaten issue.

patch looks good

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

review granted: [Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer : [Attachment 83958] Patch for 0xd eaten issue.

Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has granted Mark Hung
<ma...@gmail.com>'s request for review:
Issue 125618: Chinese quotation mark in docx(compatible mode) disapeared in
Writer
https://issues.apache.org/ooo/show_bug.cgi?id=125618

Attachment 83958: Patch for 0xd eaten issue.
https://issues.apache.org/ooo/attachment.cgi?id=83958&action=edit


------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
patch looks good

[Issue 125618] Chinese quotation mark in docx(compatible mode) disapeared in Writer

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125618

--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1629834 into trunk:
125618: *.docx import: correct detection of paragraph break and line break
ch...

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.