You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/08/01 14:06:35 UTC
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request
#595: Add windows tests
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r309715326
##########
File path: bootstrap.sh
##########
@@ -472,7 +472,11 @@ build_cmake_command(){
if [ $? == 0 ]; then
echo "Using libcurl-openssl..."
else
- CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND} -DUSE_CURL_NSS=true .."
+ if [ "${USE_SHARED_LIBS}" = "${TRUE}" ]; then
+ CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND} -DUSE_CURL_NSS=true .."
Review comment:
this should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services