[GitHub] [incubator-livy] namanmishra91 commented on a change in pull request #119: [LIVY-527] added autocompletion api and implementation for ipython

[GitBox <gi...@apache.org>]

namanmishra91 commented on a change in pull request #119: [LIVY-527] added autocompletion api and implementation for ipython
URL: https://github.com/apache/incubator-livy/pull/119#discussion_r383172842
 
 

 ##########
 File path: repl/src/main/resources/fake_shell.py
 ##########
 @@ -46,9 +46,27 @@
 global_dict = {}
 job_context = None
 local_tmp_dir_path = None
+ip_completer = None
+p_completer = None
 
 TOP_FRAME_REGEX = re.compile(r'\s*File "<stdin>".*in <module>')
 
+
+def initialize_completer():
+    global ip_completer,p_completer
+    try:
+        __IPYTHON__
 
 Review comment:
   @wangqiaoshi Since fake_shell runs within a standard python process and not within an ipython shell, how will IPCompleter be initialized? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services