You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "xiaoyuandajian (via GitHub)" <gi...@apache.org> on 2023/02/03 03:46:24 UTC

[GitHub] [kyuubi] xiaoyuandajian commented on a diff in pull request #4162: [KYUUBI #4078] [FOLLOWUP] fix shellcheck violations in scripts of /bin folder

xiaoyuandajian commented on code in PR #4162:
URL: https://github.com/apache/kyuubi/pull/4162#discussion_r1095327341


##########
bin/stop-application.sh:
##########
@@ -16,8 +16,8 @@
 # limitations under the License.
 #
 
-# shellcheck disable=SC2071
-if [[ $# < 1 ]] ; then
+

Review Comment:
   Sorry, I didn't see your reply, I'll fix it this weekend



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org