You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by John Dilley <jo...@citrix.com> on 2014/09/02 15:38:03 UTC

Re: Review Request 24696: Only attempt to shrink volume in test if CLVM is in use

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24696/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 1:38 p.m.)


Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7228
    https://issues.apache.org/jira/browse/CLOUDSTACK-7228


Repository: cloudstack-git


Description
-------

Currently only CLVM supports shrinking volumes. This patch will only attempt to shrink a volume if CLVM is in use.


Diffs
-----

  test/integration/smoke/test_volumes.py e2e0d76 

Diff: https://reviews.apache.org/r/24696/diff/


Testing
-------

Tested on XenServer to check that the test now passes.


Thanks,

John Dilley


Re: Review Request 24696: Only attempt to shrink volume in test if CLVM is in use

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24696/#review52138
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Sept. 2, 2014, 1:38 p.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24696/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 1:38 p.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7228
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7228
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently only CLVM supports shrinking volumes. This patch will only attempt to shrink a volume if CLVM is in use.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py e2e0d76 
> 
> Diff: https://reviews.apache.org/r/24696/diff/
> 
> 
> Testing
> -------
> 
> Tested on XenServer to check that the test now passes.
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Re: Review Request 24696: Only attempt to shrink volume in test if CLVM is in use

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24696/#review52141
-----------------------------------------------------------


Pushed to master : 9b783d19ad7e784d3751f4eaa2a672401d122a01

- SrikanteswaraRao Talluri


On Sept. 2, 2014, 1:38 p.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24696/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 1:38 p.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7228
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7228
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently only CLVM supports shrinking volumes. This patch will only attempt to shrink a volume if CLVM is in use.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py e2e0d76 
> 
> Diff: https://reviews.apache.org/r/24696/diff/
> 
> 
> Testing
> -------
> 
> Tested on XenServer to check that the test now passes.
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Re: Review Request 24696: Only attempt to shrink volume in test if CLVM is in use

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24696/#review52136
-----------------------------------------------------------



test/integration/smoke/test_volumes.py
<https://reviews.apache.org/r/24696/#comment90882>

    yes, this should go in a separate patch.



test/integration/smoke/test_volumes.py
<https://reviews.apache.org/r/24696/#comment90886>

    As far as this patch is concerned , It looks fine.


- SrikanteswaraRao Talluri


On Sept. 2, 2014, 1:38 p.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24696/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 1:38 p.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7228
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7228
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently only CLVM supports shrinking volumes. This patch will only attempt to shrink a volume if CLVM is in use.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py e2e0d76 
> 
> Diff: https://reviews.apache.org/r/24696/diff/
> 
> 
> Testing
> -------
> 
> Tested on XenServer to check that the test now passes.
> 
> 
> Thanks,
> 
> John Dilley
> 
>